Skip to contentSkip to conversation

Fix yet another information-destroying backtrace in Xend

PATCH New Hollis Blanchard 1 participant 1 message Sep 5, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix yet another information-destroying backtrace in Xend

Every time you call traceback.print_exc() from an exception handler, you throw away all the traceback information you've accumulated to get to that spot. I'm not going to do a global find/replace without testing, but I know the below patch works and is needed.

Fix yet another information-destroying backtrace in Xend.

tools/python/xen/xend/server/SrvDaemon.py Tue Sep 05 16:12:25 2006 -0500 renamed from tools/python/xen/xend/server/SrvDaemon.py Tue Sep 05 14:44:20 2006 -0500 +1 -1
diff -r 343c37f11a8b tools/python/xen/xend/server/SrvDaemon.py
@@ -293,7 +293,7 @@ class Daemon:
         except Exception, ex:
             print >>sys.stderr, 'Exception starting xend:', ex
             if XEND_DEBUG:
-                traceback.print_exc()
+                raise
             log.exception("Exception starting xend (%s)" % ex)
             if status:
                 status.write('1')
Signature · 2 lines
Hollis Blanchard
IBM Linux Technology Center