Add support for Freescale QUICCEngine UART

Add file ucc_uart.c, a serial device driver for the Freescale QUICCEngine. Update the Kconfig and Makefile accordingly.

Signed-off-by Timur Tabi <[email protected]>

---

drivers/serial/Kconfig    |   10 +
drivers/serial/Makefile   |    1 +
drivers/serial/ucc_uart.c | 1507 ++++++++++++++++++++++++++++++++++++ 
+++++++++
3 files changed, 1518 insertions(+), 0 deletions(-)

create mode 100644 drivers/serial/ucc_uart.c

drivers/serial/ucc_uart.c new file +6 -0

new file mode 100644
index 0000000..6fe4cfc
@@ -0,0 +1,1507 @@
+/*
+ * Freescale QUICC Engine UART device driver
+ *
+ * Author: Timur Tabi <[email protected]>
+ *
+ * Copyright 2007 Freescale Semiconductor, Inc.  This file is  

licensed under
+ * the terms of the GNU General Public License version 2. This program
+ * is licensed "as is" without any warranty of any kind, whether express
+ * or implied.
+ *
+ * This driver adds support for UART devices via Freescale's QUICC Engine
+ * found on some Freescale SOCs.
+ *
+ * If Soft-UART support is needed but not already present, then this driver

+ * will request and upload the "Soft-UART" microcode upon probe. The
+ * filename of the microcode should be fsl_qe_ucode_uart_X_YZ.bin, where "X"
+ * is the name of the SOC (e.g. 8323), and YZ is the revision of the SOC,
+ * (e.g. "11" for 1.1).
+ */
+

drivers/serial/ucc_uart.c new file +36 -0

+#define UCC_WAIT_CLOSING 100
+
+struct ucc_uart_pram {
+	struct ucc_slow_pram common;
+	u8 res1[8];     	/* reserved */
+	__be16 maxidl;  	/* Maximum idle chars */
+	__be16 idlc;    	/* temp idle counter */
+	__be16 brkcr;   	/* Break count register */
+	__be16 parec;   	/* receive parity error counter */
+	__be16 frmec;   	/* receive framing error counter */
+	__be16 nosec;   	/* receive noise counter */
+	__be16 brkec;   	/* receive break condition counter */
+	__be16 brkln;   	/* last received break length */
+	__be16 uaddr[2];	/* UART address character 1 & 2 */
+	__be16 rtemp;   	/* Temp storage */
+	__be16 toseq;   	/* Transmit out of sequence char */
+	__be16 cchars[8];       /* control characters 1-8 */
+	__be16 rccm;    	/* receive control character mask */
+	__be16 rccr;    	/* receive control character register */
+	__be16 rlbc;    	/* receive last break character */
+	__be16 res2;    	/* reserved */
+	__be32 res3;    	/* reserved, should be cleared */
+	u8 res4;		/* reserved, should be cleared */
+	u8 res5[3];     	/* reserved, should be cleared */
+	__be32 res6;    	/* reserved, should be cleared */
+	__be32 res7;    	/* reserved, should be cleared */
+	__be32 res8;    	/* reserved, should be cleared */
+	__be32 res9;    	/* reserved, should be cleared */
+	__be32 res10;   	/* reserved, should be cleared */
+	__be32 res11;   	/* reserved, should be cleared */
+	__be32 res12;   	/* reserved, should be cleared */
+	__be32 res13;   	/* reserved, should be cleared */
+/* The rest is for Soft-UART only */
+	__be16 supsmr;  	/* 0x90, Shadow UPSMR */
+	__be16 res92;   	/* 0x92, reserved, initialize to 0 */
+	__be32 rx_state;	/* 0x94, RX state, initialize to 0 */

drivers/serial/ucc_uart.c new file +10 -0

+	u8 res15[0xD0 - 0xC8];  /* reserved */
+	__be32 resD0;   	/* 0xD0, reserved, initialize to 0 */
+	u8 resD4;       	/* 0xD4, reserved, initialize to 0 */
+	__be16 resD5;   	/* 0xD5, reserved, initialize to 0 */
+} __attribute__ ((packed));
+
 
 
 
 
+/*
+ * Set the modem control lines
+ *
+ * We currently don't support setting modem control lines, but this  

function
+ * needs to exist, otherwise the kernel will panic.
+ */

what is the define for? you commented all the others :)

Quoted 1 line

+#define UCC_WAIT_CLOSING 100

Quoted 1 line

+ u16 tx_state; /* 0xC6, TX state */

__be16?

Quoted 4 lines

+/*
+ * Set the modem control lines
+ *
+ * We currently don't support setting modem control lines, but this

drivers/serial/ucc_uart.c line 275

Quoted 6 lines

function
+ * needs to exist, otherwise the kernel will panic.
+ */

drivers/serial/ucc_uart.c new file +3 -0

+void qe_uart_set_mctrl(struct uart_port *port, unsigned int mctrl)
+{
+}

What's the issue w/support of this? (maybe a comment related to why its not supported -- if not here in the git commit message)

Review

Quoted 2 lines

(quoted diff) +2 -0

+static void qe_uart_enable_ms(struct uart_port *port)
+{

same question as above.

Quoted 1 line · Kumar Gala

what is the define for? you commented all the others :)

I thought you said there were no more issues? :-)

Quoted 3 lines

Quoted 3 lines

+#define UCC_WAIT_CLOSING 100

This is how long to wait after receiving a close request for characters to be sent out before actually closing the device. I just used the same value as the CPM serial driver.

Quoted 5 lines

Quoted 4 lines

+ u16 tx_state; /* 0xC6, TX state */

__be16?

Oops.

Quoted 11 lines

drivers/serial/ucc_uart.c line 275

Quoted 10 lines

+/*
+ * Set the modem control lines
+ *
+ * We currently don't support setting modem control lines, but this function
+ * needs to exist, otherwise the kernel will panic.
+ */

drivers/serial/ucc_uart.c new file +3 -0

+void qe_uart_set_mctrl(struct uart_port *port, unsigned int mctrl)
+{
+}

What's the issue w/support of this? (maybe a comment related to why its not supported -- if not here in the git commit message)

I didn't want to add any serial functionality that wasn't in the CPM serial driver, mostly because I don't really understand the technical details of serial communication at this level. I figured if it's okay for the CPM driver not to handle modem control, then the QE driver doesn't have to do it either.

Quoted 3 lines

Review

Quoted 2 lines

(quoted diff) +2 -0

+static void qe_uart_enable_ms(struct uart_port *port)
+{

same question as above.

Same answer!

I suppose you want me to post another version of this patch?

Add support for UART serial ports using a Freescale QUICCEngine. Update booting-without-of.txt to define new properties for a QE UART node. Update the MPC8323E-MDS device tree to add UCC5 as a UART. Update the QE library to support slow UCC devices and modules.

Signed-off-by Timur Tabi <[email protected]>

---
 Documentation/powerpc/booting-without-of.txt |    9 ++++-
 arch/powerpc/boot/dts/mpc832x_mds.dts        |   50 ++++++++++++++++++++++++++
 arch/powerpc/sysdev/qe_lib/Kconfig           |    2 +-
 arch/powerpc/sysdev/qe_lib/ucc_slow.c        |   10 +++++-
 4 files changed, 68 insertions(+), 3 deletions(-)