Skip to contentSkip to conversation

devtools: remove ethdev ABI exception

PATCH Applied David Marchand 5 participants 5 messages Feb 1, 2021 – Feb 5, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devtools: remove ethdev ABI exception

Now that the ethernet driver dev_ops structure definition is not exported anymore, there is no need for an exception. abidiff will only consider structures defined in the installed headers (passed with --headers-dirX options).

Fixes df96fd0d7395 ("ethdev: make driver-only headers private")
---
 devtools/libabigail.abignore | 2 --
 1 file changed, 2 deletions(-)
devtools/libabigail.abignore +0 -2
index ab5db240e7..6c0b38984e 100644
@@ -13,8 +13,6 @@
         name_regexp = _pmd_info$
 
 ; Explicit ignore for driver-only ABI
-[suppress_type]
-        name = eth_dev_ops
 [suppress_function]
         name_regexp = rte_vdev_(|un)register
 
Signature · 1 line
2.23.0
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · David Marchand

Now that the ethernet driver dev_ops structure definition is not exported anymore, there is no need for an exception. abidiff will only consider structures defined in the installed headers (passed with --headers-dirX options).

Fixes df96fd0d7395 ("ethdev: make driver-only headers private")
#2 lore raw

01/02/2021 20:03, Ferruh Yigit:

Quoted 11 lines · David Marchand
Quoted 8 lines

Now that the ethernet driver dev_ops structure definition is not exported anymore, there is no need for an exception. abidiff will only consider structures defined in the installed headers (passed with --headers-dirX options).

Fixes df96fd0d7395 ("ethdev: make driver-only headers private")

Applied, thanks

Acked-by on v1 1/1
#3 lore raw
In reply to David Marchand
Quoted 18 lines · David Marchand

Now that the ethernet driver dev_ops structure definition is not exported anymore, there is no need for an exception. abidiff will only consider structures defined in the installed headers (passed with --headers-dirX options).

Fixes df96fd0d7395 ("ethdev: make driver-only headers private")
---
 devtools/libabigail.abignore | 2 --
 1 file changed, 2 deletions(-)
devtools/libabigail.abignore +0 -0
index ab5db240e7..6c0b38984e 100644

devtools/libabigail.abignore line 18

Quoted 8 lines
devtools/libabigail.abignore +0 -2
@@ -13,8 +13,6 @@
         name_regexp = _pmd_info$
 
 ; Explicit ignore for driver-only ABI
-[suppress_type]
-        name = eth_dev_ops
 [suppress_function]
         name_regexp = rte_vdev_(|un)register
 
#4 lore raw
In reply to David Marchand
Quoted 17 lines · David Marchand

Now that the ethernet driver dev_ops structure definition is not exported anymore, there is no need for an exception. abidiff will only consider structures defined in the installed headers (passed with --headers-dirX options).

Fixes df96fd0d7395 ("ethdev: make driver-only headers private")
---
 devtools/libabigail.abignore | 2 --
 1 file changed, 2 deletions(-)
devtools/libabigail.abignore +0 -0
index ab5db240e7..6c0b38984e 100644

devtools/libabigail.abignore line 18

Quoted 8 lines
devtools/libabigail.abignore +0 -2
@@ -13,8 +13,6 @@
         name_regexp = _pmd_info$
 
 ; Explicit ignore for driver-only ABI
-[suppress_type]
-        name = eth_dev_ops
 [suppress_function]
         name_regexp = rte_vdev_(|un)register
 

eth_dev_ops structure are not exported, so there is no symbol that is actually changing here. The type definition _only_ will be in DPDK 20.11 public headers, but is removed in DPDK 21.02.

I find it a little strange that libabigail is baulking when the type is changed (see 1fe3eef5e9b) but not when it is entirely removed?

Ray K