devtools: remove ethdev ABI exception
PATCH 1/1 devtools: remove ethdev ABI exception
Now that the ethernet driver dev_ops structure definition is not exported anymore, there is no need for an exception. abidiff will only consider structures defined in the installed headers (passed with --headers-dirX options).
--- devtools/libabigail.abignore | 2 -- 1 file changed, 2 deletions(-)
devtools/libabigail.abignore +0 -2
@@ -13,8 +13,6 @@ name_regexp = _pmd_info$ ; Explicit ignore for driver-only ABI -[suppress_type] - name = eth_dev_ops [suppress_function] name_regexp = rte_vdev_(|un)register
Signature · 1 line
2.23.0
Quoted 8 lines · David Marchand
Now that the ethernet driver
dev_opsstructure definition is not exported anymore, there is no need for an exception. abidiff will only consider structures defined in the installed headers (passed with --headers-dirX options).Fixes df96fd0d7395 ("ethdev: make driver-only headers private")Signed-off-by David Marchand <[email protected]>
Thomas Monjalon
Applied01/02/2021 20:03, Ferruh Yigit:
Quoted 11 lines · David Marchand
Quoted 8 lines
Now that the ethernet driver
dev_opsstructure definition is not exported anymore, there is no need for an exception. abidiff will only consider structures defined in the installed headers (passed with --headers-dirX options).Fixes df96fd0d7395 ("ethdev: make driver-only headers private")Signed-off-by David Marchand <[email protected]>Acked-by Ferruh Yigit <[email protected]>
Applied, thanks
Quoted 18 lines · David Marchand
Now that the ethernet driver
dev_opsstructure definition is not exported anymore, there is no need for an exception. abidiff will only consider structures defined in the installed headers (passed with --headers-dirX options).Fixes df96fd0d7395 ("ethdev: make driver-only headers private")Signed-off-by David Marchand <[email protected]>--- devtools/libabigail.abignore | 2 -- 1 file changed, 2 deletions(-)devtools/libabigail.abignore +0
-0
devtools/libabigail.abignore line 18
Quoted 8 lines
devtools/libabigail.abignore +0
-2@@ -13,8 +13,6 @@ name_regexp = _pmd_info$ ; Explicit ignore for driver-only ABI -[suppress_type] - name = eth_dev_ops [suppress_function] name_regexp = rte_vdev_(|un)register
Quoted 17 lines · David Marchand
Now that the ethernet driver
dev_opsstructure definition is not exported anymore, there is no need for an exception. abidiff will only consider structures defined in the installed headers (passed with --headers-dirX options).Fixes df96fd0d7395 ("ethdev: make driver-only headers private")Signed-off-by David Marchand <[email protected]>--- devtools/libabigail.abignore | 2 -- 1 file changed, 2 deletions(-)devtools/libabigail.abignore +0
-0
devtools/libabigail.abignore line 18
Quoted 8 lines
devtools/libabigail.abignore +0
-2@@ -13,8 +13,6 @@ name_regexp = _pmd_info$ ; Explicit ignore for driver-only ABI -[suppress_type] - name = eth_dev_ops [suppress_function] name_regexp = rte_vdev_(|un)register
eth_dev_ops structure are not exported, so there is no symbol that is actually changing here. The type definition _only_ will be in DPDK 20.11 public headers, but is removed in DPDK 21.02.
I find it a little strange that libabigail is baulking when the type is changed (see 1fe3eef5e9b) but not when it is entirely removed?
Ray K