Skip to contentSkip to conversation

x86: add function prototype to vm86.h

PATCH In review Harvey Harrison 3 participants 4 messages Feb 2, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 2/3 x86: add function prototype to vm86.h

Global functions should include their prototypes.

---
 include/asm-x86/vm86.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/asm-x86/vm86.h +1 -0
index a5edf51..b72b9a6 100644
@@ -195,6 +195,7 @@ struct kernel_vm86_struct {
 
 void handle_vm86_fault(struct kernel_vm86_regs *, long);
 int handle_vm86_trap(struct kernel_vm86_regs *, long, int);
+struct pt_regs * save_v86_state(struct kernel_vm86_regs *);
 
 struct task_struct;
 void release_vm86_irqs(struct task_struct *);
Signature · 1 line
1.5.4.rc4.1142.gf5a97
#1 lore raw
Quoted 12 lines · Harvey Harrison

Global functions should include their prototypes.

---
 include/asm-x86/vm86.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/asm-x86/vm86.h +0 -0
index a5edf51..b72b9a6 100644

include/asm-x86/vm86.h struct kernel_vm86_struct { · line 199

Quoted 5 lines
include/asm-x86/vm86.h +1 -0
@@ -195,6 +195,7 @@ struct kernel_vm86_struct {
 
 void handle_vm86_fault(struct kernel_vm86_regs *, long);
 int handle_vm86_trap(struct kernel_vm86_regs *, long, int);
+struct pt_regs * save_v86_state(struct kernel_vm86_regs *);
 

This fixes a sparse warning, but contribute to a coding style error. checkpatch.pl complains about this patch.

so the above line should be:

	struct pt_regs *save_v86_state(struct kernel_vm86_regs *);
Quoted 2 lines
include/asm-x86/vm86.h +0 -0
 struct task_struct;
 void release_vm86_irqs(struct task_struct *);
#2 lore raw
Quoted 14 lines · Li Zefan
Quoted 13 lines · Harvey Harrison

Global functions should include their prototypes.

---
 include/asm-x86/vm86.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/asm-x86/vm86.h +0 -0
index a5edf51..b72b9a6 100644
@@ -195,6 +195,7 @@ struct kernel_vm86_struct {
 
Quoted 7 lines

include/asm-x86/vm86.h struct kernel_vm86_struct { · line 199

Quoted 4 lines
include/asm-x86/vm86.h +1 -0
 void handle_vm86_fault(struct kernel_vm86_regs *, long);
 int handle_vm86_trap(struct kernel_vm86_regs *, long, int);
+struct pt_regs * save_v86_state(struct kernel_vm86_regs *);
 

This fixes a sparse warning, but contribute to a coding style error. checkpatch.pl complains about this patch.

Bugger, thought I caught that. Hopefully Ingo will delete the extra space when applying, otherwise I'll send a replacement.

My apologies,

Harvey

#3 lore raw
In reply to Harvey Harrison
Quoted 1 line · Harvey Harrison

Global functions should include their prototypes.

thanks, i've applied all three cleanup patches of yours.

one minor detail:

Quoted 1 line

+struct pt_regs * save_v86_state(struct kernel_vm86_regs *);

the proper form is:

   struct pt_regs *save_v86_state(struct kernel_vm86_regs *);

(note the lack of space)

Ingo