x86: add function prototype to vm86.h
PATCH 2/3 x86: add function prototype to vm86.h
Global functions should include their prototypes.
--- include/asm-x86/vm86.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
include/asm-x86/vm86.h +1 -0
@@ -195,6 +195,7 @@ struct kernel_vm86_struct {void handle_vm86_fault (struct kernel_vm86_regs *,long );int handle_vm86_trap (struct kernel_vm86_regs *,long ,int ); +struct pt_regs *save_v86_state (struct kernel_vm86_regs *);struct task_struct ;void release_vm86_irqs (struct task_struct *);
Signature · 1 line
1.5.4.rc4.1142.gf5a97
Quoted 12 lines · Harvey Harrison
Global functions should include their prototypes.
Signed-off-by Harvey Harrison <[email protected]>--- include/asm-x86/vm86.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)include/asm-x86/vm86.h +0
-0
include/asm-x86/vm86.h struct kernel_vm86_struct { · line 199
Quoted 5 lines
include/asm-x86/vm86.h +1
-0@@ -195,6 +195,7 @@ struct kernel_vm86_struct {void handle_vm86_fault (struct kernel_vm86_regs *,long );int handle_vm86_trap (struct kernel_vm86_regs *,long ,int ); +struct pt_regs *save_v86_state (struct kernel_vm86_regs *);
This fixes a sparse warning, but contribute to a coding style error. checkpatch.pl complains about this patch.
so the above line should be:
struct pt_regs *save_v86_state(struct kernel_vm86_regs *);
Quoted 2 lines
include/asm-x86/vm86.h +0
-0struct task_struct ;void release_vm86_irqs (struct task_struct *);
Quoted 14 lines · Li Zefan
Quoted 13 lines · Harvey Harrison
Global functions should include their prototypes.
Signed-off-by Harvey Harrison <[email protected]>--- include/asm-x86/vm86.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)include/asm-x86/vm86.h +0
-0@@ -195,6 +195,7 @@ struct kernel_vm86_struct {
Quoted 7 lines
include/asm-x86/vm86.h struct kernel_vm86_struct { · line 199
Quoted 4 lines
include/asm-x86/vm86.h +1
-0void handle_vm86_fault (struct kernel_vm86_regs *,long );int handle_vm86_trap (struct kernel_vm86_regs *,long ,int ); +struct pt_regs *save_v86_state (struct kernel_vm86_regs *);This fixes a sparse warning, but contribute to a coding style error. checkpatch.pl complains about this patch.
Bugger, thought I caught that. Hopefully Ingo will delete the extra space when applying, otherwise I'll send a replacement.
My apologies,
Harvey
Quoted 1 line · Harvey Harrison
Global functions should include their prototypes.
thanks, i've applied all three cleanup patches of yours.
one minor detail:
Quoted 1 line
+struct
pt_regs*save_v86_state(struct kernel_vm86_regs *);
the proper form is:
struct pt_regs *save_v86_state(struct kernel_vm86_regs *);
(note the lack of space)
Ingo