Skip to contentSkip to conversation

arm64: dts: n5x: add sdr edac support

PATCH In review Dinh Nguyen 2 participants 3 messages Mar 1, 2022 – Mar 22, 2022 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: n5x: add sdr edac support

The N5X platform has the Synopsys DDR controller the includes an EDAC controller. Add the entry for the controller in the DTS file instead of the base Agilex DTSI because the base Agilex does not have the controller.

---
 arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts +10 -0
index f3c1310dae0a..628c9943914b 100644
@@ -23,6 +23,16 @@ memory {
 		/* We expect the bootloader to fill in the reg */
 		reg = <0 0 0 0>;
 	};
+
+	soc {
+		sdram_edac: sdr_edac@f87f8000 {
+			compatible = "snps,ddrc-3.80a";
+			reg = <0xf87f8000 0x400>;
+			interrupts = <0 175 4>;
+			intel,sysmgr-syscon = <&sysmgr 0xb8>;
+			status = "okay";
+		};
+	};
 };
 
 &clkmgr {
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 15 lines · Dinh Nguyen

The N5X platform has the Synopsys DDR controller the includes an EDAC controller. Add the entry for the controller in the DTS file instead of the base Agilex DTSI because the base Agilex does not have the controller.

---
 arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts +0 -0
index f3c1310dae0a..628c9943914b 100644

arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts memory { · line 28

Quoted 6 lines
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts +3 -0
@@ -23,6 +23,16 @@ memory {
 		/* We expect the bootloader to fill in the reg */
 		reg = <0 0 0 0>;
 	};
+
+	soc {
+		sdram_edac: sdr_edac@f87f8000 {

This patch was merged but it is not correct. The node name should be memory-controller (generic, not specific).

arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts memory { · line 31

Quoted 3 lines
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts +3 -0
+			compatible = "snps,ddrc-3.80a";
+			reg = <0xf87f8000 0x400>;
+			interrupts = <0 175 4>;

This fails dt schema.

arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts memory { · line 32

Quoted 1 line
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts +1 -0
+			intel,sysmgr-syscon = <&sysmgr 0xb8>;

This fails schema even more... it's not documented.

arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts memory { · line 33

Quoted 1 line
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts +1 -0
+			status = "okay";

This is not needed.

Please test your changes against bindings (you can use dtbs_check).

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 36 lines · Krzysztof Kozlowski
Quoted 15 lines · Dinh Nguyen

The N5X platform has the Synopsys DDR controller the includes an EDAC controller. Add the entry for the controller in the DTS file instead of the base Agilex DTSI because the base Agilex does not have the controller.

---
  arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 10 ++++++++++
  1 file changed, 10 insertions(+)
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts +0 -0
index f3c1310dae0a..628c9943914b 100644

arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts memory { · line 28

Quoted 6 lines
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts +3 -0
@@ -23,6 +23,16 @@ memory {
  		/* We expect the bootloader to fill in the reg */
  		reg = <0 0 0 0>;
  	};
+
+	soc {
+		sdram_edac: sdr_edac@f87f8000 {

This patch was merged but it is not correct. The node name should be memory-controller (generic, not specific).

arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts memory { · line 31

Quoted 3 lines
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts +3 -0
+			compatible = "snps,ddrc-3.80a";
+			reg = <0xf87f8000 0x400>;
+			interrupts = <0 175 4>;

This fails dt schema.

arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts memory { · line 32

Quoted 1 line
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts +1 -0
+			intel,sysmgr-syscon = <&sysmgr 0xb8>;

This fails schema even more... it's not documented.

Quoted 7 lines

arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts memory { · line 33

Quoted 1 line
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts +1 -0
+			status = "okay";

This is not needed.

Please test your changes against bindings (you can use dtbs_check).

Will do and I'll send a patch to fix this up in a bit.

Thanks,
Dinh

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel