nfs: BUG_ON in nfs_follow_mountpoint (Trond's comment fixed)
PATCH 1/1 nfs: BUG_ON in nfs_follow_mountpoint (Trond's comment fixed)
From: "Denis V. Lunev" <[email protected]>
Unfortunately, BUG_ON(IS_ROOT(dentry)) can happen inside nfs_follow_mountpoint with NFS running Fedora 8 using a specific setup.
See https://bugzilla.redhat.com/show_bug.cgi?id=458622
So the situation should be handled on NFS client gracefully.
Signed-off-by Denis V. Lunev <[email protected]>
Cc Trond Myklebust <[email protected]>
Cc J. Bruce Fields <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
fs/nfs/namespace.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
fs/nfs/namespace.c renamed from fs/nfs/namespace.c~nfs-bug_on-in-nfs_follow_mountpoint +4 -1
@@ -105,7 +105,10 @@ static void * nfs_follow_mountpoint(strudprintk ("--> nfs_follow_mountpoint()\n" ); -BUG_ON (IS_ROOT (dentry)); + err = -EIO ; +if (IS_ROOT (dentry)) + goto out_err; +dprintk ("%s: enter\n" , __func__);dput (nd->path.dentry); nd->path.dentry =dget (dentry);
_