Skip to contentSkip to conversation

nfs: BUG_ON in nfs_follow_mountpoint (Trond's comment fixed)

PATCH New Denis V. Lunev 1 participant 1 message Aug 21, 2008 NFS client

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfs: BUG_ON in nfs_follow_mountpoint (Trond's comment fixed)

From: "Denis V. Lunev" <[email protected]>

Unfortunately, BUG_ON(IS_ROOT(dentry)) can happen inside nfs_follow_mountpoint with NFS running Fedora 8 using a specific setup.

See https://bugzilla.redhat.com/show_bug.cgi?id=458622

So the situation should be handled on NFS client gracefully.

Cc Trond Myklebust <[email protected]>
Cc J. Bruce Fields <[email protected]>

---

 fs/nfs/namespace.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
fs/nfs/namespace.c renamed from fs/nfs/namespace.c~nfs-bug_on-in-nfs_follow_mountpoint +4 -1
diff -puN fs/nfs/namespace.c~nfs-bug_on-in-nfs_follow_mountpoint fs/nfs/namespace.c
@@ -105,7 +105,10 @@ static void * nfs_follow_mountpoint(stru
 
 	dprintk("--> nfs_follow_mountpoint()\n");
 
-	BUG_ON(IS_ROOT(dentry));
+	err = -EIO;
+	if (IS_ROOT(dentry))
+		goto out_err;
+
 	dprintk("%s: enter\n", __func__);
 	dput(nd->path.dentry);
 	nd->path.dentry = dget(dentry);

_