Skip to contentSkip to conversation

ASoC Blackfin: add asoc ad73311 driver supporting in Blackfin boards

PATCH In review Bryan Wu 2 participants 3 messages Sep 27, 2008

Subsystems (2)
lore
Share & tools
lore

Bryan Wu

author
#0 lore raw

PATCH 1/1 ASoC Blackfin: add asoc ad73311 driver supporting in Blackfin boards

From: Cliff Cai <[email protected]>

---
 sound/soc/blackfin/Kconfig         |   16 +++
 sound/soc/blackfin/Makefile        |    3 +-
 sound/soc/blackfin/bf5xx-ad73311.c |  240 ++++++++++++++++++++++++++++++++++++
 sound/soc/blackfin/bf5xx-i2s.c     |   52 ++++++--
 4 files changed, 296 insertions(+), 15 deletions(-)
 create mode 100644 sound/soc/blackfin/bf5xx-ad73311.c
sound/soc/blackfin/Kconfig +16 -0
index f98331d..dc00620 100644
@@ -17,6 +17,22 @@ config SND_BF5XX_SOC_SSM2602
 	help
 	  Say Y if you want to add support for SoC audio on BF527-EZKIT.
 
+config SND_BF5XX_SOC_AD73311
+	tristate "SoC AD73311 Audio support for Blackfin"
+	depends on SND_BF5XX_I2S
+	select SND_BF5XX_SOC_I2S
+	select SND_SOC_AD73311
+	help
+	  Say Y if you want to add support for AD73311 codec on Blackfin.
+
+config SND_BFIN_AD73311_SE
+	int "PF pin for AD73311L Chip Select"
+	depends on SND_BF5XX_SOC_AD73311
+	default 4
+	help
+	  Enter the GPIO used to control AD73311's SE pin. Acceptable
+	  values are 0 to 7
+
 config SND_BF5XX_AC97
 	tristate "SoC AC97 Audio for the ADI BF5xx chip"
 	depends on BLACKFIN && SND_SOC
sound/soc/blackfin/Makefile +2 -1
index 9ea8bd9..97bb37a 100644
@@ -14,7 +14,8 @@ obj-$(CONFIG_SND_BF5XX_SOC_I2S) += snd-soc-bf5xx-i2s.o
 # Blackfin Machine Support
 snd-ad1980-objs := bf5xx-ad1980.o
 snd-ssm2602-objs := bf5xx-ssm2602.o
-
+snd-ad73311-objs := bf5xx-ad73311.o
 
 obj-$(CONFIG_SND_BF5XX_SOC_AD1980) += snd-ad1980.o
 obj-$(CONFIG_SND_BF5XX_SOC_SSM2602) += snd-ssm2602.o
+obj-$(CONFIG_SND_BF5XX_SOC_AD73311) += snd-ad73311.o
sound/soc/blackfin/bf5xx-ad73311.c new file +240 -0

240 lines not on this page · raw message

sound/soc/blackfin/bf5xx-i2s.c +38 -14

121 lines not on this page · raw message

Signature · 1 line
1.5.6
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Bryan Wu

From: Cliff Cai <[email protected]>

Looks good - one thing that might help people reading the changelogs for features might be to split out the I2S changes from the machine driver. As well as supporting the AD73311 machines this also makes the I2S driver more flexible which is a much more general feature and would be more clearly highlighted with a separate changelog entry.

Thanks for the patches!

author
#2 lore raw
Quoted 6 lines · Mark Brown
Quoted 4 lines · Bryan Wu

From: Cliff Cai <[email protected]>

Quoted 8 lines

Looks good - one thing that might help people reading the changelogs for features might be to split out the I2S changes from the machine driver. As well as supporting the AD73311 machines this also makes the I2S driver more flexible which is a much more general feature and would be more clearly highlighted with a separate changelog entry.

No problem, I will split out the I2S changes here.

-Bryan