Skip to contentSkip to conversation

istallion: add missing __devexit marking

PATCH In review Mike Frysinger 2 participants 2 messages May 18, 2009 – May 19, 2009 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 istallion: add missing __devexit marking

The remove member of the pci_driver stli_pcidriver uses __devexit_p(), so the remove function itself should be marked with __devexit. Even more so considering the probe function is marked with __devinit.

---
 drivers/char/istallion.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/istallion.c +1 -1
index fff19f7..e8392c2 100644
@@ -3785,7 +3785,7 @@ err:
 	return retval;
 }
 
-static void stli_pciremove(struct pci_dev *pdev)
+static void __devexit stli_pciremove(struct pci_dev *pdev)
 {
 	struct stlibrd *brdp = pci_get_drvdata(pdev);
 
Signature · 1 line
1.6.3
Acked-by on v1 1/1
#1 lore raw

Hi Mike,

Quoted 6 lines · Mike Frysinger

The remove member of the pci_driver stli_pcidriver uses __devexit_p(), so the remove function itself should be marked with __devexit. Even more so considering the probe function is marked with __devinit.

Looks ok to me:

Quoted 17 lines
---
 drivers/char/istallion.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/istallion.c +1 -1
index fff19f7..e8392c2 100644
@@ -3785,7 +3785,7 @@ err:
 	return retval;
 }
 
-static void stli_pciremove(struct pci_dev *pdev)
+static void __devexit stli_pciremove(struct pci_dev *pdev)
 {
 	struct stlibrd *brdp = pci_get_drvdata(pdev);
 
Signature · 5 lines
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     [email protected]
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com