istallion: add missing __devexit marking
PATCH 1/1 istallion: add missing __devexit marking
The remove member of the pci_driver stli_pcidriver uses __devexit_p(), so the remove function itself should be marked with __devexit. Even more so considering the probe function is marked with __devinit.
Signed-off-by Mike Frysinger <[email protected]>
CC Greg Ungerer <[email protected]>
--- drivers/char/istallion.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/istallion.c +1 -1
@@ -3785,7 +3785,7 @@ err:return retval; } -static void stli_pciremove (struct pci_dev *pdev) +static void __devexit stli_pciremove(struct pci_dev *pdev) {struct stlibrd *brdp =pci_get_drvdata (pdev);
Signature · 1 line
1.6.3
Hi Mike,
Quoted 6 lines · Mike Frysinger
The remove member of the
pci_driverstli_pcidriveruses__devexit_p(), so the remove function itself should be marked with__devexit. Even more so considering the probe function is marked with__devinit.Signed-off-by Mike Frysinger <[email protected]>CC Greg Ungerer <[email protected]>
Looks ok to me:
Acked-by Greg Ungerer <[email protected]>
Quoted 17 lines
--- drivers/char/istallion.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/char/istallion.c +1
-1@@ -3785,7 +3785,7 @@ err:return retval; } -static void stli_pciremove (struct pci_dev *pdev) +static void __devexit stli_pciremove(struct pci_dev *pdev) {struct stlibrd *brdp =pci_get_drvdata (pdev);
Signature · 5 lines
------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: [email protected] SnapGear Group, McAfee PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com