Skip to contentSkip to conversation

OMAP3:DDR timing cleanup series

PATCH New Nishanth Menon 4 participants 13 messages Oct 21, 2009 – Nov 12, 2009 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): OMAP3 DDR Fix patches (was Re: [U-Boot] [PATCH 1/5 v2] OMAP3: Fix SDRC init)

A message that is not in the archive (sent off-list or not yet received): OMAP3 DDR Fix patches (was Re: [U-Boot] [PATCH 1/5 v2] OMAP3: Fix SDRC init)

#2 lore raw

cover OMAP3:DDR timing cleanup series

Hi,
in continuation of the discussion on:
http://www.nabble.com/forum/Permalink.jtp?root=25779518&post=25959734&page=y

the following patch set should introduce DDR timing changes for MICRON and INFINEON DDRs and allow both classes of boards to live happily together

Tested ON:
SDP3430 - type INFENINION
BeagleBoard - type MICRON

	tested with mtest 0x82000000 0x83000000 1
	from u-boot prompt

Nishanth Menon (2):
OMAP3:SDRC: Cleanup references to SDP OMAP3:SDRC: introduce DDR types

 cpu/arm_cortexa8/omap3/mem.c      |    2 +-
 cpu/arm_cortexa8/omap3/sys_info.c |    2 +-
 include/asm-arm/arch-omap3/mem.h  |   97 +++++++++++++++++++++++++++----------
 include/configs/devkit8000.h      |    3 +
 include/configs/omap3_beagle.h    |    3 +
 include/configs/omap3_evm.h       |    3 +
 include/configs/omap3_overo.h     |    3 +
 include/configs/omap3_pandora.h   |    3 +
 include/configs/omap3_sdp3430.h   |    3 +
 include/configs/omap3_zoom1.h     |    3 +
 include/configs/omap3_zoom2.h     |    3 +
 11 files changed, 97 insertions(+), 28 deletions(-)
#3 lore raw

PATCH 1/2 OMAP3:SDRC: Cleanup references to SDP

Remove SDP referenced unused defines

---
 cpu/arm_cortexa8/omap3/mem.c      |    2 +-
 cpu/arm_cortexa8/omap3/sys_info.c |    2 +-
 include/asm-arm/arch-omap3/mem.h  |   11 ++---------
 3 files changed, 4 insertions(+), 11 deletions(-)
cpu/arm_cortexa8/omap3/mem.c +1 -1
index 5e6d542..dfb7e4c 100644
@@ -161,7 +161,7 @@ void do_sdrc_init(u32 cs, u32 early)
 		writel(0, &sdrc_base->sysconfig);
 
 		/* setup sdrc to ball mux */
-		writel(SDP_SDRC_SHARING, &sdrc_base->sharing);
+		writel(SDRC_SHARING, &sdrc_base->sharing);
 
 		/* Disable Power Down of CKE cuz of 1 CKE on combo part */
 		writel(WAKEUPPROC | PWDNEN | SRFRONRESET | PAGEPOLICY_HIGH,
cpu/arm_cortexa8/omap3/sys_info.c +1 -1
index 31b2003..08fb32e 100644
@@ -109,7 +109,7 @@ u32 get_cpu_rev(void)
  ****************************************************/
 u32 is_mem_sdr(void)
 {
-	if (readl(&sdrc_base->cs[CS0].mr) == SDP_SDRC_MR_0_SDR)
+	if (readl(&sdrc_base->cs[CS0].mr) == SDRC_MR_0_SDR)
 		return 1;
 	return 0;
 }
include/asm-arm/arch-omap3/mem.h +2 -9
index 31cbdef..3ef8478 100644
@@ -40,11 +40,8 @@ enum {
 #define EARLY_INIT	1
 
 /* Slower full frequency range default timings for x32 operation*/
-#define SDP_SDRC_SHARING	0x00000100
-#define SDP_SDRC_MR_0_SDR	0x00000031
-
-/* optimized timings good for current shipping parts */
-#define SDP_3430_SDRC_RFR_CTRL_165MHz	0x0004e201 /* 7.8us/6ns - 50=0x4e2 */
+#define SDRC_SHARING	0x00000100
+#define SDRC_MR_0_SDR	0x00000031
 
 #define DLL_OFFSET		0
 #define DLL_WRITEDDRCLKX2DIS	1
@@ -91,10 +88,6 @@ enum {
 #define V_ACTIMB_165	(((TCKE_165 << 12) | (XSR_165 << 0)) |	\
 			(TXP_165 << 8) | (TWTR_165 << 16))
 
-#define SDP_SDRC_ACTIM_CTRLA_0	V_ACTIMA_165
-#define SDP_SDRC_ACTIM_CTRLB_0	V_ACTIMB_165
-#define SDP_SDRC_RFR_CTRL	SDP_3430_SDRC_RFR_CTRL_165MHz
-
 /*
  * GPMC settings -
  * Definitions is as per the following format
Signature · 1 line
1.6.3.3
#4 lore raw

PATCH 2/2 OMAP3:SDRC: introduce DDR types

Micron DDR timings based on:
http://www.sakoman.net/cgi-bin/gitweb.cgi?p=x-load-omap3.git;a=blob;f=include/asm/arch-omap3/mem.h;h=e6fbfe3947f5d0d85fea776e30821d4017316d86;hb=HEAD

Introduce Micron DDR timings and provide CONFIG_OMAP3_INFINEON_DDR and CONFIG_OMAP3_MICRON_DDR config options to allow for platform files to setup their timings as per the type of DDR selected

---
 include/asm-arm/arch-omap3/mem.h |   88 ++++++++++++++++++++++++++++++--------
 include/configs/devkit8000.h     |    3 +
 include/configs/omap3_beagle.h   |    3 +
 include/configs/omap3_evm.h      |    3 +
 include/configs/omap3_overo.h    |    3 +
 include/configs/omap3_pandora.h  |    3 +
 include/configs/omap3_sdp3430.h  |    3 +
 include/configs/omap3_zoom1.h    |    3 +
 include/configs/omap3_zoom2.h    |    3 +
 9 files changed, 94 insertions(+), 18 deletions(-)
include/asm-arm/arch-omap3/mem.h +71 -19
index 3ef8478..ae06a14 100644
@@ -68,26 +68,78 @@ enum {
  *	TCKE = 2
  *	XSR = 120/6 = 20
  */
-#define TDAL_165	6
-#define TDPL_165	3
-#define TRRD_165	2
-#define TRCD_165	3
-#define TRP_165		3
-#define TRAS_165	7
-#define TRC_165		10
-#define TRFC_165	12
-#define V_ACTIMA_165	((TRFC_165 << 27) | (TRC_165 << 22) | \
-			(TRAS_165 << 18) | (TRP_165 << 15) |  \
-			(TRCD_165 << 12) | (TRRD_165 << 9) |  \
-			(TDPL_165 << 6) | (TDAL_165))
-
-#define TWTR_165	1
-#define TCKE_165	2
-#define TXP_165		2
-#define XSR_165		20
-#define V_ACTIMB_165	(((TCKE_165 << 12) | (XSR_165 << 0)) |	\
-			(TXP_165 << 8) | (TWTR_165 << 16))
+#define INFINEON_TDAL_165	6
+#define INFINEON_TDPL_165	3
+#define INFINEON_TRRD_165	2
+#define INFINEON_TRCD_165	3
+#define INFINEON_TRP_165	3
+#define INFINEON_TRAS_165	7
+#define INFINEON_TRC_165	10
+#define INFINEON_TRFC_165	12
+#define INFINEON_V_ACTIMA_165	((INFINEON_TRFC_165 << 27) |		\
+		(INFINEON_TRC_165 << 22) | (INFINEON_TRAS_165 << 18) |	\
+		(INFINEON_TRP_165 << 15) | (INFINEON_TRCD_165 << 12) |	\
+		(INFINEON_TRRD_165 << 9) | (INFINEON_TDPL_165 << 6) |	\
+		(INFINEON_TDAL_165))
 
+#define INFINEON_TWTR_165	1
+#define INFINEON_TCKE_165	2
+#define INFINEON_TXP_165	2
+#define INFINEON_XSR_165	20
+#define INFINEON_V_ACTIMB_165	((INFINEON_TCKE_165 << 12) |		\
+		(INFINEON_XSR_165 << 0) | (INFINEON_TXP_165 << 8) |	\
+		(INFINEON_TWTR_165 << 16))
+
+/* Micron part of 3430 EVM (165MHz optimized) 6.06ns
+ * ACTIMA
+ *	TDAL = Twr/Tck + Trp/tck= 15/6 + 18 /6 = 2.5 + 3 = 5.5 -> 6
+ *	TDPL (Twr)	= 15/6	= 2.5 -> 3
+ *	TRRD		= 12/6	= 2
+ *	TRCD		= 18/6	= 3
+ *	TRP		= 18/6	= 3
+ *	TRAS		= 42/6	= 7
+ *	TRC		= 60/6	= 10
+ *	TRFC		= 125/6	= 21
+ * ACTIMB
+ *	TWTR		= 1
+ *	TCKE		= 1
+ *	TXSR		= 138/6	= 23
+ *	TXP		= 25/6	= 4.1 ~5
+ */
+#define MICRON_TDAL_165		6
+#define MICRON_TDPL_165		3
+#define MICRON_TRRD_165		2
+#define MICRON_TRCD_165		3
+#define MICRON_TRP_165		3
+#define MICRON_TRAS_165		7
+#define MICRON_TRC_165		10
+#define MICRON_TRFC_165		21
+#define MICRON_V_ACTIMA_165 ((MICRON_TRFC_165 << 27) |			\
+		(MICRON_TRC_165 << 22) | (MICRON_TRAS_165 << 18) |	\
+		(MICRON_TRP_165 << 15) | (MICRON_TRCD_165 << 12) |	\
+		(MICRON_TRRD_165 << 9) | (MICRON_TDPL_165 << 6) |	\
+		(MICRON_TDAL_165))
+
+#define MICRON_TWTR_165		1
+#define MICRON_TCKE_165		1
+#define MICRON_XSR_165		23
+#define MICRON_TXP_165		5
+#define MICRON_V_ACTIMB_165 ((MICRON_TCKE_165 << 12) |			\
+		(MICRON_XSR_165 << 0) | (MICRON_TXP_165 << 8) |	\
+		(MICRON_TWTR_165 << 16))
+
+#ifdef CONFIG_OMAP3_INFINEON_DDR
+#define V_ACTIMA_165 INFINEON_V_ACTIMA_165
+#define V_ACTIMB_165 INFINEON_V_ACTIMB_165
+#endif
+#ifdef CONFIG_OMAP3_MICRON_DDR
+#define V_ACTIMA_165 MICRON_V_ACTIMA_165
+#define V_ACTIMB_165 MICRON_V_ACTIMB_165
+#endif
+
+#if !defined(V_ACTIMA_165) || !defined(V_ACTIMB_165)
+#error "Please choose the right DDR type in config header"
+#endif
 /*
  * GPMC settings -
  * Definitions is as per the following format
include/configs/devkit8000.h +3 -0
index bd5037e..1011770 100644
@@ -66,6 +66,9 @@
 
 /* Hardware drivers */
 
+/* DDR - I use Micron DDR */
+#define CONFIG_OMAP3_MICRON_DDR		1
+
 /* DM9000 */
 #define CONFIG_NET_MULTI		1
 #define CONFIG_NET_RETRY_COUNT		20
include/configs/omap3_beagle.h +3 -0
index 19a5ec9..024b9b8 100644
@@ -97,6 +97,9 @@
 #define CONFIG_OMAP3_MMC		1
 #define CONFIG_DOS_PARTITION		1
 
+/* DDR - I use Micron DDR */
+#define CONFIG_OMAP3_MICRON_DDR		1
+
 /* commands to include */
 #include <config_cmd_default.h>
 
include/configs/omap3_evm.h +3 -0
index a5514ae..6709edc 100644
@@ -101,6 +101,9 @@
 #define CONFIG_OMAP3_MMC		1
 #define CONFIG_DOS_PARTITION		1
 
+/* DDR - I use Micron DDR */
+#define CONFIG_OMAP3_MICRON_DDR		1
+
 /* commands to include */
 #include <config_cmd_default.h>
 
include/configs/omap3_overo.h +3 -0
index ffb515d..0f812a7 100644
@@ -89,6 +89,9 @@
 #define CONFIG_OMAP3_MMC		1
 #define CONFIG_DOS_PARTITION		1
 
+/* DDR - I use Micron DDR */
+#define CONFIG_OMAP3_MICRON_DDR		1
+
 /* commands to include */
 #include <config_cmd_default.h>
 
include/configs/omap3_pandora.h +3 -0
index 6f21af3..0cafeb8 100644
@@ -92,6 +92,9 @@
 #define CONFIG_OMAP3_MMC		1
 #define CONFIG_DOS_PARTITION		1
 
+/* DDR - I use Micron DDR */
+#define CONFIG_OMAP3_MICRON_DDR		1
+
 /* commands to include */
 #include <config_cmd_default.h>
 
include/configs/omap3_sdp3430.h +3 -0
index 229dc5e..d91c8ff 100644
@@ -137,6 +137,9 @@
 #define CONFIG_SYS_I2C_BUS_SELECT	1
 #define CONFIG_DRIVER_OMAP34XX_I2C	1
 
+/* DDR - I use Infineon DDR */
+#define CONFIG_OMAP3_INFINEON_DDR	1
+
 /* OMITTED:  single 1 Gbit MT29F1G NAND flash */
 
 /*
include/configs/omap3_zoom1.h +3 -0
index da4b677..2aef973 100644
@@ -98,6 +98,9 @@
 #define CONFIG_OMAP3_MMC		1
 #define CONFIG_DOS_PARTITION		1
 
+/* DDR - I use Micron DDR */
+#define CONFIG_OMAP3_MICRON_DDR		1
+
 /* commands to include */
 #include <config_cmd_default.h>
 
include/configs/omap3_zoom2.h +3 -0
index 32cd6fd..5b03fb6 100644
@@ -98,6 +98,9 @@
 #define CONFIG_OMAP3_MMC		1
 #define CONFIG_DOS_PARTITION		1
 
+/* DDR - I use Micron DDR */
+#define CONFIG_OMAP3_MICRON_DDR		1
+
 /* Status LED */
 #define CONFIG_STATUS_LED		1 /* Status LED enabled	*/
 #define CONFIG_BOARD_SPECIFIC_LED	1
Signature · 1 line
1.6.3.3
#5 lore raw

PATCH 2/2 OMAP3:SDRC: introduce DDR types

Quoted 16 lines

Micron DDR timings based on:
http://www.sakoman.net/cgi-bin/gitweb.cgi?p=x-load-
omap3.git;a=blob;f=include/asm/arch- omap3/mem.h;h=e6fbfe3947f5d0d85fea776e30821d4017316d86;hb=HEAD

Introduce Micron DDR timings and provide CONFIG_OMAP3_INFINEON_DDR and CONFIG_OMAP3_MICRON_DDR config options to allow for platform files to setup their timings as per the type of DDR selected

Reported-by: Steve Sakoman in
http://www.nabble.com/forum/Permalink.jtp?root=25779518&post=25959734&page
=y

Quoted 13 lines
---
 include/asm-arm/arch-omap3/mem.h |   88 ++++++++++++++++++++++++++++++---
-----
 include/configs/devkit8000.h     |    3 +
 include/configs/omap3_beagle.h   |    3 +
 include/configs/omap3_evm.h      |    3 +
 include/configs/omap3_overo.h    |    3 +
 include/configs/omap3_pandora.h  |    3 +
 include/configs/omap3_sdp3430.h  |    3 +
 include/configs/omap3_zoom1.h    |    3 +
 include/configs/omap3_zoom2.h    |    3 +
 9 files changed, 94 insertions(+), 18 deletions(-)

Pushed to u-boot-ti/next

I think this series from Nishanth needs some runtime tests.
I believe Steve had some issues with his EVM not booting everytime due to issues with DDR init.

Thanks,
Sandeep

#6 lore raw

PATCH 2/2 OMAP3:SDRC: introduce DDR types

Quoted 29 lines · Sandeep
Quoted 15 lines

Micron DDR timings based on:
http://www.sakoman.net/cgi-bin/gitweb.cgi?p=x-load-
omap3.git;a=blob;f=include/asm/arch- omap3/mem.h;h=e6fbfe3947f5d0d85fea776e30821d4017316d86;hb=HEAD

Introduce Micron DDR timings and provide CONFIG_OMAP3_INFINEON_DDR and CONFIG_OMAP3_MICRON_DDR config options to allow for platform files to setup their timings as per the type of DDR selected

Reported-by: Steve Sakoman in
http://www.nabble.com/forum/Permalink.jtp?root=25779518&post=25959734&page
=y

Quoted 13 lines
---
 include/asm-arm/arch-omap3/mem.h |   88 ++++++++++++++++++++++++++++++---
-----
 include/configs/devkit8000.h     |    3 +
 include/configs/omap3_beagle.h   |    3 +
 include/configs/omap3_evm.h      |    3 +
 include/configs/omap3_overo.h    |    3 +
 include/configs/omap3_pandora.h  |    3 +
 include/configs/omap3_sdp3430.h  |    3 +
 include/configs/omap3_zoom1.h    |    3 +
 include/configs/omap3_zoom2.h    |    3 +
 9 files changed, 94 insertions(+), 18 deletions(-)
Quoted 7 lines

Pushed to u-boot-ti/next

I think this series from Nishanth needs some runtime tests.
I believe Steve had some issues with his EVM not booting everytime due to issues with DDR init.

Thanks,
Sandeep

Maybe it should go on the testing branch?

I will give zoom2 a try..

Tom

#7 lore raw

PATCH 2/2 OMAP3:SDRC: introduce DDR types

Quoted 34 lines
Quoted 9 lines
Quoted 9 lines

Introduce Micron DDR timings and provide CONFIG_OMAP3_INFINEON_DDR and CONFIG_OMAP3_MICRON_DDR config options to allow for platform files to setup their timings as per the type of DDR selected

Reported-by Steve Sakoman in

http://www.nabble.com/forum/Permalink.jtp?root=25779518&post=25959734&page

Quoted 5 lines
Quoted 5 lines

=y

---
 include/asm-arm/arch-omap3/mem.h |   88

++++++++++++++++++++++++++++++---

Quoted 12 lines
Quoted 11 lines

-----

 include/configs/devkit8000.h     |    3 +
 include/configs/omap3_beagle.h   |    3 +
 include/configs/omap3_evm.h      |    3 +
 include/configs/omap3_overo.h    |    3 +
 include/configs/omap3_pandora.h  |    3 +
 include/configs/omap3_sdp3430.h  |    3 +
 include/configs/omap3_zoom1.h    |    3 +
 include/configs/omap3_zoom2.h    |    3 +
 9 files changed, 94 insertions(+), 18 deletions(-)
Quoted 4 lines

Pushed to u-boot-ti/next

I think this series from Nishanth needs some runtime tests. I believe Steve had some issues with his EVM not booting everytime due

to issues with DDR init.

Quoted 1 line
Quoted 9 lines
Quoted 2 lines

Thanks,
Sandeep

Maybe it should go on the testing branch?

I will give zoom2 a try..

Tom

Nishanth has already tried on SDP 3430.
I think the board that needs to be tried is overo.

Sandeep

#8 lore raw

PATCH 2/2 OMAP3:SDRC: introduce DDR types

Quoted 37 lines · Sandeep
Quoted 37 lines
Quoted 9 lines
Quoted 9 lines

Introduce Micron DDR timings and provide CONFIG_OMAP3_INFINEON_DDR and CONFIG_OMAP3_MICRON_DDR config options to allow for platform files to setup their timings as per the type of DDR selected

Reported-by Steve Sakoman in

http://www.nabble.com/forum/Permalink.jtp?root=25779518&post=25959734&page

Quoted 5 lines
Quoted 5 lines

=y

---
?include/asm-arm/arch-omap3/mem.h | ? 88

++++++++++++++++++++++++++++++---

Quoted 12 lines
Quoted 11 lines

-----

?include/configs/devkit8000.h ? ? | ? ?3 +
?include/configs/omap3_beagle.h ? | ? ?3 +
?include/configs/omap3_evm.h ? ? ?| ? ?3 +
?include/configs/omap3_overo.h ? ?| ? ?3 +
?include/configs/omap3_pandora.h ?| ? ?3 +
?include/configs/omap3_sdp3430.h ?| ? ?3 +
?include/configs/omap3_zoom1.h ? ?| ? ?3 +
?include/configs/omap3_zoom2.h ? ?| ? ?3 +

?9 files changed, 94 insertions(+), 18 deletions(-)

Quoted 4 lines

Pushed to u-boot-ti/next

I think this series from Nishanth needs some runtime tests. I believe Steve had some issues with his EVM not booting everytime due

to issues with DDR init.

Quoted 3 lines

Thanks,
Sandeep

Quoted 8 lines
Quoted 6 lines

Maybe it should go on the testing branch?

I will give zoom2 a try..

Tom

Nishanth has already tried on SDP 3430.
I think the board that needs to be tried is overo.

Correct, it was Overo, though I suspect Beagle might have the same issue since they use the same Micron POP memory. I'll try to test this weekend.

Steve

#9 lore raw

PATCH 2/2 OMAP3:SDRC: introduce DDR types

Quoted 39 lines · Steve Sakoman
Quoted 38 lines · Sandeep
Quoted 38 lines
Quoted 7 lines
Quoted 7 lines

Introduce Micron DDR timings and provide CONFIG_OMAP3_INFINEON_DDR and CONFIG_OMAP3_MICRON_DDR config options to allow for platform files to setup their timings as per the type of DDR selected

Reported-by Steve Sakoman in

http://www.nabble.com/forum/Permalink.jtp?root=25779518&post=25959734&page

Quoted 5 lines
Quoted 5 lines

=y

---
 include/asm-arm/arch-omap3/mem.h |   88

++++++++++++++++++++++++++++++---

Quoted 11 lines
Quoted 11 lines

-----

 include/configs/devkit8000.h     |    3 +
 include/configs/omap3_beagle.h   |    3 +
 include/configs/omap3_evm.h      |    3 +
 include/configs/omap3_overo.h    |    3 +
 include/configs/omap3_pandora.h  |    3 +
 include/configs/omap3_sdp3430.h  |    3 +
 include/configs/omap3_zoom1.h    |    3 +
 include/configs/omap3_zoom2.h    |    3 +
 9 files changed, 94 insertions(+), 18 deletions(-)
Quoted 4 lines

Pushed to u-boot-ti/next

I think this series from Nishanth needs some runtime tests. I believe Steve had some issues with his EVM not booting everytime due

to issues with DDR init.

Quoted 2 lines

Thanks,
Sandeep

Maybe it should go on the testing branch?

I will give zoom2 a try..

Tom

Quoted 8 lines
Quoted 2 lines

Nishanth has already tried on SDP 3430.
I think the board that needs to be tried is overo.

Correct, it was Overo, though I suspect Beagle might have the same issue since they use the same Micron POP memory. I'll try to test this weekend.

Steve

I can try that too.

Did you see the problem on warm or cold booting?

Tom

#10 lore raw

PATCH 2/2 OMAP3:SDRC: introduce DDR types

Quoted 57 lines · Tom
Quoted 56 lines · Steve Sakoman
Quoted 40 lines · Sandeep
Quoted 40 lines
Quoted 8 lines
Quoted 8 lines

Introduce Micron DDR timings and provide CONFIG_OMAP3_INFINEON_DDR and CONFIG_OMAP3_MICRON_DDR config options to allow for platform files to setup their timings as per the type of DDR selected

Reported-by Steve Sakoman in

http://www.nabble.com/forum/Permalink.jtp?root=25779518&post=25959734&page

Quoted 6 lines
Quoted 6 lines

=y

---
?include/asm-arm/arch-omap3/mem.h | ? 88

++++++++++++++++++++++++++++++---

Quoted 12 lines
Quoted 10 lines

-----

?include/configs/devkit8000.h ? ? | ? ?3 +
?include/configs/omap3_beagle.h ? | ? ?3 +
?include/configs/omap3_evm.h ? ? ?| ? ?3 +
?include/configs/omap3_overo.h ? ?| ? ?3 +
?include/configs/omap3_pandora.h ?| ? ?3 +
?include/configs/omap3_sdp3430.h ?| ? ?3 +
?include/configs/omap3_zoom1.h ? ?| ? ?3 +
?include/configs/omap3_zoom2.h ? ?| ? ?3 +
Quoted 2 lines

?9 files changed, 94 insertions(+), 18 deletions(-)

Quoted 4 lines

Pushed to u-boot-ti/next

I think this series from Nishanth needs some runtime tests. I believe Steve had some issues with his EVM not booting everytime due

to issues with DDR init.

Quoted 3 lines

Thanks,
Sandeep

Quoted 8 lines
Quoted 6 lines

Maybe it should go on the testing branch?

I will give zoom2 a try..

Tom

Nishanth has already tried on SDP 3430.
I think the board that needs to be tried is overo.

Correct, it was Overo, though I suspect Beagle might have the same issue since they use the same Micron POP memory. ?I'll try to test this weekend.

Quoted 5 lines
Quoted 1 line

Steve

I can try that too.

Did you see the problem on warm or cold booting?

IIRC, it was an issue with both warm and cold boots.

Steve

#11 lore raw

PATCH 2/2 OMAP3:SDRC: introduce DDR types

In reply to Tom
Quoted 33 lines
Quoted 8 lines
Quoted 8 lines

Introduce Micron DDR timings and provide CONFIG_OMAP3_INFINEON_DDR and CONFIG_OMAP3_MICRON_DDR config options to allow for platform files to setup their timings as per the type of DDR selected

Reported-by Steve Sakoman in

http://www.nabble.com/forum/Permalink.jtp?root=25779518&post=25959734&page

Quoted 5 lines
Quoted 5 lines

=y

---
 include/asm-arm/arch-omap3/mem.h |   88

++++++++++++++++++++++++++++++---

Quoted 12 lines
Quoted 11 lines

-----

 include/configs/devkit8000.h     |    3 +
 include/configs/omap3_beagle.h   |    3 +
 include/configs/omap3_evm.h      |    3 +
 include/configs/omap3_overo.h    |    3 +
 include/configs/omap3_pandora.h  |    3 +
 include/configs/omap3_sdp3430.h  |    3 +
 include/configs/omap3_zoom1.h    |    3 +
 include/configs/omap3_zoom2.h    |    3 +
 9 files changed, 94 insertions(+), 18 deletions(-)
Quoted 4 lines

Pushed to u-boot-ti/next

I think this series from Nishanth needs some runtime tests. I believe Steve had some issues with his EVM not booting everytime due

to issues with DDR init.

Quoted 1 line
Quoted 9 lines
Quoted 2 lines

Thanks,
Sandeep

Maybe it should go on the testing branch?

I will give zoom2 a try..

Tom

Tom, Dirk, Steve,

Did u get a chance to try?

I am seeing a lot of OMAP3 patches which seem to be touching the above mentioned headers files.

Thanks,
Sandeep

#12 lore raw

PATCH 2/2 OMAP3:SDRC: introduce DDR types

Quoted 39 lines · Sandeep
Quoted 29 lines
Quoted 7 lines
Quoted 7 lines

Introduce Micron DDR timings and provide CONFIG_OMAP3_INFINEON_DDR and CONFIG_OMAP3_MICRON_DDR config options to allow for platform files to setup their timings as per the type of DDR selected

Reported-by Steve Sakoman in

http://www.nabble.com/forum/Permalink.jtp?root=25779518&post=25959734&page

Quoted 5 lines
Quoted 5 lines

=y

---
 include/asm-arm/arch-omap3/mem.h |   88

++++++++++++++++++++++++++++++---

Quoted 11 lines
Quoted 11 lines

-----

 include/configs/devkit8000.h     |    3 +
 include/configs/omap3_beagle.h   |    3 +
 include/configs/omap3_evm.h      |    3 +
 include/configs/omap3_overo.h    |    3 +
 include/configs/omap3_pandora.h  |    3 +
 include/configs/omap3_sdp3430.h  |    3 +
 include/configs/omap3_zoom1.h    |    3 +
 include/configs/omap3_zoom2.h    |    3 +
 9 files changed, 94 insertions(+), 18 deletions(-)
Quoted 4 lines

Pushed to u-boot-ti/next

I think this series from Nishanth needs some runtime tests. I believe Steve had some issues with his EVM not booting everytime due

Quoted 9 lines

to issues with DDR init.

Quoted 2 lines

Thanks,
Sandeep

Maybe it should go on the testing branch?

I will give zoom2 a try..

Tom

Quoted 11 lines

Tom, Dirk, Steve,

Did u get a chance to try?

I am seeing a lot of OMAP3 patches which seem to be touching the above mentioned headers files.

Thanks,
Sandeep

For zoom2.
I warm booted the kernel with ti/next.
So it looks ok for zoom2
Tom

#13 lore raw

PATCH 2/2 OMAP3:SDRC: introduce DDR types

Quoted 46 lines

From: Tom [mailto:Tom.Rix at windriver.com]
Sent: Thursday, November 12, 2009 11:30 AM

Quoted 8 lines · Sandeep
Quoted 8 lines
Quoted 7 lines
Quoted 7 lines

Introduce Micron DDR timings and provide CONFIG_OMAP3_INFINEON_DDR and CONFIG_OMAP3_MICRON_DDR config options to allow for platform files to setup their timings as per the type of DDR selected

Reported-by Steve Sakoman in

http://www.nabble.com/forum/Permalink.jtp?root=25779518&post=25959734&page

Quoted 33 lines
Quoted 21 lines
Quoted 5 lines
Quoted 5 lines

=y

---
 include/asm-arm/arch-omap3/mem.h |   88

++++++++++++++++++++++++++++++---

Quoted 11 lines
Quoted 11 lines

-----

 include/configs/devkit8000.h     |    3 +
 include/configs/omap3_beagle.h   |    3 +
 include/configs/omap3_evm.h      |    3 +
 include/configs/omap3_overo.h    |    3 +
 include/configs/omap3_pandora.h  |    3 +
 include/configs/omap3_sdp3430.h  |    3 +
 include/configs/omap3_zoom1.h    |    3 +
 include/configs/omap3_zoom2.h    |    3 +
 9 files changed, 94 insertions(+), 18 deletions(-)
Quoted 4 lines

Pushed to u-boot-ti/next

I think this series from Nishanth needs some runtime tests. I believe Steve had some issues with his EVM not booting everytime due

Quoted 9 lines

to issues with DDR init.

Quoted 2 lines

Thanks,
Sandeep

Maybe it should go on the testing branch?

I will give zoom2 a try..

Tom

Tom, Dirk, Steve,

Quoted 8 lines
Quoted 3 lines

Did u get a chance to try?

I am seeing a lot of OMAP3 patches which seem to be touching the above

mentioned headers files.

Quoted 1 line

For zoom2.
I warm booted the kernel with ti/next.
So it looks ok for zoom2

u-boot-ti Ok for SDP3430.

Regards,
Nishanth Menon

#14 lore raw

PATCH 1/2 OMAP3:SDRC: Cleanup references to SDP

In reply to Nishanth Menon
Quoted 10 lines

Remove SDP referenced unused defines

---
 cpu/arm_cortexa8/omap3/mem.c      |    2 +-
 cpu/arm_cortexa8/omap3/sys_info.c |    2 +-
 include/asm-arm/arch-omap3/mem.h  |   11 ++---------
 3 files changed, 4 insertions(+), 11 deletions(-)

Pushed to u-boot-ti/next

Thanks,
Sandeep