ARM Add New Board GEC2410
PATCH 4/4 ARM Add New Board GEC2410
Fix cs8900 dev->priv not init issue, do it as Ben Warren's suggestion.
checkpatch.pl result is
total: 0 errors, 0 warnings, 19 lines checked
0004-Fix-dev-priv-not-init-issue.patch has no obvious style problems and is ready for submission.
=========================================================
--- drivers/net/cs8900.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
drivers/net/cs8900.c +4 -3
@@ -321,15 +321,16 @@ int cs8900_initialize(u8 dev_num, int base_addr)memset (priv,0 ,sizeof (*priv)); priv->regs = (struct cs8900_regs *)base_addr; -/* Load MAC address from EEPROM */ -cs8900_get_enetaddr (dev); - dev->iobase = base_addr; dev->priv = priv; dev->init = cs8900_init; dev->halt = cs8900_halt; dev->send = cs8900_send; dev->recv = cs8900_recv; + +/* Load MAC address from EEPROM */ +cs8900_get_enetaddr (dev); +sprintf (dev->name,"%s-%hu" ,CS8900_DRIVERNAME , dev_num);eth_register (dev);
Signature · 1 line
1.6.0.4
PATCH 4/4 ARM Add New Board GEC2410
Quoted 10 lines · Hui.Tang
Fix cs8900
dev->privnot init issue, do it as Ben Warren's suggestion.checkpatch.pl result is
total: 0 errors, 0 warnings, 19 lines checked
0004-Fix-dev-priv-not-init-issue.patch has no obvious style problems and is ready for submission.
=========================================================
This stuff should go below the '---' line so that it doesn't become part of the changelog.
Also, this patch has nothing to do with 'ARM Add New Board GEC2410'. It should be a stand-alone patch, not part of your board submission. Please use a more appropriate title.
Quoted 20 lines
Signed-off-by Hui.Tang <[email protected]>--- drivers/net/cs8900.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)drivers/net/cs8900.c +0
-3@@ -321,15 +321,16 @@ int cs8900_initialize(u8 dev_num, int base_addr)memset (priv,0 ,sizeof (*priv)); priv->regs = (struct cs8900_regs *)base_addr; -/* Load MAC address from EEPROM */ -cs8900_get_enetaddr (dev); - dev->iobase = base_addr; dev->priv = priv; dev->init = cs8900_init;
drivers/net/cs8900.c int cs8900_initialize(u8 dev_num, int base_addr) · line 336
Quoted 10 lines
drivers/net/cs8900.c +4
-0dev->halt = cs8900_halt; dev->send = cs8900_send; dev->recv = cs8900_recv; + +/* Load MAC address from EEPROM */ +cs8900_get_enetaddr (dev); +sprintf (dev->name,"%s-%hu" ,CS8900_DRIVERNAME , dev_num);eth_register (dev);
The content looks fine, but the patch metadata needs to be re-done.
regards,
Ben