Skip to contentSkip to conversation

add the driver for Analog Devices Blackfin on-chip CAN controllers

PATCH Applied Barry Song 4 participants 5 messages Dec 11, 2009 3 messages not in the archive

Subsystems (3)
lore
Share & tools
lore

Barry Song

author
#0 lore raw

PATCH v4 1/1 add the driver for Analog Devices Blackfin on-chip CAN controllers

---
-v4:
1. request and release interrupts in open/close instead of in module load/unload
2. use bfin_read16/write16 instead of common readw/writew
3. fix "line over 80 characters" checkpatch warning
4. fix other coding style issues required by Wolfgang Grandegger

 drivers/net/can/Kconfig    |    9 +
 drivers/net/can/Makefile   |    1 +
 drivers/net/can/bfin_can.c |  783 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 793 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/can/bfin_can.c
drivers/net/can/Kconfig +9 -0
index bb803fa..8c485aa 100644
@@ -54,6 +54,15 @@ config CAN_MCP251X
 	---help---
 	  Driver for the Microchip MCP251x SPI CAN controllers.
 
+config CAN_BFIN
+	depends on CAN_DEV && (BF534 || BF536 || BF537 || BF538 || BF539 || BF54x)
+	tristate "Analog Devices Blackfin on-chip CAN"
+	---help---
+	  Driver for the Analog Devices Blackfin on-chip CAN controllers
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called bfin_can.
+
 source "drivers/net/can/mscan/Kconfig"
 
 source "drivers/net/can/sja1000/Kconfig"
drivers/net/can/Makefile +1 -0
index 56899fe..7a702f2 100644
@@ -14,5 +14,6 @@ obj-$(CONFIG_CAN_MSCAN)		+= mscan/
 obj-$(CONFIG_CAN_AT91)		+= at91_can.o
 obj-$(CONFIG_CAN_TI_HECC)	+= ti_hecc.o
 obj-$(CONFIG_CAN_MCP251X)	+= mcp251x.o
+obj-$(CONFIG_CAN_BFIN)		+= bfin_can.o
 
 ccflags-$(CONFIG_CAN_DEBUG_DEVICES) := -DDEBUG
drivers/net/can/bfin_can.c new file +783 -0

783 lines not on this page · raw message

Signature · 1 line
1.5.6.3

A message that is not in the archive (sent off-list or not yet received): 1260524788-13103-1-git-send-email-21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw
Quoted 8 lines · Barry Song

---
-v4:
1. request and release interrupts in open/close instead of in module load/unload
2. use bfin_read16/write16 instead of common readw/writew
3. fix "line over 80 characters" checkpatch warning
4. fix other coding style issues required by Wolfgang Grandegger

David, here is my

for this driver. There is just some minor issue with the copyright below. IIRC, the merge window is still open. It would be nice if this driver gets accepted for 2.6.33 already. Thanks.

Quoted 43 lines
 drivers/net/can/Kconfig    |    9 +
 drivers/net/can/Makefile   |    1 +
 drivers/net/can/bfin_can.c |  783 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 793 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/can/bfin_can.c
drivers/net/can/Kconfig +9 -0
index bb803fa..8c485aa 100644
@@ -54,6 +54,15 @@ config CAN_MCP251X
 	---help---
 	  Driver for the Microchip MCP251x SPI CAN controllers.
 
+config CAN_BFIN
+	depends on CAN_DEV && (BF534 || BF536 || BF537 || BF538 || BF539 || BF54x)
+	tristate "Analog Devices Blackfin on-chip CAN"
+	---help---
+	  Driver for the Analog Devices Blackfin on-chip CAN controllers
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called bfin_can.
+
 source "drivers/net/can/mscan/Kconfig"
 
 source "drivers/net/can/sja1000/Kconfig"
drivers/net/can/Makefile +1 -0
index 56899fe..7a702f2 100644
@@ -14,5 +14,6 @@ obj-$(CONFIG_CAN_MSCAN)		+= mscan/
 obj-$(CONFIG_CAN_AT91)		+= at91_can.o
 obj-$(CONFIG_CAN_TI_HECC)	+= ti_hecc.o
 obj-$(CONFIG_CAN_MCP251X)	+= mcp251x.o
+obj-$(CONFIG_CAN_BFIN)		+= bfin_can.o
 
 ccflags-$(CONFIG_CAN_DEBUG_DEVICES) := -DDEBUG
drivers/net/can/bfin_can.c new file +0 -0
new file mode 100644
index 0000000..c7fc1de

drivers/net/can/bfin_can.c line 9

Quoted 9 lines
drivers/net/can/bfin_can.c new file +9 -0
@@ -0,0 +1,783 @@
+/*
+ * Blackfin On-Chip CAN Driver
+ *
+ * Copyright 2004-2009 Analog Devices Inc.
+ *
+ * Enter bugs at http://blackfin.uclinux.org/
+ *
+ * Licensed under the GPL-2 or later.
+ */

David, is this a legal (acceptable) copyright note or is the usual "GPL-2 or later" text required.

Barry, thanks for your contribution.

Wolfgang.

maintainer
#3 lore raw

From: Wolfgang Grandegger <[email protected]>
Date: Fri, 11 Dec 2009 11:00:31 +0100

Quoted 10 lines
Quoted 8 lines · Barry Song

---
-v4:
1. request and release interrupts in open/close instead of in module load/unload
2. use bfin_read16/write16 instead of common readw/writew
3. fix "line over 80 characters" checkpatch warning
4. fix other coding style issues required by Wolfgang Grandegger

Quoted 6 lines

David, here is my

for this driver. There is just some minor issue with the copyright below. IIRC, the merge window is still open.

The networking merge window is closed. If I have to post a reference to this announcement I made one more freakin' time I'm going to be really angry:

http://marc.info/?l=linux-netdev&m=125988357131776&w=2

If people don't read the announcements I send to netdev, in particular the ones I prefix with "README" to show it's important, I might as well not do it at all.

Then you'll really have to guess what the current state of affairs is :-)

But it doesn't even matter for this case because we can take completely new drivers at any point in time, not just during the merge window.

A message that is not in the archive (sent off-list or not yet received): 20091211.021033.211260458.davem-fT/PcQaiUtIeIZ0/[email protected]

#5 lore raw
Quoted 23 lines · David Miller

From: Wolfgang Grandegger <[email protected]>
Date: Fri, 11 Dec 2009 11:00:31 +0100

Quoted 9 lines
Quoted 8 lines · Barry Song

---
-v4:
1. request and release interrupts in open/close instead of in module load/unload
2. use bfin_read16/write16 instead of common readw/writew
3. fix "line over 80 characters" checkpatch warning
4. fix other coding style issues required by Wolfgang Grandegger

Quoted 6 lines

David, here is my

for this driver. There is just some minor issue with the copyright below. IIRC, the merge window is still open.

The networking merge window is closed. If I have to post a reference to this announcement I made one more freakin' time I'm going to be really angry:

Quoted 5 lines

http://marc.info/?l=linux-netdev&m=125988357131776&w=2

If people don't read the announcements I send to netdev, in particular the ones I prefix with "README" to show it's important, I might as well not do it at all.

The "README" prefix is a good thing. Now I know what to look for next time.

Quoted 6 lines

Then you'll really have to guess what the current state of affairs is :-)

But it doesn't even matter for this case because we can take completely new drivers at any point in time, not just during the merge window.

OK, sorry for bothering you.

Thanks,

Wolfgang.

A message that is not in the archive (sent off-list or not yet received): [email protected]

Applied
#7 lore raw

From: Wolfgang Grandegger <[email protected]>
Date: Fri, 11 Dec 2009 11:00:31 +0100

Quoted 10 lines
Quoted 8 lines · Barry Song

---
-v4:
1. request and release interrupts in open/close instead of in module load/unload
2. use bfin_read16/write16 instead of common readw/writew
3. fix "line over 80 characters" checkpatch warning
4. fix other coding style issues required by Wolfgang Grandegger

Quoted 3 lines

David, here is my

Applied, thanks everyone.