v4l2: add new V4L2_PIX_FMT_RGB666 pixel format.
Subsystems (10)
PATCH v11 1/12 v4l2: add new V4L2_PIX_FMT_RGB666 pixel format.
That new macro is needed by the imx_drm staging driver
for supporting the QVGA display of the eukrea-cpuimx51 board.
---
ChangeLog v9->v10:
- Rebased on top of:
"211e7f2 [media] DocBook media: drop the old incorrect packed RGB table"
- Added Philipp Zabel's Ack.
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
ChangeLog v7->v8:
- Added Mauro Carvalho Chehab back to the list of Cc
ChangeLog v6->v7:
- Shrinked even more the Cc list.
ChangeLog v5->v6:
- Remove people not concerned by this patch from the Cc list.
ChangeLog v3->v4:
- Added Laurent Pinchart's Ack.
ChangeLog v2->v3:
- Added some interested people in the Cc list.
- Added Mauro Carvalho Chehab's Ack.
- Added documentation.
--- .../DocBook/media/v4l/pixfmt-packed-rgb.xml | 39 ++++++++++++++++++++ include/uapi/linux/videodev2.h | 1 + 2 files changed, 40 insertions(+)
Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml +39 -0
@@ -279,6 +279,45 @@ colorspace <constant>V4L2_COLORSPACE_SRGB</constant>.</para> <entry></entry> <entry></entry> </row> + <row id="V4L2-PIX-FMT-RGB666"> + <entry><constant>V4L2_PIX_FMT_RGB666</constant></entry> + <entry>'RGBH'</entry> + <entry></entry> + <entry>r<subscript>5</subscript></entry> + <entry>r<subscript>4</subscript></entry> + <entry>r<subscript>3</subscript></entry> + <entry>r<subscript>2</subscript></entry> + <entry>r<subscript>1</subscript></entry> + <entry>r<subscript>0</subscript></entry> + <entry>g<subscript>5</subscript></entry> + <entry>g<subscript>4</subscript></entry> + <entry></entry> + <entry>g<subscript>3</subscript></entry> + <entry>g<subscript>2</subscript></entry> + <entry>g<subscript>1</subscript></entry> + <entry>g<subscript>0</subscript></entry> + <entry>b<subscript>5</subscript></entry> + <entry>b<subscript>4</subscript></entry> + <entry>b<subscript>3</subscript></entry> + <entry>b<subscript>2</subscript></entry> + <entry></entry> + <entry>b<subscript>1</subscript></entry> + <entry>b<subscript>0</subscript></entry> + <entry></entry> + <entry></entry> + <entry></entry> + <entry></entry> + <entry></entry> + <entry></entry> + <entry></entry> + <entry></entry> + <entry></entry> + <entry></entry> + <entry></entry> + <entry></entry> + <entry></entry> + <entry></entry> + </row> <row id="V4L2-PIX-FMT-BGR24"> <entry><constant>V4L2_PIX_FMT_BGR24</constant></entry> <entry>'BGR3'</entry>
include/uapi/linux/videodev2.h +1 -0
@@ -299,6 +299,7 @@ struct v4l2_pix_format {#define V4L2_PIX_FMT_RGB555X v4l2_fourcc('R', 'G', 'B', 'Q')/* 16 RGB-5-5-5 BE */ #define V4L2_PIX_FMT_RGB565X v4l2_fourcc('R', 'G', 'B', 'R')/* 16 RGB-5-6-5 BE */ #define V4L2_PIX_FMT_BGR666 v4l2_fourcc('B', 'G', 'R', 'H')/* 18 BGR-6-6-6 */ +#define V4L2_PIX_FMT_RGB666 v4l2_fourcc('R', 'G', 'B', 'H')/* 18 RGB-6-6-6 */ #define V4L2_PIX_FMT_BGR24 v4l2_fourcc('B', 'G', 'R', '3')/* 24 BGR-8-8-8 */ #define V4L2_PIX_FMT_RGB24 v4l2_fourcc('R', 'G', 'B', '3')/* 24 RGB-8-8-8 */ #define V4L2_PIX_FMT_BGR32 v4l2_fourcc('B', 'G', 'R', '4')/* 32 BGR-8-8-8-8 */
Signature · 1 line
1.7.9.5
PATCH v11 2/12 imx-drm: Add RGB666 support for parallel display.
---
ChangeLog v8->v9:
- Rebased.
- Added Philipp Zabel's ack.
- Shortened the patch title.
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
- Rebased.
ChangeLog v7->v8:
- Shrinked even more the Cc list.
ChangeLog v6->v7:
- Shrinked even more the Cc list.
ChangeLog v5->v6:
- Remove people not concerned by this patch from the Cc list.
ChangeLog v3->v5:
- Use the correct RGB order.
ChangeLog v2->v3:
- Added some interested people in the Cc list.
- Removed the commit message long desciption that was just a copy of the short description.
- Rebased the patch.
- Fixed a copy-paste error in the ipu_dc_map_clear parameter.
--- .../bindings/staging/imx-drm/fsl-imx-drm.txt | 3 ++- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 9 +++++++++ drivers/staging/imx-drm/parallel-display.c | 2 ++ 3 files changed, 13 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt +2 -1
@@ -60,7 +60,8 @@ Required properties: - compatible: Should be "fsl,imx-parallel-display" Optional properties: - interface_pix_fmt: How this display is connected to the - display interface. Currently supported types: "rgb24", "rgb565", "bgr666" + display interface. Currently supported types: "rgb24", "rgb565", "bgr666", + "rgb666" - edid: verbatim EDID data block describing attached display. - ddc: phandle describing the i2c bus handling the display data channel
drivers/staging/imx-drm/ipu-v3/ipu-dc.c +9 -0
@@ -92,6 +92,7 @@ enum ipu_dc_map {IPU_DC_MAP_GBR24 ,/* TVEv2 */ IPU_DC_MAP_BGR666 ,IPU_DC_MAP_BGR24 , + IPU_DC_MAP_RGB666, }; struct ipu_dc {
@@ -155,6 +156,8 @@ static int ipu_pixfmt_to_map(u32 fmt)return IPU_DC_MAP_BGR666 ;case V4L2_PIX_FMT_BGR24 :return IPU_DC_MAP_BGR24 ; +case V4L2_PIX_FMT_RGB666 : +return IPU_DC_MAP_RGB666 ;default :return -EINVAL ; }
@@ -404,6 +407,12 @@ int ipu_dc_init(struct ipu_soc *ipu, struct device *dev,ipu_dc_map_config (priv,IPU_DC_MAP_BGR24 ,1 ,15 ,0xff );/* green */ ipu_dc_map_config (priv,IPU_DC_MAP_BGR24 ,0 ,23 ,0xff );/* blue */ +/* rgb666 */ +ipu_dc_map_clear (priv,IPU_DC_MAP_RGB666 ); +ipu_dc_map_config (priv,IPU_DC_MAP_RGB666 ,0 ,5 ,0xfc );/* blue */ +ipu_dc_map_config (priv,IPU_DC_MAP_RGB666 ,1 ,11 ,0xfc );/* green */ +ipu_dc_map_config (priv,IPU_DC_MAP_RGB666 ,2 ,17 ,0xfc );/* red */ +return 0 ; }
drivers/staging/imx-drm/parallel-display.c +2 -0
@@ -219,6 +219,8 @@ static int imx_pd_bind(struct device *dev, struct device *master, void *data) imxpd->interface_pix_fmt =V4L2_PIX_FMT_RGB565 ; else if (!strcmp(fmt, "bgr666")) imxpd->interface_pix_fmt =V4L2_PIX_FMT_BGR666 ; + else if (!strcmp(fmt, "rgb666")) + imxpd->interface_pix_fmt =V4L2_PIX_FMT_RGB666 ; } panel_node =of_parse_phandle (np,"fsl,panel" ,0 );
Signature · 1 line
1.7.9.5
PATCH v11 3/12 imx-drm: Correct BGR666 and the board's dts that use them.
In reply to Denis CarikliThe current BGR666 is not consistent with the other color mapings like BGR24. BGR666 should be in the same byte order than BGR24.
---
ChangeLog v9->v10:
- Rebased.
- Added Philipp Zabel's Ack.
- Included Lothar Waßmann's suggestion about imx-ldb.c.
- Shortened the patch title
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
ChangeLog v7->v8:
- Shrinked even more the Cc list.
ChangeLog v6->v7:
- Shrinked even more the Cc list.
ChangeLog v5->v6:
- Remove people not concerned by this patch from the Cc list.
- Added a better explanation of the change.
ChangeLog v5:
- New patch.
--- arch/arm/boot/dts/imx51-apf51dev.dts | 2 +- arch/arm/boot/dts/imx53-m53evk.dts | 2 +- drivers/staging/imx-drm/imx-ldb.c | 4 ++-- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/boot/dts/imx51-apf51dev.dts +1 -1
@@ -18,7 +18,7 @@ display@di1 { compatible = "fsl,imx-parallel-display"; - interface-pix-fmt = "bgr666"; + interface-pix-fmt = "rgb666"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_ipu_disp1>;
arch/arm/boot/dts/imx53-m53evk.dts +1 -1
@@ -23,7 +23,7 @@ soc { display1: display@di1 { compatible = "fsl,imx-parallel-display"; - interface-pix-fmt = "bgr666"; + interface-pix-fmt = "rgb666"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_ipu_disp1>;
drivers/staging/imx-drm/imx-ldb.c +2 -2
@@ -185,11 +185,11 @@ static void imx_ldb_encoder_prepare(struct drm_encoder *encoder)switch (imx_ldb_ch->chno) {case 0 : pixel_fmt = (ldb->ldb_ctrl &LDB_DATA_WIDTH_CH0_24 ) ? -V4L2_PIX_FMT_RGB24 :V4L2_PIX_FMT_BGR666 ; +V4L2_PIX_FMT_RGB24 :V4L2_PIX_FMT_RGB666 ;break ;case 1 : pixel_fmt = (ldb->ldb_ctrl &LDB_DATA_WIDTH_CH1_24 ) ? -V4L2_PIX_FMT_RGB24 :V4L2_PIX_FMT_BGR666 ; +V4L2_PIX_FMT_RGB24 :V4L2_PIX_FMT_RGB666 ;break ;default : dev_err(ldb->dev, "unable to config di%d panel format\n",
drivers/staging/imx-drm/ipu-v3/ipu-dc.c +2 -2
@@ -397,9 +397,9 @@ int ipu_dc_init(struct ipu_soc *ipu, struct device *dev,/* bgr666 */ ipu_dc_map_clear (priv,IPU_DC_MAP_BGR666 ); -ipu_dc_map_config (priv,IPU_DC_MAP_BGR666 ,0 ,5 ,0xfc );/* blue */ +ipu_dc_map_config (priv,IPU_DC_MAP_BGR666 ,0 ,17 ,0xfc );/* blue */ ipu_dc_map_config (priv,IPU_DC_MAP_BGR666 ,1 ,11 ,0xfc );/* green */ -ipu_dc_map_config (priv,IPU_DC_MAP_BGR666 ,2 ,17 ,0xfc );/* red */ +ipu_dc_map_config (priv,IPU_DC_MAP_BGR666 ,2 ,5 ,0xfc );/* red */ /* bgr24 */ ipu_dc_map_clear (priv,IPU_DC_MAP_BGR24 );
Signature · 6 lines
1.7.9.5 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
PATCH v11 4/12 imx-drm: Match ipu_di_signal_cfg's clk_pol with its description.
In reply to Denis CarikliAccording to the datasheet, setting the di0_polarity_disp_clk field in the GENERAL di register sets the output clock polarity to active high.
---
ChangeLog v9->v10:
- New patch that is now needed by the
"staging: imx-drm: Use de-active and pixelclk-active" patch.
--- drivers/staging/imx-drm/ipu-v3/ipu-di.c | 2 +- drivers/staging/imx-drm/ipuv3-crtc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/imx-drm/ipu-v3/ipu-di.c +1 -1
@@ -595,7 +595,7 @@ int ipu_di_init_sync_panel(struct ipu_di *di, struct ipu_di_signal_cfg *sig) } } -if (!sig->clk_pol) +if (sig->clk_pol) di_gen |=DI_GEN_POLARITY_DISP_CLK ;ipu_di_write (di, di_gen,DI_GENERAL );
drivers/staging/imx-drm/ipuv3-crtc.c +1 -1
@@ -158,7 +158,7 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc, sig_cfg.Vsync_pol =1 ; sig_cfg.enable_pol =1 ; - sig_cfg.clk_pol =1 ; + sig_cfg.clk_pol =0 ; sig_cfg.width = mode->hdisplay; sig_cfg.height = mode->vdisplay; sig_cfg.pixel_fmt = out_pixel_fmt;
Signature · 1 line
1.7.9.5
PATCH v11 5/12 imx-drm: use defines for clock polarity settings
In reply to Denis Carikli---
ChangeLog v9->v10:
- New patch which was splitted out from:
"staging: imx-drm: Use de-active and pixelclk-active display-timings.".
- Fixes many issues in "staging: imx-drm: Use de-active and pixelclk-active display-timings.":
- More clear meaning of the polarity settings.
- The SET_CLK_POL and SET_DE_POL masks are not
needed anymore.
--- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 8 +++++++- drivers/staging/imx-drm/ipu-v3/ipu-di.c | 4 ++-- drivers/staging/imx-drm/ipuv3-crtc.c | 4 ++-- 3 files changed, 11 insertions(+), 5 deletions(-)
drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h +7 -1
@@ -27,6 +27,12 @@ enum ipuv3_type {#define IPU_PIX_FMT_GBR24 v4l2_fourcc('G', 'B', 'R', '3') +#define CLK_POL_ACTIVE_LOW 0 +#define CLK_POL_ACTIVE_HIGH 1 + +#define ENABLE_POL_NEGEDGE 0 +#define ENABLE_POL_POSEDGE 1 +/* * Bitfield of Display Interface signal polarities. */
@@ -37,7 +43,7 @@ struct ipu_di_signal_cfg { unsigned clksel_en:1; unsigned clkidle_en:1; unsigned data_pol:1; /* true = inverted */ - unsigned clk_pol:1; /* true = rising edge */ + unsigned clk_pol:1; unsigned enable_pol:1; unsigned Hsync_pol:1; /* true = active high */ unsigned Vsync_pol:1;
drivers/staging/imx-drm/ipu-v3/ipu-di.c +2 -2
@@ -595,7 +595,7 @@ int ipu_di_init_sync_panel(struct ipu_di *di, struct ipu_di_signal_cfg *sig) } } -if (sig->clk_pol) +if (sig->clk_pol ==CLK_POL_ACTIVE_HIGH ) di_gen |=DI_GEN_POLARITY_DISP_CLK ;ipu_di_write (di, di_gen,DI_GENERAL );
@@ -606,7 +606,7 @@ int ipu_di_init_sync_panel(struct ipu_di *di, struct ipu_di_signal_cfg *sig) reg =ipu_di_read (di,DI_POL ); reg &= ~(DI_POL_DRDY_DATA_POLARITY |DI_POL_DRDY_POLARITY_15 ); -if (sig->enable_pol) +if (sig->enable_pol ==ENABLE_POL_POSEDGE ) reg |=DI_POL_DRDY_POLARITY_15 ;if (sig->data_pol) reg |=DI_POL_DRDY_DATA_POLARITY ;
drivers/staging/imx-drm/ipuv3-crtc.c +2 -2
@@ -157,8 +157,8 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,if (mode->flags &DRM_MODE_FLAG_PVSYNC ) sig_cfg.Vsync_pol =1 ; - sig_cfg.enable_pol =1 ; - sig_cfg.clk_pol =0 ; + sig_cfg.enable_pol =ENABLE_POL_POSEDGE ; + sig_cfg.clk_pol =CLK_POL_ACTIVE_LOW ; sig_cfg.width = mode->hdisplay; sig_cfg.height = mode->vdisplay; sig_cfg.pixel_fmt = out_pixel_fmt;
Signature · 1 line
1.7.9.5
PATCH v11 6/12 ARM: dts: imx5*, imx6*: correct display-timings nodes.
In reply to Denis CarikliThe imx-drm driver can't use the de-active and pixelclk-active display-timings properties yet.
Instead the data-enable and the pixel data clock polarity are hardcoded in the imx-drm driver.
So theses properties are now set to keep the same behaviour when imx-drm will start using them.
---
ChangeLog v9->v10:
- New patch that was splitted out of:
"staging imx-drm: Use de-active and pixelclk-active display-timings."
--- arch/arm/boot/dts/imx51-babbage.dts | 2 ++ arch/arm/boot/dts/imx53-m53evk.dts | 2 ++ arch/arm/boot/dts/imx53-tx53-x03x.dts | 2 +- arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 2 ++ arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 2 ++ arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 2 ++ arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 2 ++ arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 2 ++ arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 ++ 9 files changed, 17 insertions(+), 1 deletion(-)
arch/arm/boot/dts/imx51-babbage.dts +2 -0
@@ -38,6 +38,8 @@ vfront-porch = <7>; hsync-len = <60>; vsync-len = <10>; + de-active = <1>; + pixelclk-active = <0>; }; };
arch/arm/boot/dts/imx53-m53evk.dts +2 -0
@@ -40,6 +40,8 @@ vfront-porch = <9>; vsync-len = <3>; vsync-active = <1>; + de-active = <1>; + pixelclk-active = <0>; }; }; };
arch/arm/boot/dts/imx53-tx53-x03x.dts +1 -1
@@ -93,7 +93,7 @@ hsync-active = <0>; vsync-active = <0>; de-active = <1>; - pixelclk-active = <1>; + pixelclk-active = <0>; }; ET0500 {
arch/arm/boot/dts/imx6qdl-gw53xx.dtsi +2 -0
@@ -494,6 +494,8 @@ vfront-porch = <7>; hsync-len = <60>; vsync-len = <10>; + de-active = <1>; + pixelclk-active = <0>; }; }; };
arch/arm/boot/dts/imx6qdl-gw54xx.dtsi +2 -0
@@ -516,6 +516,8 @@ vfront-porch = <7>; hsync-len = <60>; vsync-len = <10>; + de-active = <1>; + pixelclk-active = <0>; }; }; };
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +2 -0
@@ -349,6 +349,8 @@ vfront-porch = <7>; hsync-len = <60>; vsync-len = <10>; + de-active = <1>; + pixelclk-active = <0>; }; }; };
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi +2 -0
@@ -405,6 +405,8 @@ vfront-porch = <7>; hsync-len = <60>; vsync-len = <10>; + de-active = <1>; + pixelclk-active = <0>; }; }; };
arch/arm/boot/dts/imx6qdl-sabrelite.dtsi +2 -0
@@ -349,6 +349,8 @@ vfront-porch = <7>; hsync-len = <60>; vsync-len = <10>; + de-active = <1>; + pixelclk-active = <0>; }; }; };
arch/arm/boot/dts/imx6qdl-sabresd.dtsi +2 -0
@@ -463,6 +463,8 @@ vfront-porch = <7>; hsync-len = <60>; vsync-len = <10>; + de-active = <1>; + pixelclk-active = <0>; }; }; };
Signature · 1 line
1.7.9.5
PATCH 7/12 drm: drm_display_mode: add signal polarity flags
In reply to Denis CarikliWe need a way to pass signal polarity informations
between DRM panels, and the display drivers.
To do that, a pol_flags field was added to drm_display_mode.
---
ChangeLog v10->v11:
- Since the imx-drm won't be able to retrive its regulators from the device tree when using display-timings nodes, and that I was told that the drm simple-panel driver already supported that, I then, instead, added what was lacking to make the eukrea displays work with the drm-simple-panel driver.
That required a way to get back the display polarity informations from the imx-drm driver without affecting userspace.
--- include/drm/drm_crtc.h | 8 ++++++++ 1 file changed, 8 insertions(+)
include/drm/drm_crtc.h +8 -0
@@ -131,6 +131,13 @@ enum drm_mode_status {#define DRM_MODE_FLAG_3D_MAX DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF +#define DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE BIT(1) +#define DRM_MODE_FLAG_POL_PIXDATA_POSEDGE BIT(2) +#define DRM_MODE_FLAG_POL_PIXDATA_PRESERVE BIT(3) +#define DRM_MODE_FLAG_POL_DE_NEGEDGE BIT(4) +#define DRM_MODE_FLAG_POL_DE_POSEDGE BIT(5) +#define DRM_MODE_FLAG_POL_DE_PRESERVE BIT(6) +struct drm_display_mode {/* Header */ struct list_head head;
@@ -183,6 +190,7 @@ struct drm_display_mode {int vrefresh;/* in Hz */ int hsync;/* in kHz */ enum hdmi_picture_aspect picture_aspect_ratio; +unsigned int pol_flags; };static inline bool drm_mode_is_stereo (const struct drm_display_mode *mode)
Signature · 1 line
1.7.9.5
Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags
Hi Denis,
Thanks for the patch.
Quoted 27 lines · Denis Carikli
We need a way to pass signal polarity informations
between DRM panels, and the display drivers.To do that, a
pol_flagsfield was added todrm_display_mode.Signed-off-by Denis Carikli <[email protected]>---
ChangeLogv10->v11:
- Since the imx-drm won't be able to retrive its regulators from the device tree when using display-timings nodes, and that I was told that the drm simple-panel driver already supported that, I then, instead, added what was lacking to make the eukrea displays work with the drm-simple-panel driver.That required a way to get back the display polarity informations from the imx-drm driver without affecting userspace.
--- include/drm/drm_crtc.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/drm/drm_crtc.h +0
-0
include/drm/drm_crtc.h enum drm_mode_status { · line 139
Quoted 9 lines
include/drm/drm_crtc.h +6
-0@@ -131,6 +131,13 @@ enum drm_mode_status {#define DRM_MODE_FLAG_3D_MAX DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF +#define DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE BIT(1) +#define DRM_MODE_FLAG_POL_PIXDATA_POSEDGE BIT(2) +#define DRM_MODE_FLAG_POL_PIXDATA_PRESERVE BIT(3) +#define DRM_MODE_FLAG_POL_DE_NEGEDGE BIT(4) +#define DRM_MODE_FLAG_POL_DE_POSEDGE BIT(5) +#define DRM_MODE_FLAG_POL_DE_PRESERVE BIT(6)
Could you add some description to these flags.
What are *_PRESERVE flags for?
Are those flags 1:1 compatible with respective 'videomode:flags'? I guess DE flags should be rather DRM_MODE_FLAG_POL_DE_(LOW|HIGH), am I right?
Regards
Andrzej
Quoted 13 lines
include/drm/drm_crtc.h +2
-0+struct drm_display_mode {/* Header */ struct list_head head;@@ -183,6 +190,7 @@ struct drm_display_mode {int vrefresh;/* in Hz */ int hsync;/* in kHz */ enum hdmi_picture_aspect picture_aspect_ratio; +unsigned int pol_flags; };static inline bool drm_mode_is_stereo (const struct drm_display_mode *mode)
Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags
Hello,
Quoted 34 lines · On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
Quoted 33 lines · Denis Carikli
We need a way to pass signal polarity informations between DRM panels, and the display drivers.
To do that, a
pol_flagsfield was added todrm_display_mode.Signed-off-by Denis Carikli <[email protected]>---
ChangeLogv10->v11:
- Since the imx-drm won't be able to retrive its regulatorsfrom the device tree when using display-timings nodes, and that I was told that the drm simple-panel driver already supported that, I then, instead, added what was lacking to make the eukrea displays work with the drm-simple-panel driver.
That required a way to get back the display polarity informations from the imx-drm driver without affecting userspace.
---
include/drm/drm_crtc.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/drm/drm_crtc.h +0
-0@@ -131,6 +131,13 @@ enum drm_mode_status {#define DRM_MODE_FLAG_3D_MAX DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF
Quoted 12 lines
include/drm/drm_crtc.h enum drm_mode_status { · line 139
Quoted 6 lines
include/drm/drm_crtc.h +6
-0+#define DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE BIT(1) +#define DRM_MODE_FLAG_POL_PIXDATA_POSEDGE BIT(2) +#define DRM_MODE_FLAG_POL_PIXDATA_PRESERVE BIT(3) +#define DRM_MODE_FLAG_POL_DE_NEGEDGE BIT(4) +#define DRM_MODE_FLAG_POL_DE_POSEDGE BIT(5) +#define DRM_MODE_FLAG_POL_DE_PRESERVE BIT(6)Could you add some description to these flags.
What are*_PRESERVEflags for?
Are those flags 1:1 compatible with respective 'videomode:flags'? I guess DE flags should be ratherDRM_MODE_FLAG_POL_DE_(LOW|HIGH), am I right?
Possibly nitpicking, I wouldn't call the clock edge on which data signals are generated/sampled "data polarity". This is clock polarity information.
Have you seen cases where pixel data and DE are geenrated or need to be sampled on different edges ?
Quoted 13 lines
Quoted 13 lines
include/drm/drm_crtc.h +2
-0+struct drm_display_mode {/* Header */ struct list_head head;@@ -183,6 +190,7 @@ struct drm_display_mode {int vrefresh;/* in Hz */ int hsync;/* in kHz */ enum hdmi_picture_aspect picture_aspect_ratio; +unsigned int pol_flags; }; static inline bool drm_mode_is_stereo(const struct drm_display_mode*mode)
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags
Hi,
Quoted 50 lines · Laurent Pinchart
Hello,
Quoted 34 lines · On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
Quoted 33 lines · Denis Carikli
We need a way to pass signal polarity informations between DRM panels, and the display drivers.
To do that, a
pol_flagsfield was added todrm_display_mode.Signed-off-by Denis Carikli <[email protected]>---
ChangeLogv10->v11:
- Since the imx-drm won't be able to retrive its regulatorsfrom the device tree when using display-timings nodes, and that I was told that the drm simple-panel driver already supported that, I then, instead, added what was lacking to make the eukrea displays work with the drm-simple-panel driver.
That required a way to get back the display polarity informations from the imx-drm driver without affecting userspace.
---
include/drm/drm_crtc.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/drm/drm_crtc.h +0
-0@@ -131,6 +131,13 @@ enum drm_mode_status {#define DRM_MODE_FLAG_3D_MAX DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALFQuoted 12 lines
include/drm/drm_crtc.h enum drm_mode_status { · line 139
Quoted 6 lines
include/drm/drm_crtc.h +6
-0+#define DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE BIT(1) +#define DRM_MODE_FLAG_POL_PIXDATA_POSEDGE BIT(2) +#define DRM_MODE_FLAG_POL_PIXDATA_PRESERVE BIT(3) +#define DRM_MODE_FLAG_POL_DE_NEGEDGE BIT(4) +#define DRM_MODE_FLAG_POL_DE_POSEDGE BIT(5) +#define DRM_MODE_FLAG_POL_DE_PRESERVE BIT(6)Could you add some description to these flags.
What are*_PRESERVEflags for?
Are those flags 1:1 compatible with respective 'videomode:flags'? I guess DE flags should be ratherDRM_MODE_FLAG_POL_DE_(LOW|HIGH), am I right?
Quoted 6 lines
Possibly nitpicking, I wouldn't call the clock edge on which data signals are generated/sampled "data polarity". This is clock polarity information.
Have you seen cases where pixel data and DE are geenrated or need to be sampled on different edges ?
DE is not a clock signal, but an 'Enable' signal whose value (high or low) defines the window in which the pixel data is valid. The flag defines whether data is valid during the HIGH or LOW period of DE.
Lothar Waßmann
Signature · 9 lines
___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | [email protected] ___________________________________________________________
Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags
Hi Lothar,
Quoted 53 lines · On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote:
Quoted 52 lines · Laurent Pinchart
Quoted 34 lines · On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
Quoted 33 lines · Denis Carikli
We need a way to pass signal polarity informations between DRM panels, and the display drivers.
To do that, a
pol_flagsfield was added todrm_display_mode.Signed-off-by Denis Carikli <[email protected]>---
ChangeLogv10->v11:
- Since the imx-drm won't be able to retrive its regulatorsfrom the device tree when using display-timings nodes, and that I was told that the drm simple-panel driver already supported that, I then, instead, added what was lacking to make the eukrea displays work with the drm-simple-panel driver.
That required a way to get back the display polarity informations from the imx-drm driver without affecting userspace.
---
include/drm/drm_crtc.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/drm/drm_crtc.h +0
-0@@ -131,6 +131,13 @@ enum drm_mode_status {#define DRM_MODE_FLAG_3D_MAX DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALFQuoted 12 lines
include/drm/drm_crtc.h enum drm_mode_status { · line 139
Quoted 6 lines
include/drm/drm_crtc.h +6
-0+#define DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE BIT(1) +#define DRM_MODE_FLAG_POL_PIXDATA_POSEDGE BIT(2) +#define DRM_MODE_FLAG_POL_PIXDATA_PRESERVE BIT(3) +#define DRM_MODE_FLAG_POL_DE_NEGEDGE BIT(4) +#define DRM_MODE_FLAG_POL_DE_POSEDGE BIT(5) +#define DRM_MODE_FLAG_POL_DE_PRESERVE BIT(6)Could you add some description to these flags.
What are*_PRESERVEflags for?
Are those flags 1:1 compatible with respective 'videomode:flags'? I guess DE flags should be ratherDRM_MODE_FLAG_POL_DE_(LOW|HIGH), am I right?Possibly nitpicking, I wouldn't call the clock edge on which data signals are generated/sampled "data polarity". This is clock polarity information.
Quoted 7 lines
Quoted 2 lines
Have you seen cases where pixel data and DE are geenrated or need to be sampled on different edges ?
DE is not a clock signal, but an 'Enable' signal whose value (high or low) defines the window in which the pixel data is valid. The flag defines whether data is valid during the HIGH or LOW period of DE.
The DRM_MODE_FLAG_POL_DE_(LOW|HIGH) do, by my impression of the proposed new DRM_MODE_FLAG_POL_DE_*EDGE flags is that they define sampling clock edges, not active levels.
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags
Hi,
Quoted 59 lines · Laurent Pinchart
Hi Lothar,
Quoted 56 lines · On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote:
Quoted 54 lines · Laurent Pinchart
Quoted 34 lines · On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
Quoted 33 lines · Denis Carikli
We need a way to pass signal polarity informations between DRM panels, and the display drivers.
To do that, a
pol_flagsfield was added todrm_display_mode.Signed-off-by Denis Carikli <[email protected]>---
ChangeLogv10->v11:
- Since the imx-drm won't be able to retrive its regulatorsfrom the device tree when using display-timings nodes, and that I was told that the drm simple-panel driver already supported that, I then, instead, added what was lacking to make the eukrea displays work with the drm-simple-panel driver.
That required a way to get back the display polarity informations from the imx-drm driver without affecting userspace.
---
include/drm/drm_crtc.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/drm/drm_crtc.h +0
-0@@ -131,6 +131,13 @@ enum drm_mode_status {#define DRM_MODE_FLAG_3D_MAX DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALFQuoted 12 lines
include/drm/drm_crtc.h enum drm_mode_status { · line 139
Quoted 6 lines
include/drm/drm_crtc.h +6
-0+#define DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE BIT(1) +#define DRM_MODE_FLAG_POL_PIXDATA_POSEDGE BIT(2) +#define DRM_MODE_FLAG_POL_PIXDATA_PRESERVE BIT(3) +#define DRM_MODE_FLAG_POL_DE_NEGEDGE BIT(4) +#define DRM_MODE_FLAG_POL_DE_POSEDGE BIT(5) +#define DRM_MODE_FLAG_POL_DE_PRESERVE BIT(6)Could you add some description to these flags.
What are*_PRESERVEflags for?
Are those flags 1:1 compatible with respective 'videomode:flags'? I guess DE flags should be ratherDRM_MODE_FLAG_POL_DE_(LOW|HIGH), am I right?Possibly nitpicking, I wouldn't call the clock edge on which data signals are generated/sampled "data polarity". This is clock polarity information.
Have you seen cases where pixel data and DE are geenrated or need to be sampled on different edges ?
Quoted 9 lines
Quoted 4 lines
DE is not a clock signal, but an 'Enable' signal whose value (high or low) defines the window in which the pixel data is valid. The flag defines whether data is valid during the HIGH or LOW period of DE.
The
DRM_MODE_FLAG_POL_DE_(LOW|HIGH)do, by my impression of the proposed new DRM_MODE_FLAG_POL_DE_*EDGE flags is that they define sampling clock edges, not active levels.
The current naming of the flags gives the impression that they describe the sampling edges of a clock signal. But the DE signal in fact is not a clock signal but a level sensitive gating signal.
Lothar Waßmann
Signature · 13 lines
___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | [email protected] ___________________________________________________________ _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags
Quoted 11 lines · Lothar Waßmann
Hi,
Quoted 8 lines · Laurent Pinchart
Hi Lothar,
Quoted 4 lines · On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote:
DE is not a clock signal, but an 'Enable' signal whose value (high or low) defines the window in which the pixel data is valid. The flag defines whether data is valid during the HIGH or LOW period of DE.
Quoted 7 lines
Quoted 4 lines
The
DRM_MODE_FLAG_POL_DE_(LOW|HIGH)do, by my impression of the proposed new DRM_MODE_FLAG_POL_DE_*EDGE flags is that they define sampling clock edges, not active levels.The current naming of the flags gives the impression that they describe the sampling edges of a clock signal. But the DE signal in fact is not a clock signal but a level sensitive gating signal.
+1
Signature · 2 lines
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it.
Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags
In reply to Lothar WaßmannHi Lothar,
Quoted 63 lines · On Tuesday 18 March 2014 08:50:30 Lothar Waßmann wrote:
Quoted 62 lines · Laurent Pinchart
Quoted 60 lines · On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote:
Quoted 48 lines · Laurent Pinchart
Quoted 34 lines · On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
Quoted 33 lines · Denis Carikli
We need a way to pass signal polarity informations between DRM panels, and the display drivers.
To do that, a
pol_flagsfield was added todrm_display_mode.Signed-off-by Denis Carikli <[email protected]>---
ChangeLogv10->v11:
- Since the imx-drm won't be able to retrive its regulatorsfrom the device tree when using display-timings nodes, and that I was told that the drm simple-panel driver already supported that, I then, instead, added what was lacking to make the eukrea displays work with the drm-simple-panel driver.
That required a way to get back the display polarity informations from the imx-drm driver without affecting userspace.
---
include/drm/drm_crtc.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/drm/drm_crtc.h +0
-0@@ -131,6 +131,13 @@ enum drm_mode_status {#define DRM_MODE_FLAG_3D_MAX DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALFQuoted 12 lines
include/drm/drm_crtc.h enum drm_mode_status { · line 139
Quoted 6 lines
include/drm/drm_crtc.h +6
-0+#define DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE BIT(1) +#define DRM_MODE_FLAG_POL_PIXDATA_POSEDGE BIT(2) +#define DRM_MODE_FLAG_POL_PIXDATA_PRESERVE BIT(3) +#define DRM_MODE_FLAG_POL_DE_NEGEDGE BIT(4) +#define DRM_MODE_FLAG_POL_DE_POSEDGE BIT(5) +#define DRM_MODE_FLAG_POL_DE_PRESERVE BIT(6)Could you add some description to these flags.
What are*_PRESERVEflags for?
Are those flags 1:1 compatible with respective 'videomode:flags'? I guess DE flags should be ratherDRM_MODE_FLAG_POL_DE_(LOW|HIGH), am I right?Quoted 6 lines
Possibly nitpicking, I wouldn't call the clock edge on which data signals are generated/sampled "data polarity". This is clock polarity information.
Have you seen cases where pixel data and DE are geenrated or need to be sampled on different edges ?
DE is not a clock signal, but an 'Enable' signal whose value (high or low) defines the window in which the pixel data is valid. The flag defines whether data is valid during the HIGH or LOW period of DE.
Quoted 7 lines
Quoted 3 lines
The
DRM_MODE_FLAG_POL_DE_(LOW|HIGH)do, by my impression of the proposed new DRM_MODE_FLAG_POL_DE_*EDGE flags is that they define sampling clock edges, not active levels.The current naming of the flags gives the impression that they describe the sampling edges of a clock signal. But the DE signal in fact is not a clock signal but a level sensitive gating signal.
That's not my point. I *know* that DE is a data gating signal with a polarity already defined by the DRM_MODE_FLAG_POL_DE_(LOW|HIGH) flags. Like all other signals it gets generated on a clock edge and is sampled on a clock edge. The DRM_MODE_FLAG_POL_DE_*EDGE flags proposed above describe seem to describe just that, *not* the signal polarity. I thus want to know whether there are systems where the data signals and the DE signal need to be sampled on different edges of the pixel clock.
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags
Quoted 9 lines · Laurent Pinchart
Hi Lothar,
That's not my point. I *know* that DE is a data gating signal with a polarity already defined by the
DRM_MODE_FLAG_POL_DE_(LOW|HIGH)flags. Like all other signals it gets generated on a clock edge and is sampled on a clock edge. The DRM_MODE_FLAG_POL_DE_*EDGE flags proposed above describe seem to describe just that, *not* the signal polarity. I thus want to know whether there are systems where the data signals and the DE signal need to be sampled on different edges of the pixel clock.
That's not relevant to this patch series though. This patch series is about adding configuration which will allow iMX6 SoCs to be properly configured for their displays.
iMX has the ability to:
- define the polarity of the clock signal
- define the polarity of the other signals
It does not have the ability to define which clock edge individual signals like vsync (frame clock), hsync (line clock), disable enable change on independently.
So, it doesn't make sense _here_ for the display enable to be defined by an edge - it's not something that can be changed here. What can only be changed is it's active level.
Of course, there may be some which can do this, and that's a separate problem that would need to be addressed when there's hardware that does support it.
The objection which Lothar is raising is that _this_ definition does not match the _hardware_ capabilities which it is intended to be used with, which is a very valid objection.
Signature · 2 lines
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it.
Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags
Hi Russell,
Quoted 28 lines · On Tuesday 18 March 2014 12:56:23 Russell King - ARM Linux wrote:
Quoted 9 lines · Laurent Pinchart
Hi Lothar,
That's not my point. I *know* that DE is a data gating signal with a polarity already defined by the
DRM_MODE_FLAG_POL_DE_(LOW|HIGH)flags. Like all other signals it gets generated on a clock edge and is sampled on a clock edge. The DRM_MODE_FLAG_POL_DE_*EDGE flags proposed above describe seem to describe just that, *not* the signal polarity. I thus want to know whether there are systems where the data signals and the DE signal need to be sampled on different edges of the pixel clock.That's not relevant to this patch series though. This patch series is about adding configuration which will allow iMX6 SoCs to be properly configured for their displays.
iMX has the ability to:
- define the polarity of the clock signal
- define the polarity of the other signalsIt does not have the ability to define which clock edge individual signals like vsync (frame clock), hsync (line clock), disable enable change on independently.
So, it doesn't make sense _here_ for the display enable to be defined by an edge - it's not something that can be changed here. What can only be changed is it's active level.
Quoted 7 lines
Of course, there may be some which can do this, and that's a separate problem that would need to be addressed when there's hardware that does support it.
The objection which Lothar is raising is that _this_ definition does not match the _hardware_ capabilities which it is intended to be used with, which is a very valid objection.
Thank you for the clarification. That absolutely makes sense.
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags
In reply to Laurent PinchartHi,
Quoted 70 lines · Laurent Pinchart
Hi Lothar,
Quoted 67 lines · On Tuesday 18 March 2014 08:50:30 Lothar Waßmann wrote:
Quoted 65 lines · Laurent Pinchart
Quoted 53 lines · On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote:
Quoted 52 lines · Laurent Pinchart
Quoted 34 lines · On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote:
Quoted 33 lines · Denis Carikli
We need a way to pass signal polarity informations between DRM panels, and the display drivers.
To do that, a
pol_flagsfield was added todrm_display_mode.Signed-off-by Denis Carikli <[email protected]>---
ChangeLogv10->v11:
- Since the imx-drm won't be able to retrive its regulatorsfrom the device tree when using display-timings nodes, and that I was told that the drm simple-panel driver already supported that, I then, instead, added what was lacking to make the eukrea displays work with the drm-simple-panel driver.
That required a way to get back the display polarity informations from the imx-drm driver without affecting userspace.
---
include/drm/drm_crtc.h | 8 ++++++++ 1 file changed, 8 insertions(+)include/drm/drm_crtc.h +0
-0@@ -131,6 +131,13 @@ enum drm_mode_status {#define DRM_MODE_FLAG_3D_MAX DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALFQuoted 12 lines
include/drm/drm_crtc.h enum drm_mode_status { · line 139
Quoted 6 lines
include/drm/drm_crtc.h +6
-0+#define DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE BIT(1) +#define DRM_MODE_FLAG_POL_PIXDATA_POSEDGE BIT(2) +#define DRM_MODE_FLAG_POL_PIXDATA_PRESERVE BIT(3) +#define DRM_MODE_FLAG_POL_DE_NEGEDGE BIT(4) +#define DRM_MODE_FLAG_POL_DE_POSEDGE BIT(5) +#define DRM_MODE_FLAG_POL_DE_PRESERVE BIT(6)Could you add some description to these flags.
What are*_PRESERVEflags for?
Are those flags 1:1 compatible with respective 'videomode:flags'? I guess DE flags should be ratherDRM_MODE_FLAG_POL_DE_(LOW|HIGH), am I right?Possibly nitpicking, I wouldn't call the clock edge on which data signals are generated/sampled "data polarity". This is clock polarity information.
Quoted 7 lines
Quoted 2 lines
Have you seen cases where pixel data and DE are geenrated or need to be sampled on different edges ?
DE is not a clock signal, but an 'Enable' signal whose value (high or low) defines the window in which the pixel data is valid. The flag defines whether data is valid during the HIGH or LOW period of DE.
The
DRM_MODE_FLAG_POL_DE_(LOW|HIGH)do, by my impression of the proposed new DRM_MODE_FLAG_POL_DE_*EDGE flags is that they define sampling clock edges, not active levels.
Quoted 9 lines
Quoted 3 lines
The current naming of the flags gives the impression that they describe the sampling edges of a clock signal. But the DE signal in fact is not a clock signal but a level sensitive gating signal.
That's not my point. I *know* that DE is a data gating signal with a polarity already defined by the
DRM_MODE_FLAG_POL_DE_(LOW|HIGH)flags. Like all other signals it gets generated on a clock edge and is sampled on a clock edge. The DRM_MODE_FLAG_POL_DE_*EDGE flags proposed above describe seem to describe just
The important word here is 'seem'.
Lothar Waßann
Signature · 13 lines
___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | [email protected] ___________________________________________________________ _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
PATCH 8/12 imx-drm: Use drm_display_mode timings flags.
In reply to Denis CarikliThe previous hardware behaviour was kept if the
flags are not set.
---
ChangeLog v10->v11:
- This patch was splitted-out and adapted from:
"Prepare imx-drm for extra display-timings retrival."
- The display-timings dt specific part was removed.
- The flags names were changed to use the DRM ones from:
"drm: drm_display_mode: add signal polarity flags"
--- drivers/staging/imx-drm/imx-drm-core.c | 10 ++++++++++ drivers/staging/imx-drm/imx-drm.h | 6 ++++++ drivers/staging/imx-drm/imx-hdmi.c | 3 +++ drivers/staging/imx-drm/imx-ldb.c | 3 +++ drivers/staging/imx-drm/imx-tve.c | 3 +++ drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 6 ++++-- drivers/staging/imx-drm/ipu-v3/ipu-di.c | 7 ++++++- drivers/staging/imx-drm/ipuv3-crtc.c | 21 +++++++++++++++++++-- 3 files changed, 29 insertions(+), 5 deletions(-)
drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h +4 -2
@@ -29,9 +29,11 @@ enum ipuv3_type {#define CLK_POL_ACTIVE_LOW 0#define CLK_POL_ACTIVE_HIGH 1 +#define CLK_POL_PRESERVE 2#define ENABLE_POL_NEGEDGE 0#define ENABLE_POL_POSEDGE 1 +#define ENABLE_POL_PRESERVE 2/* * Bitfield of Display Interface signal polarities.
@@ -43,10 +45,10 @@ struct ipu_di_signal_cfg { unsigned clksel_en:1; unsigned clkidle_en:1; unsigned data_pol:1; /* true = inverted */ - unsigned clk_pol:1; - unsigned enable_pol:1; unsigned Hsync_pol:1; /* true = active high */ unsigned Vsync_pol:1; +u8 clk_pol; +u8 enable_pol;u16 width;u16 height;
drivers/staging/imx-drm/ipu-v3/ipu-di.c +6 -1
@@ -597,6 +597,8 @@ int ipu_di_init_sync_panel(struct ipu_di *di, struct ipu_di_signal_cfg *sig)if (sig->clk_pol ==CLK_POL_ACTIVE_HIGH ) di_gen |=DI_GEN_POLARITY_DISP_CLK ; +else if (sig->clk_pol ==CLK_POL_ACTIVE_LOW ) + di_gen &= ~DI_GEN_POLARITY_DISP_CLK ;ipu_di_write (di, di_gen,DI_GENERAL );
@@ -604,10 +606,13 @@ int ipu_di_init_sync_panel(struct ipu_di *di, struct ipu_di_signal_cfg *sig) DI_SYNC_AS_GEN); reg =ipu_di_read (di,DI_POL ); - reg &= ~(DI_POL_DRDY_DATA_POLARITY |DI_POL_DRDY_POLARITY_15 ); + reg &= ~(DI_POL_DRDY_DATA_POLARITY );if (sig->enable_pol ==ENABLE_POL_POSEDGE ) reg |=DI_POL_DRDY_POLARITY_15 ; +else if (sig->enable_pol ==ENABLE_POL_NEGEDGE ) + reg &= ~DI_POL_DRDY_POLARITY_15 ; +if (sig->data_pol) reg |=DI_POL_DRDY_DATA_POLARITY ;
drivers/staging/imx-drm/ipuv3-crtc.c +19 -2
@@ -157,8 +157,25 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,if (mode->flags &DRM_MODE_FLAG_PVSYNC ) sig_cfg.Vsync_pol =1 ; - sig_cfg.enable_pol =ENABLE_POL_POSEDGE ; - sig_cfg.clk_pol =CLK_POL_ACTIVE_LOW ; +if (mode->pol_flags &DRM_MODE_FLAG_POL_PIXDATA_POSEDGE ) + sig_cfg.enable_pol =ENABLE_POL_POSEDGE ; +else if (mode->pol_flags &DRM_MODE_FLAG_POL_DE_NEGEDGE ) + sig_cfg.enable_pol =ENABLE_POL_NEGEDGE ; +else if (mode->pol_flags &DRM_MODE_FLAG_POL_PIXDATA_PRESERVE ) + sig_cfg.enable_pol =ENABLE_POL_PRESERVE ; +else + sig_cfg.enable_pol =ENABLE_POL_POSEDGE ; + +if (mode->private_flags &DRM_MODE_FLAG_POL_DE_POSEDGE ) + sig_cfg.clk_pol =CLK_POL_ACTIVE_HIGH ; +else if (mode->private_flags &DRM_MODE_FLAG_POL_DE_NEGEDGE ) + sig_cfg.clk_pol =CLK_POL_ACTIVE_LOW ; +else if (mode->private_flags &DRM_MODE_FLAG_POL_DE_PRESERVE ) + sig_cfg.clk_pol =CLK_POL_PRESERVE ; +else + sig_cfg.clk_pol =CLK_POL_ACTIVE_LOW ; + + sig_cfg.width = mode->hdisplay; sig_cfg.height = mode->vdisplay; sig_cfg.pixel_fmt = out_pixel_fmt;
Signature · 1 line
1.7.9.5
Re: [PATCH 08/12] imx-drm: Use drm_display_mode timings flags.
Hi,
Quoted 97 lines · Denis Carikli
The previous hardware behaviour was kept if the
flags are not set.Signed-off-by Denis Carikli <[email protected]>---
ChangeLogv10->v11:
- This patch was splitted-out and adapted from:
"Prepare imx-drm for extra display-timings retrival."
- The display-timings dt specific part was removed.
- The flags names were changed to use the DRM ones from:
"drm:drm_display_mode: add signal polarity flags"--- drivers/staging/imx-drm/imx-drm-core.c | 10 ++++++++++ drivers/staging/imx-drm/imx-drm.h | 6 ++++++ drivers/staging/imx-drm/imx-hdmi.c | 3 +++ drivers/staging/imx-drm/imx-ldb.c | 3 +++ drivers/staging/imx-drm/imx-tve.c | 3 +++ drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 6 ++++-- drivers/staging/imx-drm/ipu-v3/ipu-di.c | 7 ++++++- drivers/staging/imx-drm/ipuv3-crtc.c | 21 +++++++++++++++++++-- 3 files changed, 29 insertions(+), 5 deletions(-)drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h +4
-2@@ -29,9 +29,11 @@ enum ipuv3_type {#define CLK_POL_ACTIVE_LOW 0#define CLK_POL_ACTIVE_HIGH 1 +#define CLK_POL_PRESERVE 2#define ENABLE_POL_NEGEDGE 0#define ENABLE_POL_POSEDGE 1 +#define ENABLE_POL_PRESERVE 2/* * Bitfield of Display Interface signal polarities. @@ -43,10 +45,10 @@ struct ipu_di_signal_cfg { unsigned clksel_en:1; unsigned clkidle_en:1; unsigned data_pol:1; /* true = inverted */ - unsigned clk_pol:1; - unsigned enable_pol:1; unsigned Hsync_pol:1; /* true = active high */ unsigned Vsync_pol:1; +u8 clk_pol; +u8 enable_pol;u16 width;u16 height;drivers/staging/imx-drm/ipu-v3/ipu-di.c +6
-1@@ -597,6 +597,8 @@ int ipu_di_init_sync_panel(struct ipu_di *di, struct ipu_di_signal_cfg *sig)if (sig->clk_pol ==CLK_POL_ACTIVE_HIGH ) di_gen |=DI_GEN_POLARITY_DISP_CLK ; +else if (sig->clk_pol ==CLK_POL_ACTIVE_LOW ) + di_gen &= ~DI_GEN_POLARITY_DISP_CLK ;ipu_di_write (di, di_gen,DI_GENERAL );@@ -604,10 +606,13 @@ int ipu_di_init_sync_panel(struct ipu_di *di, struct ipu_di_signal_cfg *sig) DI_SYNC_AS_GEN); reg =ipu_di_read (di,DI_POL ); - reg &= ~(DI_POL_DRDY_DATA_POLARITY |DI_POL_DRDY_POLARITY_15 ); + reg &= ~(DI_POL_DRDY_DATA_POLARITY );if (sig->enable_pol ==ENABLE_POL_POSEDGE ) reg |=DI_POL_DRDY_POLARITY_15 ; +else if (sig->enable_pol ==ENABLE_POL_NEGEDGE ) + reg &= ~DI_POL_DRDY_POLARITY_15 ; +if (sig->data_pol) reg |=DI_POL_DRDY_DATA_POLARITY ;drivers/staging/imx-drm/ipuv3-crtc.c +8
-2@@ -157,8 +157,25 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,if (mode->flags &DRM_MODE_FLAG_PVSYNC ) sig_cfg.Vsync_pol =1 ; - sig_cfg.enable_pol =ENABLE_POL_POSEDGE ; - sig_cfg.clk_pol =CLK_POL_ACTIVE_LOW ; +if (mode->pol_flags &DRM_MODE_FLAG_POL_PIXDATA_POSEDGE ) + sig_cfg.enable_pol =ENABLE_POL_POSEDGE ; +else if (mode->pol_flags &DRM_MODE_FLAG_POL_DE_NEGEDGE ) + sig_cfg.enable_pol =ENABLE_POL_NEGEDGE ; +else if (mode->pol_flags &DRM_MODE_FLAG_POL_PIXDATA_PRESERVE ) + sig_cfg.enable_pol =ENABLE_POL_PRESERVE ; +else + sig_cfg.enable_pol =ENABLE_POL_POSEDGE ;
drivers/staging/imx-drm/ipuv3-crtc.c static int ipu_crtc_mode_set(struct drm_crtc *crtc, · line 177
Quoted 10 lines
drivers/staging/imx-drm/ipuv3-crtc.c +9
-0+ +if (mode->private_flags &DRM_MODE_FLAG_POL_DE_POSEDGE ) + sig_cfg.clk_pol =CLK_POL_ACTIVE_HIGH ; +else if (mode->private_flags &DRM_MODE_FLAG_POL_DE_NEGEDGE ) + sig_cfg.clk_pol =CLK_POL_ACTIVE_LOW ; +else if (mode->private_flags &DRM_MODE_FLAG_POL_DE_PRESERVE ) + sig_cfg.clk_pol =CLK_POL_PRESERVE ; +else + sig_cfg.clk_pol =CLK_POL_ACTIVE_LOW ;
This is completely messed up. POL_PIXDATA should obviously define the clock edge at which the pixel data is sampled and thus should determine the value of sig_cfg.clk_pol and POL_DE should determine the value of sig_cfg.enable_pol.
Lothar Waßmann
Signature · 13 lines
___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | [email protected] ___________________________________________________________ _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
PATCH 9/12 drm/panel: Add Eukrea mbimxsd51 displays.
In reply to Denis Carikli---
ChangeLog v10->v11:
- New patch.
--- .../bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt | 7 ++ .../bindings/panel/eukrea,mbimxsd51-dvi-svga.txt | 7 ++ .../bindings/panel/eukrea,mbimxsd51-dvi-vga.txt | 7 ++ drivers/gpu/drm/panel/panel-simple.c | 81 ++++++++++++++++++++ 4 files changed, 102 insertions(+) create mode 100644 Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt create mode 100644 Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt create mode 100644 Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt
Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt new file +7 -0
@@ -0,0 +1,7 @@ +Eukrea CMO-QVGA (320x240 pixels) TFT LCD panel + +Required properties: +- compatible: should be "eukrea,mbimxsd51-cmo-qvga" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory.
Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt new file +7 -0
@@ -0,0 +1,7 @@ +Eukrea DVI-SVGA (800x600 pixels) DVI output. + +Required properties: +- compatible: should be "eukrea,mbimxsd51-dvi-svga" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory.
Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt new file +7 -0
@@ -0,0 +1,7 @@ +Eukrea DVI-VGA (640x480 pixels) DVI output. + +Required properties: +- compatible: should be "eukrea,mbimxsd51-dvi-vga" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory.
drivers/gpu/drm/panel/panel-simple.c +81 -0
93 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH 10/12 ARM: dts: mbimx51sd: Add display support.
In reply to Denis CarikliThe CMO-QVGA, DVI-SVGA and DVI-VGA are added.
---
ChangeLog v10->v11:
- Now uses the drm-panel instead of the display-timings. This is to get regulator support, which is lacking in the imx-drm driver when using the display-timings.
ChangeLog v9->v10:
- Rebased
- Now enables the cmo-qvga regulator at boot.
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
- updated pixelclk-active after the following patch:
"imx-drm: Match ipu_di_signal_cfg's clk_pol with its description."
ChangeLog v7->v8:
- Rebased the patch: added the now required imx-drm node.
- Adapted the svga clock-frequency value in order to still be able to display an image after the following commit:
"imx-drm: ipu-v3: more inteligent DI clock selection"
ChangeLog v6->v7:
- Shrinked even more the Cc list.
- Since the pingrp headers were removed, the references to it where replaced by the actual pins.
- Added the targets to arch/arm/boot/dts/Makefile
ChangeLog v5->v6:
- Reordered the Cc list.
ChangeLog v3->v5:
- Updated to new GPIO defines.
- Updated to new licenses checkpatch requirements.
- one whitespace cleanup.
ChangeLog v2->v3:
- Splitted out from the patch that added support for the cpuimx51/mbimxsd51 boards.
- This patch now only adds display support.
- Added some interested people in the Cc list, and removed some people that might be annoyed by the receiving of that patch which is unrelated to their subsystem.
- rebased and reworked the dts displays addition.
- Also rebased and reworked the fsl,pins usage.
--- arch/arm/boot/dts/Makefile | 3 ++ .../imx51-eukrea-mbimxsd51-baseboard-cmo-qvga.dts | 41 ++++++++++++++++ .../imx51-eukrea-mbimxsd51-baseboard-dvi-svga.dts | 28 +++++++++++ .../imx51-eukrea-mbimxsd51-baseboard-dvi-vga.dts | 28 +++++++++++ .../boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts | 49 ++++++++++++++++++++ 5 files changed, 149 insertions(+) create mode 100644 arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard-cmo-qvga.dts create mode 100644 arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard-dvi-svga.dts create mode 100644 arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard-dvi-vga.dts
arch/arm/boot/dts/Makefile +3 -0
@@ -178,6 +178,9 @@ dtb-$(CONFIG_ARCH_MXC) += \ imx51-apf51dev.dtb \ imx51-babbage.dtb \ imx51-eukrea-mbimxsd51-baseboard.dtb \ + imx51-eukrea-mbimxsd51-baseboard-cmo-qvga.dtb \ + imx51-eukrea-mbimxsd51-baseboard-dvi-svga.dtb \ + imx51-eukrea-mbimxsd51-baseboard-dvi-vga.dtb \ imx53-ard.dtb \ imx53-m53evk.dtb \ imx53-mba53.dtb \
arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard-cmo-qvga.dts new file +41 -0
41 lines not on this page · raw message
arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard-dvi-svga.dts new file +28 -0
@@ -0,0 +1,28 @@ +/* + * Copyright 2013 Eukréa Electromatique <[email protected]> + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include "imx51-eukrea-mbimxsd51-baseboard.dts" + +/ { + model = "Eukrea MBIMXSD51 with the DVI-SVGA Display"; + compatible = "eukrea,mbimxsd51-baseboard-dvi-svga", "eukrea,mbimxsd51-baseboard", "eukrea,cpuimx51", "fsl,imx51"; + + panel: panel { + compatible = "eukrea,mbimxsd51-dvi-svga", "simple-panel"; + }; +}; + +&display { + status = "okay"; + fsl,panel = <&panel>; +};
arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard-dvi-vga.dts new file +28 -0
@@ -0,0 +1,28 @@ +/* + * Copyright 2013 Eukréa Electromatique <[email protected]> + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version 2 + * of the License, or (at your option) any later version. + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include "imx51-eukrea-mbimxsd51-baseboard.dts" + +/ { + model = "Eukrea MBIMXSD51 with the DVI-VGA Display"; + compatible = "eukrea,mbimxsd51-baseboard-dvi-vga", "eukrea,mbimxsd51-baseboard", "eukrea,cpuimx51", "fsl,imx51"; + + panel: panel { + compatible = "eukrea,mbimxsd51-dvi-vga", "simple-panel"; + }; +}; + +&display { + status = "okay"; + fsl,panel = <&panel>; +};
arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard.dts +49 -0
67 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH 11/12 ARM: dts: mbimx51sd: Add CMO-QVGA backlight support.
In reply to Denis Carikli---
ChangeLog v9->v11:
- Now uses the drm-panel instead of the display-timings.
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
- The backlight is now on at boot.
ChangeLog v6->v7:
- Shrinked even more the Cc list.
ChangeLog v5->v6:
- Reordered the Cc list.
ChangeLog v3->v5:
- Updated to the new GPIO defines.
ChangeLog v2->v3:
- Splitted out from the patch that added support for the cpuimx51/mbimxsd51 boards.
- This patch now only adds backlight support.
- Added some interested people in the Cc list, and removed some people that might be annoyed by the receiving of that patch which is unrelated to their subsystem.
--- .../imx51-eukrea-mbimxsd51-baseboard-cmo-qvga.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm/boot/dts/imx51-eukrea-mbimxsd51-baseboard-cmo-qvga.dts +10 -0
@@ -17,9 +17,19 @@ model = "Eukrea MBIMXSD51 with the CMO-QVGA Display"; compatible = "eukrea,mbimxsd51-baseboard-cmo-qvga", "eukrea,mbimxsd51-baseboard", "eukrea,cpuimx51", "fsl,imx51"; + backlight: backlight { + compatible = "gpio-backlight"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_backlight_1>; + gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>; + default-brightness-level = <1>; + default-on; + }; + panel: panel { compatible = "eukrea,mbimxsd51-cmo-qvga", "simple-panel"; power-supply = <®_lcd_3v3>; + backlight = <&backlight>; }; reg_lcd_3v3: lcd-en {
Signature · 1 line
1.7.9.5
PATCH 12/12 ARM: imx_v6_v7_defconfig: Add more drm drivers.
In reply to Denis CarikliThe DRM_PANEL_SIMPLE is needed by the eukrea
mbimxsd51's displays.
---
- New patch, splitting it would be overkill.
--- arch/arm/configs/imx_v6_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+)
arch/arm/configs/imx_v6_v7_defconfig +2 -0
@@ -183,6 +183,7 @@ CONFIG_V4L_MEM2MEM_DRIVERS=y CONFIG_VIDEO_CODA=y CONFIG_SOC_CAMERA_OV2640=y CONFIG_DRM=y +CONFIG_DRM_PANEL_SIMPLE=y CONFIG_BACKLIGHT_LCD_SUPPORT=y CONFIG_LCD_CLASS_DEVICE=y CONFIG_LCD_L4F00242T03=y
@@ -245,6 +246,7 @@ CONFIG_DRM_IMX_TVE=y CONFIG_DRM_IMX_LDB=y CONFIG_DRM_IMX_IPUV3_CORE=y CONFIG_DRM_IMX_IPUV3=y +CONFIG_DRM_IMX_HDMI=y CONFIG_COMMON_CLK_DEBUG=y # CONFIG_IOMMU_SUPPORT is not set CONFIG_PWM=y
Signature · 1 line
1.7.9.5