Issue with PPP auth and empty username/password

DISCUSSION Marcel Holtmann 2 participants 4 messages Mar 25, 2010 – Mar 27, 2010

Share & tools

Marcel Holtmann

author

2010-03-25 00:00 UTC #0 lore raw

Hi Kristen,

I started tested the PPP code and run into a simple crash when not providing username and password. This should be possible.

Program terminated with signal 11, Segmentation fault.
#0 0x0000003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6
(gdb) bt
#0 0x0000003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6
#1 0x000000000040ca9b in chap_process_challenge (priv=0x15a6bf0, new_packet=0x15a5164 "\001\001")
at gatchat/ppp_auth.c:86
#2 chap_process_packet (priv=0x15a6bf0, new_packet=0x15a5164 "\001\001") at gatchat/ppp_auth.c:143 #3 0x000000000040a66f in ppp_recv (channel=<value optimized out>, cond=<value optimized out>, data=0x15a6d50)

    at gatchat/ppp.c:205
#4  ppp_feed (channel=<value optimized out>, cond=<value optimized out>, data=0x15a6d50) at gatchat/ppp.c:286
#5  ppp_cb (channel=<value optimized out>, cond=<value optimized out>, data=0x15a6d50) at gatchat/ppp.c:340
#6  0x0000003598a3923e in g_main_context_dispatch () from /lib64/libglib-2.0.so.0
#7  0x0000003598a3cc28 in ?? () from /lib64/libglib-2.0.so.0
#8  0x0000003598a3d075 in g_main_loop_run () from /lib64/libglib-2.0.so.0
#9  0x0000000000403918 in main (argc=1, argv=0x7fff7b97eb28) at gatchat/gsmdial.c:624

Regards

Marcel

Marcel Holtmann

author

2010-03-27 02:24 UTC #1 lore raw

Hi Kristen,

Quoted 11 lines

I started tested the PPP code and run into a simple crash when not providing username and password. This should be possible.
Program terminated with signal 11, Segmentation fault.
#0 0x0000003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6
(gdb) bt
#0 0x0000003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6
#1 0x000000000040ca9b in chap_process_challenge (priv=0x15a6bf0, new_packet=0x15a5164 "\001\001")
at gatchat/ppp_auth.c:86
#2 chap_process_packet (priv=0x15a6bf0, new_packet=0x15a5164 "\001\001") at gatchat/ppp_auth.c:143 #3 0x000000000040a66f in ppp_recv (channel=<value optimized out>, cond=<value optimized out>, data=0x15a6d50)

Quoted 7 lines

    at gatchat/ppp.c:205
#4  ppp_feed (channel=<value optimized out>, cond=<value optimized out>, data=0x15a6d50) at gatchat/ppp.c:286
#5  ppp_cb (channel=<value optimized out>, cond=<value optimized out>, data=0x15a6d50) at gatchat/ppp.c:340
#6  0x0000003598a3923e in g_main_context_dispatch () from /lib64/libglib-2.0.so.0
#7  0x0000003598a3cc28 in ?? () from /lib64/libglib-2.0.so.0
#8  0x0000003598a3d075 in g_main_loop_run () from /lib64/libglib-2.0.so.0
#9  0x0000000000403918 in main (argc=1, argv=0x7fff7b97eb28) at gatchat/gsmdial.c:624

your patches haven't fixed this yet.

Core was generated by `./gatchat/gsmdial -n /dev/ttyUSB0 -c 1 -a internet.com -l -P'. Program terminated with signal 11, Segmentation fault.
#0 __strlen_sse2 () at ../sysdeps/x86_64/strlen.S:31
31 pcmpeqb (%rdi), %xmm2
(gdb) bt
#0 __strlen_sse2 () at ../sysdeps/x86_64/strlen.S:31
#1 0x000000000040d13b in chap_process_challenge (priv=0x211aba0, new_packet=0x2119b7c "\001\001")
at gatchat/ppp_auth.c:86
#2 chap_process_packet (priv=0x211aba0, new_packet=0x2119b7c "\001\001") at gatchat/ppp_auth.c:143 #3 0x000000000040a94e in ppp_recv (channel=<value optimized out>, cond=<value optimized out>, data=0x211bab0)

    at gatchat/ppp.c:210
#4  ppp_feed (channel=<value optimized out>, cond=<value optimized out>, data=0x211bab0) at gatchat/ppp.c:295
#5  ppp_cb (channel=<value optimized out>, cond=<value optimized out>, data=0x211bab0) at gatchat/ppp.c:347
#6  0x0000003598a3923e in g_main_dispatch (context=0x2118160) at gmain.c:1960
#7  IA__g_main_context_dispatch (context=0x2118160) at gmain.c:2513
#8  0x0000003598a3cc28 in g_main_context_iterate (context=0x2118160, block=<value optimized out>,

dispatch=<value optimized out>, self=<value optimized out>) at gmain.c:2591
#9 0x0000003598a3d075 in IA__g_main_loop_run (loop=0x21183b0) at gmain.c:2799 #10 0x0000000000403a25 in main (argc=1, argv=0x7fffa4947bf8) at gatchat/gsmdial.c:679

Regards

Marcel

Kristen Carlson Accardi

2010-03-27 04:36 UTC #2 lore raw

Quoted 39 lines · On Fri, 26 Mar 2010 19:24:46 -0700 Marcel Holtmann <[email protected]> wrote:

Hi Kristen,
Quoted 11 lines
I started tested the PPP code and run into a simple crash when not providing username and password. This should be possible.
Program terminated with signal 11, Segmentation fault.
#0 0x0000003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6
(gdb) bt
#0 0x0000003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6
#1 0x000000000040ca9b in chap_process_challenge (priv=0x15a6bf0, new_packet=0x15a5164 "\001\001")
at gatchat/ppp_auth.c:86
#2 chap_process_packet (priv=0x15a6bf0, new_packet=0x15a5164 "\001\001") at gatchat/ppp_auth.c:143 #3 0x000000000040a66f in ppp_recv (channel=<value optimized out>, cond=<value optimized out>, data=0x15a6d50)
Quoted 7 lines
    at gatchat/ppp.c:205
#4  ppp_feed (channel=<value optimized out>, cond=<value optimized out>, data=0x15a6d50) at gatchat/ppp.c:286
#5  ppp_cb (channel=<value optimized out>, cond=<value optimized out>, data=0x15a6d50) at gatchat/ppp.c:340
#6  0x0000003598a3923e in g_main_context_dispatch () from /lib64/libglib-2.0.so.0
#7  0x0000003598a3cc28 in ?? () from /lib64/libglib-2.0.so.0
#8  0x0000003598a3d075 in g_main_loop_run () from /lib64/libglib-2.0.so.0
#9  0x0000000000403918 in main (argc=1, argv=0x7fff7b97eb28) at gatchat/gsmdial.c:624
your patches haven't fixed this yet.
Core was generated by `./gatchat/gsmdial -n /dev/ttyUSB0 -c 1 -a internet.com -l -P'. Program terminated with signal 11, Segmentation fault.
#0 __strlen_sse2 () at ../sysdeps/x86_64/strlen.S:31
31 pcmpeqb (%rdi), %xmm2
(gdb) bt
#0 __strlen_sse2 () at ../sysdeps/x86_64/strlen.S:31
#1 0x000000000040d13b in chap_process_challenge (priv=0x211aba0, new_packet=0x2119b7c "\001\001")
at gatchat/ppp_auth.c:86
#2 chap_process_packet (priv=0x211aba0, new_packet=0x2119b7c "\001\001") at gatchat/ppp_auth.c:143 #3 0x000000000040a94e in ppp_recv (channel=<value optimized out>, cond=<value optimized out>, data=0x211bab0)
    at gatchat/ppp.c:210
#4  ppp_feed (channel=<value optimized out>, cond=<value optimized out>, data=0x211bab0) at gatchat/ppp.c:295
#5  ppp_cb (channel=<value optimized out>, cond=<value optimized out>, data=0x211bab0) at gatchat/ppp.c:347
#6  0x0000003598a3923e in g_main_dispatch (context=0x2118160) at gmain.c:1960
#7  IA__g_main_context_dispatch (context=0x2118160) at gmain.c:2513
#8  0x0000003598a3cc28 in g_main_context_iterate (context=0x2118160, block=<value optimized out>, 

Quoted 7 lines

dispatch=<value optimized out>, self=<value optimized out>) at gmain.c:2591
#9 0x0000003598a3d075 in IA__g_main_loop_run (loop=0x21183b0) at gmain.c:2799 #10 0x0000000000403a25 in main (argc=1, argv=0x7fffa4947bf8) at gatchat/gsmdial.c:679
Regards
Marcel

I notice that you finally applied my patch to allow the empty secrets. Are you still having a problem after applying that patch?

Marcel Holtmann

author

2010-03-27 06:01 UTC #3 lore raw

Hi Kristen,

Quoted 41 lines

Quoted 37 lines
Quoted 11 lines
I started tested the PPP code and run into a simple crash when not providing username and password. This should be possible.
Program terminated with signal 11, Segmentation fault.
#0 0x0000003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6
(gdb) bt
#0 0x0000003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6
#1 0x000000000040ca9b in chap_process_challenge (priv=0x15a6bf0, new_packet=0x15a5164 "\001\001")
at gatchat/ppp_auth.c:86
#2 chap_process_packet (priv=0x15a6bf0, new_packet=0x15a5164 "\001\001") at gatchat/ppp_auth.c:143 #3 0x000000000040a66f in ppp_recv (channel=<value optimized out>, cond=<value optimized out>, data=0x15a6d50)
Quoted 7 lines
    at gatchat/ppp.c:205
#4  ppp_feed (channel=<value optimized out>, cond=<value optimized out>, data=0x15a6d50) at gatchat/ppp.c:286
#5  ppp_cb (channel=<value optimized out>, cond=<value optimized out>, data=0x15a6d50) at gatchat/ppp.c:340
#6  0x0000003598a3923e in g_main_context_dispatch () from /lib64/libglib-2.0.so.0
#7  0x0000003598a3cc28 in ?? () from /lib64/libglib-2.0.so.0
#8  0x0000003598a3d075 in g_main_loop_run () from /lib64/libglib-2.0.so.0
#9  0x0000000000403918 in main (argc=1, argv=0x7fff7b97eb28) at gatchat/gsmdial.c:624
your patches haven't fixed this yet.
Core was generated by `./gatchat/gsmdial -n /dev/ttyUSB0 -c 1 -a internet.com -l -P'. Program terminated with signal 11, Segmentation fault.
#0 __strlen_sse2 () at ../sysdeps/x86_64/strlen.S:31
31 pcmpeqb (%rdi), %xmm2
(gdb) bt
#0 __strlen_sse2 () at ../sysdeps/x86_64/strlen.S:31
#1 0x000000000040d13b in chap_process_challenge (priv=0x211aba0, new_packet=0x2119b7c "\001\001")
at gatchat/ppp_auth.c:86
#2 chap_process_packet (priv=0x211aba0, new_packet=0x2119b7c "\001\001") at gatchat/ppp_auth.c:143 #3 0x000000000040a94e in ppp_recv (channel=<value optimized out>, cond=<value optimized out>, data=0x211bab0)
    at gatchat/ppp.c:210
#4  ppp_feed (channel=<value optimized out>, cond=<value optimized out>, data=0x211bab0) at gatchat/ppp.c:295
#5  ppp_cb (channel=<value optimized out>, cond=<value optimized out>, data=0x211bab0) at gatchat/ppp.c:347
#6  0x0000003598a3923e in g_main_dispatch (context=0x2118160) at gmain.c:1960
#7  IA__g_main_context_dispatch (context=0x2118160) at gmain.c:2513
#8  0x0000003598a3cc28 in g_main_context_iterate (context=0x2118160, block=<value optimized out>, 
Quoted 3 lines
dispatch=<value optimized out>, self=<value optimized out>) at gmain.c:2591
#9 0x0000003598a3d075 in IA__g_main_loop_run (loop=0x21183b0) at gmain.c:2799 #10 0x0000000000403a25 in main (argc=1, argv=0x7fffa4947bf8) at gatchat/gsmdial.c:679

Quoted 2 lines

I notice that you finally applied my patch to allow the empty secrets. Are you still having a problem after applying that patch?

actually it never made it to me. I was missing patch 1/2 from your one submission. That is why I asked you to re-send it. In the end I started going through the code and fixed it by myself.

Regards

Marcel