Add comile time settings from ./configure information to --version
PATCH 1/1 Add comile time settings from ./configure information to --version
This patch will create ./configure.h which will contain two new #define strings. CONFIGURE_DEFINES will contain all USE, ENABLED, DISABLED and DEPRECATED defines from ./config.h. CONFIGURE_CALL will contain the complete ./configure line which was used when configuring the package for building.
--- Makefile.am | 7 +++++++ configure_h.awk | 39 +++++++++++++++++++++++++++++++++++++++ configure_log.awk | 36 ++++++++++++++++++++++++++++++++++++ options.c | 3 +++ 4 files changed, 85 insertions(+), 0 deletions(-) create mode 100644 configure_h.awk create mode 100644 configure_log.awk
Makefile.am +7 -0
@@ -6,6 +6,7 @@ # packet compression. # # Copyright (C) 2002-2009 OpenVPN Technologies, Inc. <[email protected]...> +# Copyright (C) 2010 David Sommerseth <[email protected]...> # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License version 2
@@ -141,6 +142,12 @@ openvpn_SOURCES = \ cryptoapi.h cryptoapi.c \ deprecated.h deprecated.c +configure.h: Makefile + awk -f configure_h.awk config.h > $@ + awk -f configure_log.awk config.log >> $@ + +clean-local: + -rm -f configure.h dist-hook: cd $(distdir) && for i in $(EXTRA_DIST) $(SUBDIRS) ; do find $$i -name .svn -type d -prune -exec rm -rf '{}' ';' ; rm -f `find $$i -type f | grep -E '(^|\/)\.?\#|\~$$|\.s?o$$'` ; done
configure_h.awk new file +39 -0
@@ -0,0 +1,39 @@ +# +# OpenVPN -- An application to securely tunnel IP networks +# over a single UDP port, with support for SSL/TLS-based +# session authentication and key exchange, +# packet encryption, packet authentication, and +# packet compression. +# +# Copyright (C) 2010 David Sommerseth <[email protected]...> +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License version 2 +# as published by the Free Software Foundation. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program (see the file COPYING included with this +# distribution); if not, write to the Free Software Foundation, Inc., +# 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +# +# +# This script will build up a line which can be included into a C program. +# The line will contain all interesting #define statements from f.ex. ./config.h +# + +BEGIN { + printf ("#define CONFIGURE_DEFINES \"") +} + +/^#define (ENABLE|DISABLE|DEPRECATED|USE)_/ { + printf (" %s", $2) +} + +END { + printf ("\"\n") +}
configure_log.awk new file +36 -0
@@ -0,0 +1,36 @@ +# +# OpenVPN -- An application to securely tunnel IP networks +# over a single UDP port, with support for SSL/TLS-based +# session authentication and key exchange, +# packet encryption, packet authentication, and +# packet compression. +# +# Copyright (C) 2010 David Sommerseth <[email protected]...> +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License version 2 +# as published by the Free Software Foundation. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program (see the file COPYING included with this +# distribution); if not, write to the Free Software Foundation, Inc., +# 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA +# +# +# This script will build up a line which can be included into a C program. +# The line will only contain the first entry of the ./configure line from +# ./config.log. +# + +BEGIN { + printf ("#define CONFIGURE_CALL \"") +} +/\$ .\/configure/ { + print $0,"\"" + exit 0 +}
options.c +3 -0
@@ -48,6 +48,7 @@#include "pool.h" #include "helper.h" #include "manage.h" +#include "configure.h" #include "memdbg.h"
@@ -2950,6 +2951,8 @@ usage_version (void)msg (M_INFO |M_NOPREFIX ,"%s" , title_string);msg (M_INFO |M_NOPREFIX ,"Originally developed by James Yonan" );msg (M_INFO |M_NOPREFIX ,"Copyright (C) 2002-2009 OpenVPN Technologies, Inc. <[email protected]...>" ); +msg (M_INFO |M_NOPREFIX ,"\n%s\n" ,CONFIGURE_CALL ); +msg (M_INFO |M_NOPREFIX ,"Compile time defines: %s" ,CONFIGURE_DEFINES );openvpn_exit (OPENVPN_EXIT_STATUS_USAGE );/* exit point */ }
Signature · 1 line
1.6.6.1
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 7 lines · David Sommerseth
This patch will create ./configure.h which will contain two new #define strings.
CONFIGURE_DEFINESwill contain all USE, ENABLED, DISABLED and DEPRECATED defines from ./config.h.CONFIGURE_CALLwill contain the complete ./configure line which was used when configuring the package for building.Signed-off-by David Sommerseth <[email protected]...>
Quoted 8 lines
--- Makefile.am | 7 +++++++ configure_h.awk | 39 +++++++++++++++++++++++++++++++++++++++ configure_log.awk | 36 ++++++++++++++++++++++++++++++++++++ options.c | 3 +++ 4 files changed, 85 insertions(+), 0 deletions(-) create mode 100644 configure_h.awk create mode 100644 configure_log.awk
Applied to the openvpn-testing.git feat_misc branch. To be merged into allmerged soon.
Commit f27bf509315a48b0070294c3993a718df0c2626c
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAku+MgUACgkQDC186MBRfrrSTQCfZcZ1BbzdmGO7GwKhwMRyYfd3 f90AnieGGtEskxG+E5Ng/AxjwnL++6k6
=qKP1
-----END PGP SIGNATURE-----
Highly none standard autotools usage.
Also requires awk which may not be available.
Please REVERT.
Quoted 48 lines · David Sommerseth
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quoted 7 lines · David Sommerseth
This patch will create ./configure.h which will contain two new #define strings. CONFIGURE_DEFINES will contain all USE, ENABLED, DISABLED and DEPRECATED defines from ./config.h. CONFIGURE_CALL will contain the complete ./configure line which was used when configuring the package for building.
Signed-off-by David Sommerseth <[email protected]...>Quoted 8 lines
---
Makefile.am | 7 +++++++
configure_h.awk | 39 +++++++++++++++++++++++++++++++++++++++ configure_log.awk | 36 ++++++++++++++++++++++++++++++++++++options.c| 3 +++4 files changed, 85 insertions(+), 0 deletions(-)create mode 100644 configure_h.awk
create mode 100644 configure_log.awkApplied to the openvpn-testing.git
feat_miscbranch. To be merged into allmerged soon.
Commitf27bf509315a48b0070294c3993a718df0c2626ckind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/iEYEARECAAYFAku+MgUACgkQDC186MBRfrrSTQCfZcZ1BbzdmGO7GwKhwMRyYfd3 f90AnieGGtEskxG+E5Ng/AxjwnL++6k6
=qKP1
-----END PGP SIGNATURE-----------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Also there is no proper dependency for configure.h in Makefile.am so it won't be built.
Proper way to do so is like I done for OpenSC [1], look for OPENSC_FEATURES.
[1] http://www.opensc-project.org/opensc/browser/trunk/configure.ac#L613
Quoted 55 lines · Alon Bar-Lev
Highly none standard autotools usage.
Also requires awk which may not be available.
Please REVERT.Quoted 48 lines · David Sommerseth
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quoted 7 lines · David Sommerseth
This patch will create ./configure.h which will contain two new #define strings. CONFIGURE_DEFINES will contain all USE, ENABLED, DISABLED and DEPRECATED defines from ./config.h. CONFIGURE_CALL will contain the complete ./configure line which was used when configuring the package for building.
Signed-off-by David Sommerseth <[email protected]...>Quoted 8 lines
---
Makefile.am | 7 +++++++
configure_h.awk | 39 +++++++++++++++++++++++++++++++++++++++ configure_log.awk | 36 ++++++++++++++++++++++++++++++++++++options.c| 3 +++4 files changed, 85 insertions(+), 0 deletions(-)create mode 100644 configure_h.awk
create mode 100644 configure_log.awkApplied to the openvpn-testing.git
feat_miscbranch. To be merged into allmerged soon.
Commitf27bf509315a48b0070294c3993a718df0c2626ckind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/iEYEARECAAYFAku+MgUACgkQDC186MBRfrrSTQCfZcZ1BbzdmGO7GwKhwMRyYfd3 f90AnieGGtEskxG+E5Ng/AxjwnL++6k6
=qKP1
-----END PGP SIGNATURE-----------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH] Add comile time settings from ./configure to --version
Quoted 5 lines · Alon Bar-Lev
Also there is no proper dependency for
configure.hin Makefile.am so it won't be built.
Proper way to do so is like I done for OpenSC [1], look forOPENSC_FEATURES.[1] http://www.opensc-project.org/opensc/browser/trunk/configure.ac#L613
Thank you for catching this one. I've obviously been too sloppy with 'make distcheck', which would have detected this one.
Even though I see you build up a string in configure.ac with enabled features in your example [1], I personally feel that approach is less flexible. When this feature was implemented I considered that approach as well, but I found it would require much more changes to configure.ac.
It would also make it possible to skip listing enabled features, just
by forgetting to add the feature to the feature list.
The awk approach has the advantage of dynamically building up a list of features found in ./config.h. And in addition, the current implementation also show which arguments was used with ./configure.
I've attached three patches, which cleans up this feature further.
kind regards,
David Sommerseth
Quoted 24 lines · Alon Bar-Lev
Quoted 6 lines
Highly none standard autotools usage.
Also requires awk which may not be available.
Please REVERT.On Thu, Apr 8, 2010 at 10:44 PM, David Sommerseth
<[email protected]...> wrote:Quoted 6 lines · David Sommerseth
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
This patch will create ./configure.h which will contain two new #define strings.
CONFIGURE_DEFINESwill contain all USE, ENABLED, DISABLED and DEPRECATED defines from ./config.h.CONFIGURE_CALLwill contain the complete ./configure line which was used when configuring the package for building.Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Signed-off-by David Sommerseth <[email protected]...>--- Makefile.am | 7 +++++++ configure_h.awk | 39 +++++++++++++++++++++++++++++++++++++++ configure_log.awk | 36 ++++++++++++++++++++++++++++++++++++ options.c | 3 +++ 4 files changed, 85 insertions(+), 0 deletions(-) create mode 100644 configure_h.awk create mode 100644 configure_log.awk
Quoted 9 lines
Applied to the openvpn-testing.git
feat_miscbranch. To be merged into allmerged soon.
Commitf27bf509315a48b0070294c3993a718df0c2626ckind regards,
David Sommerseth
Quoted 1 line
Quoted 1 line
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Quoted 2 lines
Quoted 2 lines
Quoted 1 line
From c8b840a50a64dfd03bec3a7ed3beb486c3a55f90 Mon Sep 17 00:00:00 2001
From: David Sommerseth <[email protected]...>
Date: Tue, 13 Apr 2010 15:07:51 +0200
Subject: [PATCH 1/3] Fix dependency checking for configure.h
Alon Bar-Lev indicated commit f27bf509315a48b0070294c3993a718df0c2626c was missing proper dependency checking. This patch corrects this and fixes an issue when creating configure.h via make distcheck.
--- Makefile.am | 10 +++++++--- configure_log.awk | 8 ++++++-- 2 files changed, 13 insertions(+), 5 deletions(-)
Makefile.am +7 -3
@@ -66,7 +66,8 @@ dist_noinst_SCRIPTS = \ $(TESTS) \ doclean \ domake-win \ - t_cltsrv-down.sh + t_cltsrv-down.sh \ + configure_h.awk configure_log.awk dist_noinst_DATA = \ openvpn.spec \
@@ -141,9 +142,12 @@ openvpn_SOURCES = \ win32.h win32.c \ cryptoapi.h cryptoapi.c +nodist_openvpn_SOURCES = configure.h +options.$(OBJEXT): configure.h + configure.h: Makefile - awk -f configure_h.awk config.h > $@ - awk -f configure_log.awk config.log >> $@ + awk -f $(srcdir)/configure_h.awk config.h > $@ + awk -f $(srcdir)/configure_log.awk config.log >> $@ clean-local: -rm -f configure.h
configure_log.awk +6 -2
@@ -30,7 +30,11 @@ BEGIN { printf ("#define CONFIGURE_CALL \"") } -/\$ .\/configure/ { - print $0,"\"" +/\$ (.).\/configure/ { + printf ("%s", $0) exit 0 } + +END { + printf ("\"\n") +}
Signature · 1 line
1.6.6.1
From a260aa387846e6f12db58d120e1d61ce4732b30e Mon Sep 17 00:00:00 2001
From: David Sommerseth <[email protected]...>
Date: Tue, 13 Apr 2010 15:12:27 +0200
Subject: [PATCH 2/3] Make use of automake CLEANFILES variable instead of clean-local rule
--- Makefile.am | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
Makefile.am +1 -4
@@ -38,7 +38,7 @@ MAINTAINERCLEANFILES = \ $(srcdir)/depcomp $(srcdir)/aclocal.m4 \ $(srcdir)/config.guess $(srcdir)/config.sub \ $(srcdir)/config-win32.h $(srcdir)/openvpn.spec -CLEANFILES = openvpn.8.html +CLEANFILES = openvpn.8.html configure.h EXTRA_DIST = \ easy-rsa \
@@ -149,9 +149,6 @@ configure.h: Makefile awk -f $(srcdir)/configure_h.awk config.h > $@ awk -f $(srcdir)/configure_log.awk config.log >> $@ -clean-local: - -rm -f configure.h - dist-hook: cd $(distdir) && for i in $(EXTRA_DIST) $(SUBDIRS) ; do find $$i -name .svn -type d -prune -exec rm -rf '{}' ';' ; rm -f `find $$i -type f | grep -E '(^|\/)\.?\#|\~$$|\.s?o$$'` ; done
Signature · 1 line
1.6.6.1
From d940d655fd489ae1ec37ed7d4eabbdafb69fd6ca Mon Sep 17 00:00:00 2001
From: David Sommerseth <[email protected]...>
Date: Tue, 13 Apr 2010 15:20:56 +0200
Subject: [PATCH 3/3] Don't add compile time information if --enable-small is used
This is to satisfy those wanting to build openvpn for embedded devices where every bytes matters.
--- options.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
options.c +2 -0
@@ -2752,8 +2752,10 @@ usage_version (void)msg (M_INFO |M_NOPREFIX ,"%s" , title_string);msg (M_INFO |M_NOPREFIX ,"Originally developed by James Yonan" );msg (M_INFO |M_NOPREFIX ,"Copyright (C) 2002-2009 OpenVPN Technologies, Inc. <[email protected]...>" ); +#ifndef ENABLE_SMALL msg (M_INFO |M_NOPREFIX ,"\n%s\n" ,CONFIGURE_CALL );msg (M_INFO |M_NOPREFIX ,"Compile time defines: %s" ,CONFIGURE_DEFINES ); +#endif openvpn_exit (OPENVPN_EXIT_STATUS_USAGE );/* exit point */ }
Signature · 1 line
1.6.6.1
Re: [Openvpn-devel] [PATCH] Add comile time settings from ./configure to --version
Again,
Hacking the config.log is a hack, none documented structure that may change from one version to another.
You should not do this if yo care about backward/forward compatibility. Also analyzing config.h is inappropriate.
If you don't want to do this as I suggested you can write m4 macro such as:
AC_DEFUN([MY_AC_ARG_WITH],[
AC_ARG_WITH([$1],[$2],[$3],[$4])
---- do something ----
])
This will enable you to do some procedural work without using hacks.
Quoted 76 lines · David Sommerseth
Quoted 5 lines · Alon Bar-Lev
Also there is no proper dependency for
configure.hin Makefile.am so it won't be built.
Proper way to do so is like I done for OpenSC [1], look forOPENSC_FEATURES.[1] http://www.opensc-project.org/opensc/browser/trunk/configure.ac#L613
Thank you for catching this one. I've obviously been too sloppy with 'make distcheck', which would have detected this one.
Even though I see you build up a string in configure.ac with enabled features in your example [1], I personally feel that approach is less flexible. When this feature was implemented I considered that approach as well, but I found it would require much more changes to configure.ac. It would also make it possible to skip listing enabled features, just by forgetting to add the feature to the feature list.
The awk approach has the advantage of dynamically building up a list of features found in ./config.h. And in addition, the current implementation also show which arguments was used with ./configure.
I've attached three patches, which cleans up this feature further.
kind regards,
David Sommerseth
Quoted 24 lines · Alon Bar-Lev
Quoted 6 lines
Highly none standard autotools usage.
Also requires awk which may not be available.
Please REVERT.On Thu, Apr 8, 2010 at 10:44 PM, David Sommerseth
<[email protected]...> wrote:Quoted 6 lines · David Sommerseth
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
This patch will create ./configure.h which will contain two new #define strings. CONFIGURE_DEFINES will contain all USE, ENABLED, DISABLED and DEPRECATED defines from ./config.h. CONFIGURE_CALL will contain the complete ./configure line which was used when configuring the package for building.
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Signed-off-by David Sommerseth <[email protected]...>---
Makefile.am | 7 +++++++
configure_h.awk | 39 +++++++++++++++++++++++++++++++++++++++ configure_log.awk | 36 ++++++++++++++++++++++++++++++++++++options.c| 3 +++4 files changed, 85 insertions(+), 0 deletions(-)create mode 100644 configure_h.awk
create mode 100644 configure_log.awkQuoted 9 lines
Applied to the openvpn-testing.git
feat_miscbranch. To be merged into allmerged soon.
Commitf27bf509315a48b0070294c3993a718df0c2626ckind regards,
David Sommerseth
Quoted 1 line
Quoted 1 line
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-develQuoted 2 lines
Quoted 2 lines
Quoted 1 line
Re: [Openvpn-devel] [PATCH] Add comile time settings from ./configure to --version
In reply to David Sommerseth-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 13/04/10 15:49, David Sommerseth wrote:
[...snip...]
Quoted 3 lines
I've attached three patches, which cleans up this feature further.
This is an enhanced patch, based on review comments from Gert Doering. He mentioned that the configure_log.awk could be made a bit more "understandable". I've done some minor adjustments to improve that, also for people not too much acquainted with awk. It is also made safer to if the needed information is not found in config.log.
Patch attached.
kind regards,
David Sommerseth
- ---
Makefile.am | 10 +++++++--- configure_log.awk | 7 ++----- options.c | 2 ++ 3 files changed, 11 insertions(+), 8 deletions(-)
Quoted 57 lines
Quoted 24 lines · Alon Bar-Lev
Quoted 6 lines
Highly none standard autotools usage.
Also requires awk which may not be available.
Please REVERT.On Thu, Apr 8, 2010 at 10:44 PM, David Sommerseth
<[email protected]...> wrote:Quoted 6 lines · David Sommerseth
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
This patch will create ./configure.h which will contain two new #define strings.
CONFIGURE_DEFINESwill contain all USE, ENABLED, DISABLED and DEPRECATED defines from ./config.h.CONFIGURE_CALLwill contain the complete ./configure line which was used when configuring the package for building.Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Signed-off-by David Sommerseth <[email protected]...>--- Makefile.am | 7 +++++++ configure_h.awk | 39 +++++++++++++++++++++++++++++++++++++++ configure_log.awk | 36 ++++++++++++++++++++++++++++++++++++ options.c | 3 +++ 4 files changed, 85 insertions(+), 0 deletions(-) create mode 100644 configure_h.awk create mode 100644 configure_log.awkQuoted 9 lines
Applied to the openvpn-testing.git
feat_miscbranch. To be merged into allmerged soon.
Commitf27bf509315a48b0070294c3993a718df0c2626ckind regards,
David Sommerseth
Quoted 1 line
Quoted 1 line
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-develQuoted 2 lines
Quoted 2 lines
Quoted 1 line
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
Quoted 4 lines
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkvQZIkACgkQDC186MBRfrq3RgCeKFbqnn4ApvAvFxCkT1daedj/ vr0An0gRtTyhZJUZFQDpo3taFJ4o7pB2
=wWpo
-----END PGP SIGNATURE-----
From 239ed4ed97d12997a552524f30d81a88ec8b231b Mon Sep 17 00:00:00 2001
From: David Sommerseth <[email protected]...>
Date: Thu, 22 Apr 2010 16:08:34 +0200
Subject: [PATCH 1/3] Fix dependency checking for configure.h (v2)
Alon Bar-Lev indicated commit f27bf509315a48b0070294c3993a718df0c2626c was missing proper dependency checking. This patch corrects this and fixes an issue when creating configure.h via make distcheck.
This is an enhanced version of the one sent to the openvpn-devel mailing list April 13, 2010 [1], after having received some feedback from Gert Doering, cleaning up configure_log.awk further.
[1] <http://thread.gmane.org/gmane.network.openvpn.devel/3410/focus=3491>
--- Makefile.am | 10 +++++++--- configure_log.awk | 7 ++----- options.c | 2 ++ 3 files changed, 11 insertions(+), 8 deletions(-)
Makefile.am +7 -3
@@ -66,7 +66,8 @@ dist_noinst_SCRIPTS = \ $(TESTS) \ doclean \ domake-win \ - t_cltsrv-down.sh + t_cltsrv-down.sh \ + configure_h.awk configure_log.awk dist_noinst_DATA = \ openvpn.spec \
@@ -141,9 +142,12 @@ openvpn_SOURCES = \ win32.h win32.c \ cryptoapi.h cryptoapi.c +nodist_openvpn_SOURCES = configure.h +options.$(OBJEXT): configure.h + configure.h: Makefile - awk -f configure_h.awk config.h > $@ - awk -f configure_log.awk config.log >> $@ + awk -f $(srcdir)/configure_h.awk config.h > $@ + awk -f $(srcdir)/configure_log.awk config.log >> $@ clean-local: -rm -f configure.h
configure_log.awk +2 -5
@@ -27,10 +27,7 @@ # ./config.log. # -BEGIN { - printf ("#define CONFIGURE_CALL \"") -} -/\$ .\/configure/ { - print $0,"\"" +/\$ (.*)\/configure/ { + printf ("#define CONFIGURE_CALL \"%s\"\n", $0) exit 0 }
options.c +2 -0
@@ -2752,7 +2752,9 @@ usage_version (void)msg (M_INFO |M_NOPREFIX ,"%s" , title_string);msg (M_INFO |M_NOPREFIX ,"Originally developed by James Yonan" );msg (M_INFO |M_NOPREFIX ,"Copyright (C) 2002-2009 OpenVPN Technologies, Inc. <[email protected]...>" ); +#ifdef CONFIGURE_CALL msg (M_INFO |M_NOPREFIX ,"\n%s\n" ,CONFIGURE_CALL ); +#endif msg (M_INFO |M_NOPREFIX ,"Compile time defines: %s" ,CONFIGURE_DEFINES );openvpn_exit (OPENVPN_EXIT_STATUS_USAGE );/* exit point */ }
Signature · 1 line
1.6.6.1
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 3 lines · Alon Bar-Lev
Highly none standard autotools usage.
Also requires awk which may not be available.
Please REVERT.
First of all, let's bring in the history. This feature was discussed in the weekly meeting February 26, 2010. See the chat log at [1], around the time stamp 20:45:15.
This patch-set provides one way of doing this, and it is a requested feature. There are probably several ways how to solve this, this is one way - and it might not be the best way. However, it is what we got right now.
Alon, with all respect, it is great getting feedbacks to submitted patches, even REVERT suggestions. Could you perhaps share some thoughts about how to solve it, instead of just rejecting it?
For now, this patch-set is only in feat_misc branch. I've halted the merge into allmerged for now. But unless we can get a better solution (meaning: new patches with enhancements) to this feature within reasonable time, this is how it will look like. The initial patch is already ready and accepted. I am willing to drop using awk or whatever else, as long as we do get this feature. How the feature is implemented is less important.
But this feature will be important for us when we begin to receive feedbacks on the openvpn-testing version.
kind regards,
David Sommerseth
[1] <http://thread.gmane.org/gmane.network.openvpn.devel/3143>
Quoted 19 lines
On Thu, Apr 8, 2010 at 10:44 PM, David Sommerseth
<[email protected]...> wrote:Quoted 6 lines · David Sommerseth
Quoted 6 lines
Quoted 6 lines
This patch will create ./configure.h which will contain two new #define strings.
CONFIGURE_DEFINESwill contain all USE, ENABLED, DISABLED and DEPRECATED defines from ./config.h.CONFIGURE_CALLwill contain the complete ./configure line which was used when configuring the package for building.Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Signed-off-by David Sommerseth <[email protected]...>--- Makefile.am | 7 +++++++ configure_h.awk | 39 +++++++++++++++++++++++++++++++++++++++ configure_log.awk | 36 ++++++++++++++++++++++++++++++++++++ options.c | 3 +++ 4 files changed, 85 insertions(+), 0 deletions(-) create mode 100644 configure_h.awk create mode 100644 configure_log.awk
Quoted 9 lines
Applied to the openvpn-testing.git
feat_miscbranch. To be merged into allmerged soon.
Commitf27bf509315a48b0070294c3993a718df0c2626ckind regards,
David Sommerseth
Quoted 1 line
-
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Quoted 1 line
Quoted 1 line
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkvEdlIACgkQDC186MBRfrrimwCfYMO4m2CuY1KPNkLAtHFqL+pr dqYAn3T0jEowiV9NQZ+8H3onrH+JFb1B
=qAhn
-----END PGP SIGNATURE-----
Quoted 11 lines · David Sommerseth
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quoted 3 lines · Alon Bar-Lev
Highly none standard autotools usage.
Also requires awk which may not be available.
Please REVERT.First of all, let's bring in the history. This feature was discussed in the weekly meeting February 26, 2010. See the chat log at [1], around the time stamp 20:45:15.
David, IRC is not a development tool, it is sync tool that require all to be available at the same time, which is never the case. I don't understand why you took this approach, but its down-side is that people discover such commits later on.
Quoted 4 lines
This patch-set provides one way of doing this, and it is a requested feature. There are probably several ways how to solve this, this is one way - and it might not be the best way. However, it is what we got right now.
But the knowledge of autotools is not at your disposal.
Quoted 3 lines
Alon, with all respect, it is great getting feedbacks to submitted patches, even REVERT suggestions. Could you perhaps share some thoughts about how to solve it, instead of just rejecting it?
I did.
I sent you an example of how we solve it in OpenSC and Suspend.
http://www.opensc-project.org/opensc/browser/trunk/configure.ac#L613
autoconf log was NEVER intended to be used as programming interface, and is far than being stable.
Quoted 10 lines
For now, this patch-set is only in
feat_miscbranch. I've halted the merge into allmerged for now. But unless we can get a better solution (meaning: new patches with enhancements) to this feature within reasonable time, this is how it will look like. The initial patch is already ready and accepted. I am willing to drop using awk or whatever else, as long as we do get this feature. How the feature is implemented is less important.But this feature will be important for us when we begin to receive feedbacks on the openvpn-testing version.
I understand the need, but reject the miss-use of autoconf resources. In order to be compatible with as many environment as you can, you cannot use hacks and undocumented approaches.
Quoted 60 lines
kind regards,
David Sommerseth
[1] <http://thread.gmane.org/gmane.network.openvpn.devel/3143>
Quoted 19 lines
On Thu, Apr 8, 2010 at 10:44 PM, David Sommerseth
<[email protected]...> wrote:Quoted 6 lines · David Sommerseth
Quoted 6 lines
Quoted 6 lines
This patch will create ./configure.h which will contain two new #define strings. CONFIGURE_DEFINES will contain all USE, ENABLED, DISABLED and DEPRECATED defines from ./config.h. CONFIGURE_CALL will contain the complete ./configure line which was used when configuring the package for building.
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Signed-off-by David Sommerseth <[email protected]...>---
Makefile.am | 7 +++++++
configure_h.awk | 39 +++++++++++++++++++++++++++++++++++++++ configure_log.awk | 36 ++++++++++++++++++++++++++++++++++++options.c| 3 +++4 files changed, 85 insertions(+), 0 deletions(-)create mode 100644 configure_h.awk
create mode 100644 configure_log.awkQuoted 9 lines
Applied to the openvpn-testing.git
feat_miscbranch. To be merged into allmerged soon.
Commitf27bf509315a48b0070294c3993a718df0c2626ckind regards,
David Sommerseth
Quoted 1 line
-
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Openvpn-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-develQuoted 1 line
Quoted 1 line
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/iEYEARECAAYFAkvEdlIACgkQDC186MBRfrrimwCfYMO4m2CuY1KPNkLAtHFqL+pr dqYAn3T0jEowiV9NQZ+8H3onrH+JFb1B
=qAhn
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 10 lines · Alon Bar-Lev
Quoted 3 lines
Alon, with all respect, it is great getting feedbacks to submitted
Quoted 2 lines
patches, even REVERT suggestions. Could you perhaps share some thoughts about how to solve it, instead of just rejecting it?
I did.
I sent you an example of how we solve it in OpenSC and Suspend.http://www.opensc-project.org/opensc/browser/trunk/configure.ac#L613
autoconf log was NEVER intended to be used as programming interface, and is far than being stable.
I feel you oversee something. The configure_h.awk script uses config.h, which is included in most of the C files already.
The config.log is *only* used for getting the command line of how ./configure was called, via configure_log.awk. To my knowledge, this information is not available anywhere else. If I have overseen this somewhere, then please enlighten me.
The config.log is also not used as a programming interface. One static, configure time related line is *extracted* and compiled into the binary.
This is extraction of useful debug information for situation where the
openvpn-testing code is distributed in binary.
If this configure line is not found, an empty string will be the result, so no openvpn features are harmed. With the clean-up patches, it will now also compile without any issues. And to my knowledge config.log does not change after Make begins to compile the source code.
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkvEgZQACgkQDC186MBRfrrMXACgjWOB2de9DITHjyoXQJYFEhuk DpoAmwcqCjnPttfxzw9VoNOBv0nknM5g
=Ciw2
-----END PGP SIGNATURE-----
As you wish.
Quoted 46 lines · David Sommerseth
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quoted 10 lines · Alon Bar-Lev
Quoted 3 lines
Alon, with all respect, it is great getting feedbacks to submitted
Quoted 2 lines
patches, even REVERT suggestions. Could you perhaps share some thoughts about how to solve it, instead of just rejecting it?
I did.
I sent you an example of how we solve it in OpenSC and Suspend.http://www.opensc-project.org/opensc/browser/trunk/configure.ac#L613
autoconf log was NEVER intended to be used as programming interface, and is far than being stable.
I feel you oversee something. The configure_h.awk script uses
config.h, which is included in most of the C files already.The config.log is *only* used for getting the command line of how ./configure was called, via configure_log.awk. To my knowledge, this information is not available anywhere else. If I have overseen this somewhere, then please enlighten me.
The config.log is also not used as a programming interface. One static, configure time related line is *extracted* and compiled into the binary. This is extraction of useful debug information for situation where the openvpn-testing code is distributed in binary.
If this configure line is not found, an empty string will be the result, so no openvpn features are harmed. With the clean-up patches, it will now also compile without any issues. And to my knowledge config.log does not change after Make begins to compile the source code.
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/iEYEARECAAYFAkvEgZQACgkQDC186MBRfrrMXACgjWOB2de9DITHjyoXQJYFEhuk DpoAmwcqCjnPttfxzw9VoNOBv0nknM5g
=Ciw2
-----END PGP SIGNATURE-----
Quoted 4 lines · On Tuesday 13 April 2010 16:37:13 David Sommerseth wrote:
The config.log is *only* used for getting the command line of how ./configure was called, via configure_log.awk. To my knowledge, this information is not available anywhere else. If I have overseen this somewhere, then please enlighten me.
Couldn't that be done in a much cleaner way by just using the $* shell variable?
Heiko
Signature · 7 lines
Heiko Hund | Software Engineer | Phone +49-721-25516-237 | Fax -200 Astaro AG | An der RaumFabrik 33a | 76227 Karlsruhe | Germany Executive Board: Markus Hennig, Jan Hichert, Günter Junk, Dr. Frank Nellissen Chairman of the Supervisory Board: Stanley J. Krasnow Headquarter Location: Karlsruhe Commercial Register: Mannheim HRB 108997
Quoted 10 lines
First of all, let's bring in the history. This feature was discussed in the weekly meeting February 26, 2010. See the chat log at [1], around the time stamp 20:45:15.
Quoted 4 lines
David, IRC is not a development tool, it is sync tool that require all to be available at the same time, which is never the case. I don't understand why you took this approach, but its down-side is that people discover such commits later on.
There are several good reasons why we do use IRC as a development tool. First, it's the best/only available way to get James' input into "testing" development. Second, many patches have fail to receive an ACK/NACK or even any comments in the mailing list discussions. It's this kind of patches which are discussed in the meetings and more often than not we've managed to get an ACK/NACK for them.
As you say, there are problems with using IRC as a development tool, timezones being one big problem. That's why after every meeting I send a summary to openvpn-devel which documents every single patch ACK/NACK. A full chatlog is also attached to this mail. To make sure the summaries & chatlogs don't get lost in mailing list archives, they are also linked to from here:
http://www.secure-computing.net/wiki/index.php/OpenVPN/IRC_meetings
The preliminary meeting agenda / topic list is also visible prior the meeting so that people can choose whether to attend or not (if they can).
However, I think there's definitely room for improvement. IRC is addictive, because it allows making decisions fast and easily. The downside is that not all people can attend the meetings and are thus unable to affect their outcome or provide valuable feedback. What we need to avoid is creating two classes of developers: those who can attend the IRC (and make the decisions) and those who can't (and don't decide).
As a concrete measure I suggest that patches ACK'd in IRC meetings should not be merged until, say, Monday. That way people can review the chatlog and if they don't like what they see, they can provide their comments. I think that we should from now on "propose" rather than "decide" to include patches based on IRC discussions. Otherwise people might get the wrong impression that we don't want/need further comments. I also suggest that we really focus on using IRC only when the mailing list discussions have led nowhere, not just for it's convenience.
What do you think?
Signature · 5 lines
Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock
2010/4/14 Samuli Seppänen <[email protected]...>:
Quoted 46 lines
Quoted 10 lines
First of all, let's bring in the history. This feature was discussed in the weekly meeting February 26, 2010. See the chat log at [1], around the time stamp 20:45:15.
Quoted 4 lines
David, IRC is not a development tool, it is sync tool that require all to be available at the same time, which is never the case. I don't understand why you took this approach, but its down-side is that people discover such commits later on.
There are several good reasons why we do use IRC as a development tool. First, it's the best/only available way to get James' input into "testing" development. Second, many patches have fail to receive an ACK/NACK or even any comments in the mailing list discussions. It's this kind of patches which are discussed in the meetings and more often than not we've managed to get an ACK/NACK for them.
As you say, there are problems with using IRC as a development tool, timezones being one big problem. That's why after every meeting I send a summary to openvpn-devel which documents every single patch ACK/NACK. A full chatlog is also attached to this mail. To make sure the summaries & chatlogs don't get lost in mailing list archives, they are also linked to from here:
http://www.secure-computing.net/wiki/index.php/OpenVPN/IRC_meetings
The preliminary meeting agenda / topic list is also visible prior the meeting so that people can choose whether to attend or not (if they can).
However, I think there's definitely room for improvement. IRC is addictive, because it allows making decisions fast and easily. The downside is that not all people can attend the meetings and are thus unable to affect their outcome or provide valuable feedback. What we need to avoid is creating two classes of developers: those who can attend the IRC (and make the decisions) and those who can't (and don't decide).
As a concrete measure I suggest that patches ACK'd in IRC meetings should not be merged until, say, Monday. That way people can review the chatlog and if they don't like what they see, they can provide their comments. I think that we should from now on "propose" rather than "decide" to include patches based on IRC discussions. Otherwise people might get the wrong impression that we don't want/need further comments. I also suggest that we really focus on using IRC only when the mailing list discussions have led nowhere, not just for it's convenience.
Quoted 1 line
What do you think?
I think that using IRC is much too chatty to begin with. Async communication is much complete and atomic.
Also, your summary contains so much unrelated issues that it is harder to track.
Proper mailing list management proved themselves for a long time, the LKML is a good example of such.
However, if you truly want to manage the change sets, install bugzilla [or any other *DECENT* tracker except trac], and follow change request from submittion to release.
This way you can track the full history of a single change, and not follow several meeting logs, mail messages and other means of discussion.
All relevant people [weather decision making or interest] may be CCed, also the devel mailing list can be CCed so outsider can track the status of changes.
Managing software is a complex task, the IRC session you conducting does not make it more organize/simpler/complete.
Regards,
Alon.
Alon Bar-Lev ha scritto:
Quoted 52 lines
2010/4/14 Samuli Seppänen <[email protected]...>:
Quoted 48 lines
Quoted 10 lines
First of all, let's bring in the history. This feature was discussed in the weekly meeting February 26, 2010. See the chat log at [1], around the time stamp 20:45:15.
Quoted 5 lines
David, IRC is not a development tool, it is sync tool that require all to be available at the same time, which is never the case. I don't understand why you took this approach, but its down-side is that people discover such commits later on.
There are several good reasons why we do use IRC as a development tool. First, it's the best/only available way to get James' input into "testing" development. Second, many patches have fail to receive an ACK/NACK or even any comments in the mailing list discussions. It's this kind of patches which are discussed in the meetings and more often than not we've managed to get an ACK/NACK for them.
As you say, there are problems with using IRC as a development tool, timezones being one big problem. That's why after every meeting I send a summary to openvpn-devel which documents every single patch ACK/NACK. A full chatlog is also attached to this mail. To make sure the summaries & chatlogs don't get lost in mailing list archives, they are also linked to from here:
http://www.secure-computing.net/wiki/index.php/OpenVPN/IRC_meetings
The preliminary meeting agenda / topic list is also visible prior the meeting so that people can choose whether to attend or not (if they can).
However, I think there's definitely room for improvement. IRC is addictive, because it allows making decisions fast and easily. The downside is that not all people can attend the meetings and are thus unable to affect their outcome or provide valuable feedback. What we need to avoid is creating two classes of developers: those who can attend the IRC (and make the decisions) and those who can't (and don't decide).
As a concrete measure I suggest that patches ACK'd in IRC meetings should not be merged until, say, Monday. That way people can review the chatlog and if they don't like what they see, they can provide their comments. I think that we should from now on "propose" rather than "decide" to include patches based on IRC discussions. Otherwise people might get the wrong impression that we don't want/need further comments. I also suggest that we really focus on using IRC only when the mailing list discussions have led nowhere, not just for it's convenience.
What do you think?
Thanks for the constructive criticism, Alon.
Quoted 3 lines
I think that using IRC is much too chatty to begin with. Async communication is much complete and atomic.
That's probably true most of the time. However, IRC like any synchronous communication method has less overhead than async methods. That's why people prefer to talk to each other directly - if possible - rather than send them email. Due to the directness and "chattiness" of the IRC the meetings also serve an important social function, bonding together people from the company and the community. They do not _have_ to be patch discussion meetings to achieve that goal, though.
Quoted 2 lines
Also, your summary contains so much unrelated issues that it is harder to track.
I assume you mean the full chatlog rather than the summary. If so, I agree.
Quoted 3 lines
Proper mailing list management proved themselves for a long time, the LKML is a good example of such.
That's why we are using and should use the mailing lists as the primary communication channel.
Quoted 8 lines
However, if you truly want to manage the change sets, install bugzilla [or any other *DECENT* tracker except trac], and follow change request from submittion to release.
This way you can track the full history of a single change, and not follow several meeting logs, mail messages and other means of discussion.
Could you share your views about the concrete benefits we'd get from being able to track change requests / patches from submit to release? What kind of problems would it solve? What kind of problems can we expect if we can't do that? I would appreciate if you could spell it out so that even a dummy like me can understand ;).
Quoted 7 lines
All relevant people [weather decision making or interest] may be CCed, also the devel mailing list can be CCed so outsider can track the status of changes.
Managing software is a complex task, the IRC session you conducting does not make it more organize/simpler/complete.
As I said in this mail and my previous email, the IRC meetings solve real problems. If you have a better alternatives that address these problems, please share them with us. The current process (incl. IRC meetings) is tailored to our specific needs.
Signature · 5 lines
Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 10 lines · Samuli Seppänen
Quoted 10 lines
First of all, let's bring in the history. This feature was discussed in the weekly meeting February 26, 2010. See the chat log at [1], around the time stamp 20:45:15.
Quoted 4 lines
David, IRC is not a development tool, it is sync tool that require all to be available at the same time, which is never the case. I don't understand why you took this approach, but its down-side is that people discover such commits later on.
Quoted 6 lines
There are several good reasons why we do use IRC as a development tool. First, it's the best/only available way to get James' input into "testing" development. Second, many patches have fail to receive an ACK/NACK or even any comments in the mailing list discussions. It's this kind of patches which are discussed in the meetings and more often than not we've managed to get an ACK/NACK for them.
It should also be said that discussed patches need to be posted to the mailing list either before or after the meeting to get the final ACK/NACKs. In the case of being sent after a meeting, the patch still needs to receive a public ACK, preferably on the ML. But if there are no response on the ML, it will be brought up for discussion on a later IRC meeting.
So it is fair to say that IRC meetings alone do not decide which patches are accepted or not. Patches are brought up to discussions in those meetings just because the feedback on the ML is lacking.
Further, I do not accept patches which has not been through the mailing list and have received ACKs. And I usually tend to let it go a little while after the patch has been submitted before I suggest them for the meeting agenda. If the meeting minutes after this process says a patch got an ACK, that is the same for me as if one of the meeting participants afterwords replies to the patch, saying ACK. I anyway do add in the final commit logs who ACKed which patches.
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkvFqV4ACgkQDC186MBRfrqoBgCeJXJSogc3gcuWiqDdTxsaVThM e+cAnA1pVW+JomiLDBK+DT0FNJksVpbX
=BaYH
-----END PGP SIGNATURE-----
Hi,
Quoted 5 lines · David Sommerseth
This patch will create ./configure.h which will contain two new #define strings.
CONFIGURE_DEFINESwill contain all USE, ENABLED, DISABLED and DEPRECATED defines from ./config.h.CONFIGURE_CALLwill contain the complete ./configure line which was used when configuring the package for building.
A bit late, but "looks good to me" (and useful, too :) ). ACK.
gert
Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany [email protected]...
fax: +49-89-35655025 [email protected]...