UBI: Ensure that "background thread" operations are really executed
Subsystems (2)
PATCH 1/1 UBI: Ensure that "background thread" operations are really executed
The current U-Boot UBI implementation is copied from Linux. In this porting the UBI background thread was not handled correctly. Upon write operations ubi_wl_flush() makes sure, that all queued operations, like page-erase, are completed. But this is missing for read operations.
This patch now makes sure that such operations (like scrubbing upon bit-flip errors) are not queued, but executed directly.
--- drivers/mtd/ubi/wl.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-)
drivers/mtd/ubi/wl.c +7 -2
@@ -696,8 +696,13 @@ static void schedule_ubi_work(struct ubi_device *ubi, struct ubi_work *wrk)list_add_tail (&wrk->list, &ubi->works);ubi_assert (ubi->works_count >=0 ); ubi->works_count +=1 ; -if (ubi->thread_enabled) -wake_up_process (ubi->bgt_thread); + +/* +* U-Boot special: We have no bgt_thread in U-Boot! +* So just call do_work() here directly. +*/ +do_work (ubi); +spin_unlock (&ubi->wl_lock); }
Signature · 1 line
1.7.1
PATCH 1/1 UBI: Ensure that "background thread" operations are really executed
Quoted 7 lines · On Monday 17 May 2010 10:00:51 Stefan Roese wrote:
The current U-Boot UBI implementation is copied from Linux. In this porting the UBI background thread was not handled correctly. Upon write operations
ubi_wl_flush()makes sure, that all queued operations, like page-erase, are completed. But this is missing for read operations.This patch now makes sure that such operations (like scrubbing upon bit-flip errors) are not queued, but executed directly.
Applied to u-boot-ubi/master. Thanks.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de