misc cleanups and SMS ID API

Hi Inaky,

.gitignore line 1

Quoted 6 lines

.gitignore +1 -0

index 1ce7067..d7e9254 100644
@@ -1,3 +1,4 @@
+*~

believe it or not, I always left that out on purpose. I like having git status show me all the stupid backup files my editor creates.

Quoted 9 lines

.gitignore +0 -0

  *.o
  *.lo
  *.la

@@ -16,6 +17,8 @@ config.sub

 configure
 depcomp
 compile

.gitignore +2 -0

+cscope.files
+cscope.out

Quoted 3 lines

 install-sh
 libtool
 ltmain.sh

Please put the cscope stuff behind autom4te.cache since it is not part of autoconf/automake.

Quoted 10 lines

.gitignore line 1

Quoted 6 lines

.gitignore +1 -0

index 1ce7067..d7e9254 100644
@@ -1,3 +1,4 @@
+*~

believe it or not, I always left that out on purpose. I like having git status show me all the stupid backup files my editor creates.

Quoted 16 lines

.gitignore config.sub · line 24

Quoted 12 lines

.gitignore +2 -0

 *.o
 *.lo
 *.la

@@ -16,6 +17,8 @@ config.sub
 configure
 depcomp
 compile
+cscope.files
+cscope.out
 install-sh
 libtool
 ltmain.sh

Please put the cscope stuff behind autom4te.cache since it is not part of autoconf/automake.

Does this makes sense since this files are not related to the project itself but to specific tools? I usually put those on my personal gitignore file.

Hi Joao,

Quoted 27 lines

Quoted 26 lines

.gitignore line 1

Quoted 6 lines

.gitignore +1 -0

index 1ce7067..d7e9254 100644
@@ -1,3 +1,4 @@
+*~

believe it or not, I always left that out on purpose. I like having git status show me all the stupid backup files my editor creates.

.gitignore config.sub · line 24

Quoted 12 lines

.gitignore +2 -0

 *.o
 *.lo
 *.la

@@ -16,6 +17,8 @@ config.sub
 configure
 depcomp
 compile
+cscope.files
+cscope.out
 install-sh
 libtool
 ltmain.sh

Please put the cscope stuff behind autom4te.cache since it is not part of autoconf/automake.

Quoted 3 lines

Does this makes sense since this files are not related to the project itself but to specific tools? I usually put those on my personal gitignore file.

actually I have to agree. They really don't belong in the project and the personal gitignore configuration is a suitable place for them.

From: Inaky Perez-Gonzalez <[email protected]>

---
 src/sms.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

src/sms.c +6 -0

index 3a1cff0..594481e 100644
@@ -398,6 +398,19 @@ static struct tx_queue_entry *create_tx_queue_entry(GSList *msg_list)
 	return entry;
 }
 
+/*
+ * Pre-process a SMS text message and deliver it [D-BUS' SendMessage()]
+ *
+ * @conn: D-BUS connection
+ * @msg: message data (telephone number and text)
+ * @data: SMS object to use for transmision

Hi Inaky,

Quoted 27 lines

From: Inaky Perez-Gonzalez <[email protected]>

---
 src/sms.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

src/sms.c +13 -0

index 3a1cff0..594481e 100644
@@ -398,6 +398,19 @@ static struct tx_queue_entry *create_tx_queue_entry(GSList *msg_list)
 	return entry;
 }
 
+/*
+ * Pre-process a SMS text message and deliver it [D-BUS' SendMessage()]
+ *
+ * @conn: D-BUS connection
+ * @msg: message data (telephone number and text)
+ * @data: SMS object to use for transmision
+ *
+ * An alphabet is chosen for the text and it (might be) segmented in
+ * fragments by sms_text_prepare() into @msg_list. A queue list @entry
+ * is created by create_tx_queue_entry() and g_queue_push_tail()
+ * appends that entry to the SMS transmit queue. Then the tx_next()
+ * function is scheduled to run to process the queue.
+ */

src/sms.c static struct tx_queue_entry *create_tx_queue_entry(GSList *msg_list) · line 416

Quoted 3 lines

src/sms.c +0 -0

 static DBusMessage *sms_send_message(DBusConnection *conn, DBusMessage *msg,
 					void *data)
 {

small comments here. So it is D-Bus. That is the official naming in documentation we settled on some time ago. Half of the documentation might be still using it wrongly, but we might wanna set a good example here.

I don't know how picky gtk-doc is about not having the : for title and the empty line after the title. However this is nicely readable inside the source code, so I am fine with it.

From: Inaky Perez-Gonzalez <[email protected]>

---
 src/sms.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

Hi Inaky,

Quoted 6 lines

From: Inaky Perez-Gonzalez <[email protected]>

---
 src/sms.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

Applied with s/D-BUS/D-Bus

From: Inaky Perez-Gonzalez <[email protected]>

---
 doc/standards.txt |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
 create mode 100644 doc/standards.txt

doc/standards.txt new file +0 -0

new file mode 100644
index 0000000..c4b68eb

Hi Inaky,

Quoted 16 lines

From: Inaky Perez-Gonzalez <[email protected]>

---
 doc/standards.txt |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
 create mode 100644 doc/standards.txt

doc/standards.txt new file +3 -0

new file mode 100644
index 0000000..c4b68eb
@@ -0,0 +1,8 @@
+Referencing standards in the source
+===================================
+

doc/standards.txt line 8

Quoted 5 lines

doc/standards.txt new file +5 -0

+When referencing standard documents use raw numbers xx.xxx for 3GPP
+documents or xxx.xxx for ETSI document (eg: 23.040). If needing to
+point to an specific section/subsection, explicitly say "Section foo"
+
+3GPP specs can be found in http://3gpp.org/ftp/Specs.

would this not better fit into HACKING document. I don't really have a strong opinion here. Just asking.

Hi Inaky,

src/smsutil.c static GSList *sms_assembly_add_fragment_backup(struct sms_assembly *assembly, · line 2487

Quoted 5 lines

src/smsutil.c +5 -0

+		/* Iterate over the bitmap to find in which position
+		 * should the fragment be inserted -- basically we
+		 * walk each bit in the bitmap until the bit we care
+		 * about (offset:bit) and count which are stored --
+		 * that gives us in which position we have to insert. */

Patch has been applied. However please keep your commit header to 50 characters or less. Also, the preferred style for multi-line comments is:
/* <empty line>
* ... comment
*/

From: Inaky Perez-Gonzalez <[email protected]>

These have been stolen from the Linux kernel source; come pretty handy to make build-time consistency checks and thus avoid run-time surprises.

---
 src/util.h |   29 +++++++++++++++++++++++++++++
 1 files changed, 29 insertions(+), 0 deletions(-)

src/util.h +19 -0

index 2835b76..cf34b67 100644
@@ -77,3 +77,32 @@ unsigned char *pack_7bit(const unsigned char *in, long len, int byte_offset,
 				long *items_written, unsigned char terminator);
 
 char *sim_string_to_utf8(const unsigned char *buffer, int length);
+
+/*
+ * Build time consistency checks
+ *
+ * Stolen from the Linux kernel 2.6.35-rc; as most taken from the
+ * Linux kernel, this is licensed GPL v2 or newer.
+ */
+
+/* Force a compilation error if condition is true */
+#define BUILD_BUG_ON(condition) ((void)BUILD_BUG_ON_ZERO(condition))
+
+/* Force a compilation error if condition is constant and true */
+#define MAYBE_BUILD_BUG_ON(cond) ((void)sizeof(char[1 - 2 * !!(cond)]))
+
+/* Force a compilation error if a constant expression is not a power of 2 */
+#define BUILD_BUG_ON_NOT_POWER_OF_2(n)			\
+	BUILD_BUG_ON((n) == 0 || (((n) & ((n) - 1)) != 0))
+
+/* Force a compilation error if condition is true, but also produce a

Hi Inaky,

Quoted 36 lines

From: Inaky Perez-Gonzalez <[email protected]>

These have been stolen from the Linux kernel source; come pretty handy to make build-time consistency checks and thus avoid run-time surprises.

---
 src/util.h |   29 +++++++++++++++++++++++++++++
 1 files changed, 29 insertions(+), 0 deletions(-)

src/util.h +19 -0

index 2835b76..cf34b67 100644
@@ -77,3 +77,32 @@ unsigned char *pack_7bit(const unsigned char *in, long len, int byte_offset,
 				long *items_written, unsigned char terminator);
 
 char *sim_string_to_utf8(const unsigned char *buffer, int length);
+
+/*
+ * Build time consistency checks
+ *
+ * Stolen from the Linux kernel 2.6.35-rc; as most taken from the
+ * Linux kernel, this is licensed GPL v2 or newer.
+ */
+
+/* Force a compilation error if condition is true */
+#define BUILD_BUG_ON(condition) ((void)BUILD_BUG_ON_ZERO(condition))
+
+/* Force a compilation error if condition is constant and true */
+#define MAYBE_BUILD_BUG_ON(cond) ((void)sizeof(char[1 - 2 * !!(cond)]))
+
+/* Force a compilation error if a constant expression is not a power of 2 */
+#define BUILD_BUG_ON_NOT_POWER_OF_2(n)			\
+	BUILD_BUG_ON((n) == 0 || (((n) & ((n) - 1)) != 0))
+
+/* Force a compilation error if condition is true, but also produce a

src/util.h unsigned char *pack_7bit(const unsigned char *in, long len, int byte_offset, · line 108

Quoted 10 lines

src/util.h +10 -0

+   result (of value 0 and type size_t), so the expression can be used
+   e.g. in a structure initializer (or where-ever else comma expressions
+   aren't permitted). */
+#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
+#define BUILD_BUG_ON_NULL(e) ((void *)sizeof(struct { int:-!!(e); }))
+
+/*
+ * End of code stolen from the Linux kernel 2.6.35-rc. From now, code
+ * is GPL v2 only.
+ */

sounds like a nice addition, but src/util.h is the wrong file. I prefer we make this compatible so that it can be applied to ConnMan and BlueZ as well.

I think something like include/bug.h is better.

Hi Inaky,

src/smsutil.h line 22

Quoted 10 lines

src/smsutil.h +2 -0

index 469a49e..356ec5d 100644
@@ -18,6 +18,14 @@
  *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
  *
  */
+#ifndef __smsutil_h__
+#define __smsutil_h__

please leave the circular dependency protection out here. I really want it to fail if we go so crazy and would require it.

Hi Inaky,

src/smsutil.h line 28

Quoted 4 lines

src/smsutil.h +4 -0

+#include <glib/gtypes.h>
+#include <glib/gslist.h>
+#include <glib/gmessages.h>
+#include <glib/gchecksum.h>

Isn't it sufficient to just add glib/glib.h here?

Hi Inaky,

Quoted 6 lines

From: Inaky Perez-Gonzalez <[email protected]>

write_file(), as written wasn't transaction-safe; a crash bewtween a file being open and the buffer being written before a safe close would leave the file with a set of undetermined contents.

src/storage.c ssize_t write_file(const unsigned char *buffer, size_t len, mode_t mode, · line 143

Quoted 6 lines

Modified to the file is written to a temporary file name; once completed, it is renamed to the final name. This way, a crash in the middle doesn't leave half-baked files.

src/storage.c +3 -0

+	/* Now that the file contents are written, rename to the real
+	 * file name; this way we are uniquely sure that the whole
+	 * thing is there. */

Again, prefer multiline comments to be in a certain format

src/storage.c ssize_t write_file(const unsigned char *buffer, size_t len, mode_t mode, · line 155

Quoted 13 lines

src/storage.c +9 -0

+	unlink(path);
+	/* conserve @r's value from 'write' */
+	if (link(tmp_path, path) == -1)
+		r = -1;
+error_write:
+	unlink(tmp_path);
+error_mkstemp_full:
+error_create_dirs:
+	g_free(tmp_path);
 	g_free(path);
 	return r;
 }

And I get trouble applying your patch:
Applying: write_file: make transaction-safe /home/denkenz/ofono-master/.git/rebase-apply/patch:13: trailing whitespace. /*
/home/denkenz/ofono-master/.git/rebase-apply/patch:22: trailing whitespace.
*/
/home/denkenz/ofono-master/.git/rebase-apply/patch:75: trailing whitespace.

From: Inaky Perez-Gonzalez <[email protected]>

---
 src/storage.h |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

Hi Inaky,

Quoted 6 lines

From: Inaky Perez-Gonzalez <[email protected]>

---
 src/storage.h |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

Patch has been applied with a modified commit message.

From: Inaky Perez-Gonzalez <[email protected]>

Signed-off-by Inaky Perez-Gonzalez <[email protected]>

Hi Inaky,

Quoted 3 lines

From: Inaky Perez-Gonzalez <[email protected]>

Signed-off-by Inaky Perez-Gonzalez <[email protected]>

We don't use signed off lines here, please don't include them in the future.

Patch has been applied with a modified commit message.

From: Inaky Perez-Gonzalez <[email protected]>

Modified HACKING and man page to have more formation on what are the debugging options and how to enable them.

---
 HACKING      |   10 ++++++++++
 doc/ofonod.8 |    5 ++++-
 src/main.c   |    4 +++-
 3 files changed, 17 insertions(+), 2 deletions(-)

HACKING +10 -0

index ae420aa..e825185 100644
@@ -81,3 +81,13 @@ automatically includes this option.
 
 For production installations or distribution packaging it is important that
 the "--enable-maintainer-mode" option is NOT used.
+
+Note multiple arguments to -d can be specified, colon, comma or space
+separated. The arguments are relative source code filenames for which
+debugging output should be enabled; output shell-style globs are
+accepted (e.g.: 'plugins/*:src/main.c').
+
+Other debugging settings that can be toggled:
+
+ - Environment variable OFONO_AT_DEBUG (set to 1): enable AT commands
+   debugging

doc/ofonod.8 +0 -0

index 474d7fb..7bb908c 100644
@@ -18,7 +18,10 @@ is used to manage \fID-Bus\fP permissions for oFono.
 .SH OPTIONS

src/main.c +0 -0

index 8e686ac..c5791be 100644

Hi Inaky,

Quoted 38 lines

From: Inaky Perez-Gonzalez <[email protected]>

Modified HACKING and man page to have more formation on what are the debugging options and how to enable them.

---
 HACKING      |   10 ++++++++++
 doc/ofonod.8 |    5 ++++-
 src/main.c   |    4 +++-
 3 files changed, 17 insertions(+), 2 deletions(-)

HACKING +10 -0

index ae420aa..e825185 100644
@@ -81,3 +81,13 @@ automatically includes this option.
 
 For production installations or distribution packaging it is important that
 the "--enable-maintainer-mode" option is NOT used.
+
+Note multiple arguments to -d can be specified, colon, comma or space
+separated. The arguments are relative source code filenames for which
+debugging output should be enabled; output shell-style globs are
+accepted (e.g.: 'plugins/*:src/main.c').
+
+Other debugging settings that can be toggled:
+
+ - Environment variable OFONO_AT_DEBUG (set to 1): enable AT commands
+   debugging

doc/ofonod.8 +1 -1

index 474d7fb..7bb908c 100644
@@ -18,7 +18,10 @@ is used to manage \fID-Bus\fP permissions for oFono.
 .SH OPTIONS
 .TP
 .B --debug, -d
-Enable debug information output.
+Enable debug information output. Note multiple arguments to -d can be

doc/ofonod.8 is used to manage \fID-Bus\fP permissions for oFono. · line 27

Quoted 6 lines

doc/ofonod.8 +3 -0

+specified, colon, comma or space separated. The arguments are relative
+source code filenames for which debugging output should be enabled;
+output shell-style globs are accepted (e.g.: "plugins/*:src/main.c").
 .TP
 .B --nodetach, -n
 Don't run as daemon in background.

you need to hook this up to automake :)

Quoted 6 lines

src/main.c +0 -0

index 8e686ac..c5791be 100644
@@ -98,7 +98,9 @@ static gboolean option_version = FALSE;
 

src/main.c static gboolean option_version = FALSE; · line 106

Quoted 9 lines

src/main.c +3 -1

 static GOptionEntry options[] = {
 	{ "debug", 'd', 0, G_OPTION_ARG_STRING, &option_debug,
-				"Specify debug options to enable", "DEBUG" },
+			   "Specify debug options to enable (see the "
+			   "man page for ofonod(8) for more information).",
+			   "DEBUG" },
 	{ "nodetach", 'n', G_OPTION_FLAG_REVERSE,
 				G_OPTION_ARG_NONE, &option_detach,
 				"Don't run as daemon in background" },

Please leave this out. If we have a man page and man ofonod works, then this is not needed.

Quoted 38 lines

Quoted 38 lines

From: Inaky Perez-Gonzalez <[email protected]>

Modified HACKING and man page to have more formation on what are the debugging options and how to enable them.

---
 HACKING      |   10 ++++++++++
 doc/ofonod.8 |    5 ++++-
 src/main.c   |    4 +++-
 3 files changed, 17 insertions(+), 2 deletions(-)

HACKING +10 -0

index ae420aa..e825185 100644
@@ -81,3 +81,13 @@ automatically includes this option.
 
 For production installations or distribution packaging it is important that
 the "--enable-maintainer-mode" option is NOT used.
+
+Note multiple arguments to -d can be specified, colon, comma or space
+separated. The arguments are relative source code filenames for which
+debugging output should be enabled; output shell-style globs are
+accepted (e.g.: 'plugins/*:src/main.c').
+
+Other debugging settings that can be toggled:
+
+ - Environment variable OFONO_AT_DEBUG (set to 1): enable AT commands
+   debugging

doc/ofonod.8 +1 -1

index 474d7fb..7bb908c 100644
@@ -18,7 +18,10 @@ is used to manage \fID-Bus\fP permissions for oFono.
 .SH OPTIONS
 .TP
 .B --debug, -d
-Enable debug information output.
+Enable debug information output. Note multiple arguments to -d can be

Quoted 8 lines

doc/ofonod.8 is used to manage \fID-Bus\fP permissions for oFono. · line 27

Quoted 6 lines

doc/ofonod.8 +3 -0

+specified, colon, comma or space separated. The arguments are relative
+source code filenames for which debugging output should be enabled;
+output shell-style globs are accepted (e.g.: "plugins/*:src/main.c").
 .TP
 .B --nodetach, -n
 Don't run as daemon in background.

you need to hook this up to automake :)

Can you clarify, please?

Quoted 6 lines

Quoted 6 lines

src/main.c +0 -0

index 8e686ac..c5791be 100644
@@ -98,7 +98,9 @@ static gboolean option_version = FALSE;
 

Quoted 12 lines

src/main.c static gboolean option_version = FALSE; · line 106

Quoted 9 lines

src/main.c +3 -1

 static GOptionEntry options[] = {
 	{ "debug", 'd', 0, G_OPTION_ARG_STRING, &option_debug,
-				"Specify debug options to enable", "DEBUG" },
+			   "Specify debug options to enable (see the "
+			   "man page for ofonod(8) for more information).",
+			   "DEBUG" },
 	{ "nodetach", 'n', G_OPTION_FLAG_REVERSE,
 				G_OPTION_ARG_NONE, &option_detach,
 				"Don't run as daemon in background" },

Please leave this out. If we have a man page and man ofonod works, then this is not needed.

Denis and me, AFAIR, agreed on this wording as it just gives the quick pointer to where the extra information is found. Again, not critical, but confusing feedback.

Hi Inaky,

Quoted 47 lines

Quoted 46 lines

Quoted 34 lines

From: Inaky Perez-Gonzalez <[email protected]>

Modified HACKING and man page to have more formation on what are the debugging options and how to enable them.

---
 HACKING      |   10 ++++++++++
 doc/ofonod.8 |    5 ++++-
 src/main.c   |    4 +++-
 3 files changed, 17 insertions(+), 2 deletions(-)

HACKING +10 -0

index ae420aa..e825185 100644
@@ -81,3 +81,13 @@ automatically includes this option.
 
 For production installations or distribution packaging it is important that
 the "--enable-maintainer-mode" option is NOT used.
+
+Note multiple arguments to -d can be specified, colon, comma or space
+separated. The arguments are relative source code filenames for which
+debugging output should be enabled; output shell-style globs are
+accepted (e.g.: 'plugins/*:src/main.c').
+
+Other debugging settings that can be toggled:
+
+ - Environment variable OFONO_AT_DEBUG (set to 1): enable AT commands
+   debugging

doc/ofonod.8 +0 -0

index 474d7fb..7bb908c 100644
@@ -18,7 +18,10 @@ is used to manage \fID-Bus\fP permissions for oFono.
 .SH OPTIONS

doc/ofonod.8 is used to manage \fID-Bus\fP permissions for oFono. · line 27

Quoted 10 lines

doc/ofonod.8 +4 -1

 .TP
 .B --debug, -d
-Enable debug information output.
+Enable debug information output. Note multiple arguments to -d can be
+specified, colon, comma or space separated. The arguments are relative
+source code filenames for which debugging output should be enabled;
+output shell-style globs are accepted (e.g.: "plugins/*:src/main.c").
 .TP
 .B --nodetach, -n
 Don't run as daemon in background.

you need to hook this up to automake :)

Quoted 1 line

Can you clarify, please?

we do wanna install the man pages, right? Then this needs man_MANS and EXTRA_DIST magic to get included and installed.

Quoted 19 lines

Quoted 6 lines

Quoted 6 lines

src/main.c +0 -0

index 8e686ac..c5791be 100644
@@ -98,7 +98,9 @@ static gboolean option_version = FALSE;
 

Quoted 12 lines

src/main.c static gboolean option_version = FALSE; · line 106

Quoted 9 lines

src/main.c +3 -1

 static GOptionEntry options[] = {
 	{ "debug", 'd', 0, G_OPTION_ARG_STRING, &option_debug,
-				"Specify debug options to enable", "DEBUG" },
+			   "Specify debug options to enable (see the "
+			   "man page for ofonod(8) for more information).",
+			   "DEBUG" },
 	{ "nodetach", 'n', G_OPTION_FLAG_REVERSE,
 				G_OPTION_ARG_NONE, &option_detach,
 				"Don't run as daemon in background" },

Please leave this out. If we have a man page and man ofonod works, then this is not needed.

Quoted 3 lines

Denis and me, AFAIR, agreed on this wording as it just gives the quick pointer to where the extra information is found. Again, not critical, but confusing feedback.

Maybe I am too old school Linux here ;)

If we have an installed man page and I don't understand the usage information, then it is clear to just do man ofonod. I don't need the usage tell me that.

When the build directory is different than the source directory, we need to specify the source prefix to the original file we are copying.

---
 Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Makefile.am +0 -0

index ed13346..31c157c 100644

From: Inaky Perez-Gonzalez <[email protected]>

When the build directory is different than the source directory, we need to specify the source prefix to the original file we are copying.

+/**
+ * Create a random UUID
+ *
+ * \param msg_id Descriptor
+ *
+ * \internal
+ *
+ * Crams the msg_id ID buffer with random 32-bit numbers; because we
+ * use a byte based buffer, we play the cast to guint32 trick (as that
+ * is what g_random_int() returns).
+ */

Hi Inaky,

Quoted 11 lines

+/**
+ * Create a random UUID
+ *
+ * \param msg_id Descriptor
+ *
+ * \internal
+ *
+ * Crams the msg_id ID buffer with random 32-bit numbers; because we
+ * use a byte based buffer, we play the cast to guint32 trick (as that
+ * is what g_random_int() returns).
+ */

can we just stick with gtk-doc like you had in your previous patches. I think intermixing it with doxygen is a bad idea.

Quoted 12 lines

Quoted 11 lines

+/**
+ * Create a random UUID
+ *
+ * \param msg_id Descriptor
+ *
+ * \internal
+ *
+ * Crams the msg_id ID buffer with random 32-bit numbers; because we
+ * use a byte based buffer, we play the cast to guint32 trick (as that
+ * is what g_random_int() returns).
+ */

Quoted 2 lines

can we just stick with gtk-doc like you had in your previous patches. I think intermixing it with doxygen is a bad idea.

Yep, my bad, sorry.

In any case, picking this up from earlier:

I have my doubts on gtk-doc vs doxygen. I remember there was a thread somewhere (email? irc? voice?) on which system to settle on which never got finalized. I am not too satisfied with gtk-doc's limitations, I'd rather do doxygen. Does anyone have any preference on once vs the other?

In any case, when we settle on one, I'll have to go and cleanup all these to conform to it. I'll also write a quick summary with examples on how to use it in doc/.