dma: dmatest: fix potential sign bug
Subsystems (2)
PATCH 3/5 dma: dmatest: fix potential sign bug
'cnt' is unsigned, so this code may become wrong in future as dmatest_add_threads() can return error code:
cnt = dmatest_add_threads(dtc, DMA_MEMCPY); thread_count += cnt > 0 ? cnt : 0; ^^^^^^^
Now it can return only -EINVAL if and only if second argument of dmatest_add_threads() is not one of DMA_MEMCPY, DMA_XOR, DMA_PQ. So, now it is not wrong but may become wrong in future.
The semantic patch that finds this problem (many false-positive results):
(http://coccinelle.lip6.fr/)
// <smpl>
@ r1 @
identifier f;
@@
int f(...) { ... }
@@
identifier r1.f;
type T;
unsigned T x;
@@
*x = f(...)
...
*x > 0
Signed-off-by Kulikov Vasiliy <[email protected]>
--- drivers/dma/dmatest.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/dma/dmatest.c +1 -1
@@ -540,7 +540,7 @@ static int dmatest_add_channel(struct dma_chan *chan)struct dmatest_chan *dtc;struct dma_device *dma_dev = chan->device;unsigned int thread_count =0 ; -unsigned int cnt; +int cnt; dtc =kmalloc (sizeof (struct dmatest_chan ),GFP_KERNEL );if (!dtc) {
Signature · 1 line
1.7.0.4