net: dccp: fix sign bug
Subsystems (3)
PATCH 5/5 net: dccp: fix sign bug
'gap' is unsigned, so this code is wrong:
gap = -new_head;
...
if (gap > 0) { ... }Make 'gap' signed.
The semantic patch that finds this problem (many false-positive results):
(http://coccinelle.lip6.fr/)
// <smpl>
@ r1 @
identifier f;
@@
int f(...) { ... }
@@
identifier r1.f;
type T;
unsigned T x;
@@
*x = f(...)
...
*x > 0
Signed-off-by Kulikov Vasiliy <[email protected]>
--- net/dccp/ackvec.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
net/dccp/ackvec.c +1 -1
@@ -201,7 +201,7 @@ static inline int dccp_ackvec_set_buf_head_state(struct dccp_ackvec *av,const unsigned int packets, const unsigned char state) { - unsigned int gap; + long gap;long new_head;if (av->av_vec_len + packets >DCCP_MAX_ACKVEC_LEN )
Signature · 1 line
1.7.0.4
From: Kulikov Vasiliy <[email protected]>
Date: Sat, 17 Jul 2010 19:21:00 +0400
Quoted 11 lines
'gap' is unsigned, so this code is wrong:
gap = -new_head; ... if (gap > 0) { ... }Make 'gap' signed.
The semantic patch that finds this problem (many false-positive results):
(http://coccinelle.lip6.fr/)
...
Quoted 1 line
Signed-off-by Kulikov Vasiliy <[email protected]>
Applied, thanks.