Skip to contentSkip to conversation

net: dccp: fix sign bug

PATCH Applied Kulikov Vasiliy 2 participants 2 messages Jul 17, 2010 – Jul 18, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 5/5 net: dccp: fix sign bug

'gap' is unsigned, so this code is wrong:

    gap = -new_head;
    ...
    if (gap > 0) { ... }

Make 'gap' signed.

The semantic patch that finds this problem (many false-positive results):
(http://coccinelle.lip6.fr/)

// <smpl>
@ r1 @
identifier f;
@@
int f(...) { ... }

@@
identifier r1.f;
type T;
unsigned T x;
@@

*x = f(...)
...
*x > 0

---
 net/dccp/ackvec.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/dccp/ackvec.c +1 -1
index 2abddee..92a6fcb 100644
@@ -201,7 +201,7 @@ static inline int dccp_ackvec_set_buf_head_state(struct dccp_ackvec *av,
 						 const unsigned int packets,
 						 const unsigned char state)
 {
-	unsigned int gap;
+	long gap;
 	long new_head;
 
 	if (av->av_vec_len + packets > DCCP_MAX_ACKVEC_LEN)
Signature · 1 line
1.7.0.4