Skip to contentSkip to conversation

char: sx: call disable_pci_device() if pci_probe() failed

PATCH Superseded Kulikov Vasiliy 1 participant 1 message Aug 6, 2010

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 4/18 char: sx: call disable_pci_device() if pci_probe() failed

Driver should call disable_pci_device() if it returns from pci_probe() with error. Also it must not be called if pci_request_region() fails as it means that somebody uses device resources and rules the device.

---
 drivers/char/sx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/char/sx.c +1 -0
index 5b24db4..5140b0d 100644
@@ -2711,6 +2711,7 @@ err_unmap:
 	iounmap(board->base2);
 err_reg:
 	pci_release_region(pdev, reg);
+	pci_disable_device(pdev);
 err_flag:
 	board->flags &= ~SX_BOARD_PRESENT;
 err:
Signature · 1 line
1.7.0.4