Skip to contentSkip to conversation

vfs: update ctime when changing the file's permission by setfacl

PATCH New Jan Kara 1 participant 1 message Aug 17, 2010 VFS

lore
Share & tools
lore

Jan Kara

author reviewer
#0 lore raw

PATCH 1/1 vfs: update ctime when changing the file's permission by setfacl

generic_acl_set didn't update the ctime of the file when its permission was changed.

Steps to reproduce:

 # touch aaa
 # stat -c %Z aaa
 1275289822
 # setfacl -m  'u::x,g::x,o::x' aaa
 # stat -c %Z aaa
 1275289822                         <- unchanged

But, according to the spec of the ctime, vfs must update it.

Port of ext3 patch by Miao Xie <[email protected]>.

---
 fs/generic_acl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Al, would you merge this fix please? You didn't seem to pick it up
last time I sent it. Thanks.

fs/generic_acl.c +1 -0
index 99800e5..6bc9e3a 100644
@@ -94,6 +94,7 @@ generic_acl_set(struct dentry *dentry, const char *name, const void *value,
 			if (error < 0)
 				goto failed;
 			inode->i_mode = mode;
+			inode->i_ctime = CURRENT_TIME;
 			if (error == 0) {
 				posix_acl_release(acl);
 				acl = NULL;
Signature · 1 line
1.6.4.2