Skip to contentSkip to conversation

Disable virtio-balloon memory stats interface

PATCH New Adam Litke 1 participant 1 message Sep 8, 2010

lore
Share & tools
lore

Adam Litke

author
#0 lore raw

PATCH 1/1 Disable virtio-balloon memory stats interface

The addition of memory stats reporting to the virtio balloon causes the 'info balloon' command to become asynchronous. This is a regression because in some cases it can hang the user monitor.

To fix this regression, the virtio balloon memory stats feature is being disabled in qemu-0.13.

---
 hw/virtio-balloon.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)
hw/virtio-balloon.c +11 -1
index 9fe3886..269bc22 100644
@@ -190,7 +190,17 @@ static void virtio_balloon_set_config(VirtIODevice *vdev,
 
 static uint32_t virtio_balloon_get_features(VirtIODevice *vdev, uint32_t f)
 {
-    f |= (1 << VIRTIO_BALLOON_F_STATS_VQ);
+    /*
+     * The addition of memory stats reporting to the virtio balloon causes
+     * the 'info balloon' command to become asynchronous.  This is a regression
+     * because in some cases it can hang the user monitor.
+     *
+     * To fix this regression, the virtio balloon memory stats feature is being
+     * disabled in qemu-0.13.
+     *
+     * -aglitke
+     */
+    /* f |= (1 << VIRTIO_BALLOON_F_STATS_VQ); */
     return f;
 }
 
Signature · 1 line
1.6.1.3