Skip to contentSkip to conversation

hwmon: (lm90) Add support for extra

PATCH In review Guenter Roeck 2 participants 3 messages Sep 16, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 6/7 hwmon: (lm90) Add support for extra

---
 Documentation/hwmon/lm90            |    9 +++--
 Documentation/hwmon/sysfs-interface |    7 ++++
 drivers/hwmon/lm90.c                |   65 +++++++++++++++++++++++++++++++---
 3 files changed, 71 insertions(+), 10 deletions(-)
Documentation/hwmon/lm90 +5 -4
index d5ce9f4..bc2c2b4 100644
@@ -101,10 +101,11 @@ well as the temperature of up to one external diode. It is compatible
 with many other devices, many of which are supported by this driver.
 
 Note that there is no easy way to differentiate between the MAX6657,
-MAX6658 and MAX6659 variants. The extra address and features of the
-MAX6659 are not supported by this driver. The MAX6680 and MAX6681 only
-differ in their pinout, therefore they obviously can't (and don't need to)
-be distinguished.
+MAX6658 and MAX6659 variants. The extra features of the MAX6659 are only
+supported by this driver if the chip is located at address 0x4d or 0x4e,
+or if the chip type is explicitly selected as max6659.
+The MAX6680 and MAX6681 only differ in their pinout, therefore they obviously
+can't (and don't need to) be distinguished.
 
 The specificity of this family of chipsets over the ADM1021/LM84
 family is that it features critical limits with hysteresis, and an
Documentation/hwmon/sysfs-interface +7 -0
index 22843cb..4c73f3d 100644
@@ -317,6 +317,13 @@ temp[1-*]_emergency
 		Unit: millidegree Celsius
 		RW
 
+temp[1-*]_emergency_hyst
+		Temperature hysteresis value for emergency limit.
+		Unit: millidegree Celsius
+		Must be reported as an absolute temperature, NOT a delta
+		from the emergency value.
+		RW
+
 temp[1-*]_lcrit	Temperature critical min value, typically lower than
 		corresponding temp_min values.
 		Unit: millidegree Celsius
drivers/hwmon/lm90.c +59 -6

131 lines not on this page · raw message

Signature · 7 lines
1.7.0.87.g0901d


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#1 lore raw
Quoted 15 lines · Guenter Roeck
---
 Documentation/hwmon/lm90            |    9 +++--
 Documentation/hwmon/sysfs-interface |    7 ++++
 drivers/hwmon/lm90.c                |   65 +++++++++++++++++++++++++++++++---
 3 files changed, 71 insertions(+), 10 deletions(-)

(...)

Documentation/hwmon/sysfs-interface +0 -0
index 22843cb..4c73f3d 100644
@@ -317,6 +317,13 @@ temp[1-*]_emergency
 		Unit: millidegree Celsius
 		RW
 

Documentation/hwmon/sysfs-interface temp[1-*]_emergency · line 329

Quoted 10 lines
Documentation/hwmon/sysfs-interface +7 -0
+temp[1-*]_emergency_hyst
+		Temperature hysteresis value for emergency limit.
+		Unit: millidegree Celsius
+		Must be reported as an absolute temperature, NOT a delta
+		from the emergency value.
+		RW
+
 temp[1-*]_lcrit	Temperature critical min value, typically lower than
 		corresponding temp_min values.
 		Unit: millidegree Celsius

I'll merge this chunk into hwmon-add-tempx_emergency-attribute-to-sysfs-abi.patch, I think it makes more sense that way.

Other than that, no objection.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#2 lore raw
In reply to Guenter Roeck
Quoted 16 lines · Jean Delvare
Quoted 15 lines · Guenter Roeck
---
 Documentation/hwmon/lm90            |    9 +++--
 Documentation/hwmon/sysfs-interface |    7 ++++
 drivers/hwmon/lm90.c                |   65 +++++++++++++++++++++++++++++++---
 3 files changed, 71 insertions(+), 10 deletions(-)

(...)

Documentation/hwmon/sysfs-interface +0 -0
index 22843cb..4c73f3d 100644
@@ -317,6 +317,13 @@ temp[1-*]_emergency
 		Unit: millidegree Celsius
 		RW
 
Quoted 15 lines

Documentation/hwmon/sysfs-interface temp[1-*]_emergency · line 329

Quoted 10 lines
Documentation/hwmon/sysfs-interface +7 -0
+temp[1-*]_emergency_hyst
+		Temperature hysteresis value for emergency limit.
+		Unit: millidegree Celsius
+		Must be reported as an absolute temperature, NOT a delta
+		from the emergency value.
+		RW
+
 temp[1-*]_lcrit	Temperature critical min value, typically lower than
 		corresponding temp_min values.
 		Unit: millidegree Celsius

I'll merge this chunk into hwmon-add-tempx_emergency-attribute-to-sysfs-abi.patch, I think it makes more sense that way.

Sure, you are right.

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors