Skip to content

hwmon: Add support for MAX6695/6696 to

Guenter Roeck lm-sensors 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 of 7 patches 10 repliesIn review
  2. v27 patches 15 repliesSuperseded
  3. v11 patch 9 repliesSuperseded

Changes in v3 from the cover letter

- Express bit masks using shift values instead of hex constants
- Replaced tabs after #define with space
- Negated LM90_HAVE_REM_LIMIT_EXT test
- Reordered patches 5 and 6 (introduce max6659 first, then its extra features)
- Clarified that only max6696 permits multiple I2C addresses
- Use max6696 instead of max6695 in chips enum to avoid mixup with max6659
- Fixed register index for temp3_crit_hyst
- Moved lm90_select_remote_channel() to avoid forward declaration of lm90_read_reg()
- Added comment indicating that lm90_select_remote_channel() must be called with update lock held
- Added tempX_emergency_hyst attribute

5 of 7 patches are in this archive. The cover letter announces 7.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
2/7hwmon: (lm90) Introduce device featuredrivers/hwmon/lm90.c+26 -140 replies
4/7hwmon: (lm90) Simplify set_temp11drivers/hwmon/lm90.c+28 -270 replies
5/7hwmon: (lm90) Add explicit support forDocumentation/hwmon/lm90 drivers/hwmon/lm90.c+23 -130 replies
6/7hwmon: (lm90) Add support for extraDocumentation/hwmon/lm90 Documentation/hwmon/sysfs-interface drivers/hwmon/lm90.c+71 -102 replies
7/7hwmon: (lm90) Add support for max6695Documentation/hwmon/lm90 drivers/hwmon/Kconfig drivers/hwmon/lm90.c+247 -243 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [lm-sensors] [PATCH v3 0/7] hwmon: Add support for MAX6695/6696 to

This patchset cleans up the lm90 driver and adds support for Maxim MAX6695/6696 temperature sensors.

In detail,
- Add support for tempX_emergency_alarm ABI attribute
- Introduce device feature bits to reduce runtime overhead
- Introduce function to delete sysfs files
- Simplify calculations in set_temp11()
- Introduce 3rd set of upper temperature limits (named 'emergency' limits)
- Add max6659 support for those limits, and add support for max6659 address 0x4e
- Add max6695/96 support

The patchset depends on the previously submitted lm90 driver cleanup patch.

v2 changes:
- Split patch into multiple parts
- Add support for max6659 address 0x4e and extra features
- Improved max6695/96 device detection code
- max6695/96 does not support extended external limits, so don't try to read them for the 3rd sensor
- Other changes to address review feedback
- Updated Documentation/hwmon/lm90 and drivers/hwmon/Kconfig.
- Fixed alert_alarms comment
- remote offset register not supported on max6658 (fixed comment)
- rewrote set_temp11()
- Added tempX_emergency_alarm attribute
- Some code alignment fixes

v3 changes:
- Express bit masks using shift values instead of hex constants
- Replaced tabs after #define with space
- Negated LM90_HAVE_REM_LIMIT_EXT test
- Reordered patches 5 and 6 (introduce max6659 first, then its extra features)
- Clarified that only max6696 permits multiple I2C addresses
- Use max6696 instead of max6695 in chips enum to avoid mixup with max6659
- Fixed register index for temp3_crit_hyst
- Moved lm90_select_remote_channel() to avoid forward declaration of lm90_read_reg()
- Added comment indicating that lm90_select_remote_channel() must be called with update lock held
- Added tempX_emergency_hyst attribute

Patches unchanged in v3 are listed as v2 patches and are resubmitted for clarity.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors