libsas: Convert to host_lock less w/ interrupts disabled externally
Subsystems (2)
PATCH 4/11 libsas: Convert to host_lock less w/ interrupts disabled externally
From: Nicholas Bellinger <[email protected]>
This patch converts the libsas queuecommand to run in host_lock less mode w/ the new IRQ_DISABLE_SCSI_QCMD() that disables interrupts while calling ->queuecommand() dispatch.
Signed-off-by Nicholas A. Bellinger <[email protected]>
--- drivers/scsi/libsas/sas_scsi_host.c | 11 +++-------- 1 files changed, 3 insertions(+), 8 deletions(-)
drivers/scsi/libsas/sas_scsi_host.c +3 -8
@@ -183,26 +183,22 @@ int sas_queue_up(struct sas_task *task) }/** -* sas_queuecommand -- Enqueue a command for processing +* sas_queuecommand_irq_disable -- Enqueue a command for processing * @parameters: See SCSI Core documentation * * Note: XXX: Remove the host unlock/lock pair when SCSI Core can * call us without holding an IRQ spinlock... */ -static int sas_queuecommand_lck (struct scsi_cmnd *cmd, +static int sas_queuecommand_irq_disable (struct scsi_cmnd *cmd,void (*scsi_done)(struct scsi_cmnd *)) - __releases(host->host_lock) __acquires(dev->sata_dev.ap->lock) __releases(dev->sata_dev.ap->lock) - __acquires(host->host_lock) {int res =0 ;struct domain_device *dev =cmd_to_domain_dev (cmd);struct Scsi_Host *host = cmd->device->host;struct sas_internal *i =to_sas_internal (host->transportt); -spin_unlock_irq (host->host_lock); - {struct sas_ha_struct *sas_ha = dev->port->ha;struct sas_task *task;
@@ -250,11 +246,10 @@ static int sas_queuecommand_lck(struct scsi_cmnd *cmd, } } out: -spin_lock_irq (host->host_lock);return res; } -DEF_SCSI_QCMD (sas_queuecommand) +IRQ_DISABLE_SCSI_QCMD (sas_queuecommand) static void sas_eh_finish_cmd(struct scsi_cmnd *cmd) {
Signature · 1 line
1.7.2.3