Skip to content

RFC First wave of LLD host_lock less conversion

Nicholas A. Bellinger linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest10 of 11 patches 2 repliesIn review

10 of 11 patches are in this archive. The cover letter announces 11.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11libiscsi: Convert to host_lock less w/ interrupts disabled internallydrivers/scsi/libiscsi.c+6 -110 replies
2/11libata: Convert to host_lock less w/ interrupts disabled internallydrivers/ata/libata-scsi.c+4 -102 replies
3/11scsi: Add IRQ_DISABLE_SCSI_QCMD wrapperinclude/scsi/scsi_host.h+15 -00 replies
4/11libsas: Convert to host_lock less w/ interrupts disabled externallydrivers/scsi/libsas/sas_scsi_host.c+3 -80 replies
5/11message: Convert to host_lock less w/ interrupts disabled externallydrivers/message/fusion/mptsas.c drivers/message/fusion/mptscsih.c drivers/message/fusion/mptspi.c+9 -70 replies
6/11mpt2sas: Convert to host_lock less w/ interrupts disabled externallydrivers/scsi/mpt2sas/mpt2sas_scsih.c+3 -30 replies
7/11fnic: Convert to host_lock less w/ interrupts disabled externallydrivers/scsi/fnic/fnic_scsi.c+3 -110 replies
8/11lpfc: Convert to host_lock less w/ interrupts disabled externallydrivers/scsi/lpfc/lpfc_scsi.c+4 -50 replies
9/11qla2xxx: Convert to host_lock less w/ interrupts disabled externallydrivers/scsi/qla2xxx/qla_os.c+3 -80 replies
11/11scsi_debug: Convert to host_lock lessdrivers/scsi/scsi_debug.c+1 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] [PATCH,RFC] First wave of LLD host_lock less conversion

From: Nicholas Bellinger <[email protected]>

Greetings folks,

Following the input of a number of folks over the past 8+ weeks, this series does the conversion of the first wave of libs and LLDs to use host_lock less mode. This patch is based upon jgarzik's full host_lock push down commit 3039f3ffcc5 and the atomic_t Scsi_Host->cmd_serial_number patch from commit bb5df6d08404 in lio-core-2.6.git.

The first and second patches for libiscsi and libata do a conversion to host_lock less whilst using existing internal spin_lock_irqsave(); do_lld_work(); spin_unlock_irqrestore() LLD locks.

The third patch adds a IRQ_DISABLE_SCSI_QCMD wrapper similar to DEF_SCSI_QCMD() that will disable interrupts using local_irq_save() before calling lld_queuecommand_irq_disable().

The forth -> tenth patches convert libsas, message/fusion, mpt2sas, fnic, lpfc, qla2xxx and qla4xxx to run in host_lock less w/ IRQ_DISABLE_SCSI_QCMD(). The final patch drops the usage of DEF_SCSI_QCMD() around scsi_debug, which is fully capable of processing I/O w/o hard interrupts disabled.

This code will be pushed into lio-core-2.6.git/lock_less-LLDs-for-38 shortly, and will be respun as necessary based on LLD maintainer feedback and ACKs.

Thank you!

Nicholas Bellinger (11):
libiscsi: Convert to host_lock less w/ interrupts disabled internally
libata: Convert to host_lock less w/ interrupts disabled internally
scsi: Add IRQ_DISABLE_SCSI_QCMD wrapper
libsas: Convert to host_lock less w/ interrupts disabled externally
message: Convert to host_lock less w/ interrupts disabled externally
mpt2sas: Convert to host_lock less w/ interrupts disabled externally
fnic: Convert to host_lock less w/ interrupts disabled externally
lpfc: Convert to host_lock less w/ interrupts disabled externally
qla2xxx: Convert to host_lock less w/ interrupts disabled externally
qla4xxx: Convert to host_lock less w/ interrupts disabled externally
scsi_debug: Convert to host_lock less

 drivers/ata/libata-scsi.c            |   14 ++++----------
 drivers/message/fusion/mptsas.c      |    4 ++--
 drivers/message/fusion/mptscsih.c    |    8 +++++---
 drivers/message/fusion/mptspi.c      |    4 ++--
 drivers/scsi/fnic/fnic_scsi.c        |   14 +++-----------
 drivers/scsi/libiscsi.c              |   17 ++++++-----------
 drivers/scsi/libsas/sas_scsi_host.c  |   11 +++--------
 drivers/scsi/lpfc/lpfc_scsi.c        |    9 ++++-----
 drivers/scsi/mpt2sas/mpt2sas_scsih.c |    6 +++---
 drivers/scsi/qla2xxx/qla_os.c        |   11 +++--------
 drivers/scsi/qla4xxx/ql4_os.c        |   10 +++-------
 drivers/scsi/scsi_debug.c            |    4 +---
 include/scsi/scsi_host.h             |   15 +++++++++++++++
 13 files changed, 54 insertions(+), 73 deletions(-)
Signature · 1 line
1.7.2.3