Skip to contentSkip to conversation

Devkit8000: Fix build after introduction of GENERATED_GBL_DATA_SIZE

PATCH New Thomas Weber 3 participants 4 messages Nov 18, 2010 – Nov 28, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Devkit8000: Fix build after introduction of GENERATED_GBL_DATA_SIZE

This patch fixes the issue by defining and using CONFIG_SYS_INIT_RAM_SIZE and CONFIG_SYS_INIT_RAM_ADDR.

This patch adopts the
commit 31bfcf1c5776df3d90286aa15104c45096d53dc6 from Steve Sakoman and Sandeep Paulraj on Devkit8000.

---
 include/configs/devkit8000.h |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
include/configs/devkit8000.h +5 -1
index fa7a6c7..d898b77 100644
@@ -308,6 +308,10 @@ extern unsigned int boot_flash_type;
 #endif
 
 #define CONFIG_SYS_SDRAM_BASE          PHYS_SDRAM_1
-#define CONFIG_SYS_INIT_SP_ADDR        (LOW_LEVEL_SRAM_STACK - CONFIG_SYS_GBL_DATA_SIZE)
+#define CONFIG_SYS_INIT_RAM_ADDR        0x4020f800
+#define CONFIG_SYS_INIT_RAM_SIZE        0x800
+#define CONFIG_SYS_INIT_SP_ADDR         (CONFIG_SYS_INIT_RAM_ADDR + \
+		                                         CONFIG_SYS_INIT_RAM_SIZE - \
+		                                         GENERATED_GBL_DATA_SIZE)
 
 #endif /* __CONFIG_H */
Signature · 1 line
1.7.3.2
#1 lore raw

PATCH 1/1 Devkit8000: Fix build after introduction of GENERATED_GBL_DATA_SIZE

Dear Thomas Weber,

Quoted 11 lines · In message <[email protected]> you wrote:

This patch fixes the issue by defining and using CONFIG_SYS_INIT_RAM_SIZE and CONFIG_SYS_INIT_RAM_ADDR.

This patch adopts the
commit 31bfcf1c5776df3d90286aa15104c45096d53dc6 from Steve Sakoman and Sandeep Paulraj on Devkit8000.

---
 include/configs/devkit8000.h |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

Applied, thanks.

Sandeep - hope this is OK with your.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What about WRITING it first and rationalizing it afterwords?  :-)
                       - Larry Wall in <[email protected]>
#2 lore raw

PATCH 1/1 Devkit8000: Fix build after introduction of GENERATED_GBL_DATA_SIZE

Quoted 7 lines

Applied, thanks.

Sandeep - hope this is OK with your.
Best regards,
Wolfgang Denk

no problem.

I was going to send a pull request for this along with my 3 patches

Are you going to pull the 3 patches i sent yesterday or do you want a pull request

my patches will result in more boards building

Thanks,
Sandeep

#3 lore raw

PATCH 1/1 Devkit8000: Fix build after introduction of GENERATED_GBL_DATA_SIZE

Dear "Paulraj, Sandeep",

Quoted 8 lines · In message <[email protected]> you…

I was going to send a pull request for this along with my 3 patches

Are you going to pull the 3 patches i sent yesterday or do you want a pull = request

my patches will result in more boards building

If I have your "go" I can apply these directly, thanks.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Until you walk a mile in another man's moccasins, you can't imagine the smell.