ocfs2_connection_find() returns pointer to bad structure
PATCH 1/1 ocfs2_connection_find() returns pointer to bad structure
If ocfs2_live_connection_list is empty, ocfs2_connection_find() will return a pointer to the LIST_HEAD, cast as a ocfs2_live_connection. This can cause an oops when ocfs2_control_send_down() dereferences c->oc_conn:
Call Trace: [<ffffffffa00c2a3c>] ocfs2_control_message+0x28c/0x2b0 [ocfs2_stack_user] [<ffffffffa00c2a95>] ocfs2_control_write+0x35/0xb0 [ocfs2_stack_user] [<ffffffff81143a88>] vfs_write+0xb8/0x1a0 [<ffffffff8155cc13>] ? do_page_fault+0x153/0x3b0 [<ffffffff811442f1>] sys_write+0x51/0x80 [<ffffffff810121b2>] system_call_fastpath+0x16/0x1b
Fix by explicitly returning NULL if no match is found.
Signed-off-by dann frazier <[email protected]>
--- fs/ocfs2/stack_user.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fs/ocfs2/stack_user.c +1 -1
@@ -190,7 +190,7 @@ static struct ocfs2_live_connection *ocfs2_connection_find(const char *name)return c; } -return c; +return NULL ; }/*
Signature · 1 line
1.7.2.3
Quoted 12 lines · dann frazier
If
ocfs2_live_connection_listis empty,ocfs2_connection_find()will return a pointer to theLIST_HEAD, cast as aocfs2_live_connection. This can cause an oops whenocfs2_control_send_down()dereferencesc->oc_conn:Call Trace: [<ffffffffa00c2a3c>] ocfs2_control_message+0x28c/0x2b0 [ocfs2_stack_user] [<ffffffffa00c2a95>] ocfs2_control_write+0x35/0xb0 [ocfs2_stack_user] [<ffffffff81143a88>] vfs_write+0xb8/0x1a0 [<ffffffff8155cc13>] ? do_page_fault+0x153/0x3b0 [<ffffffff811442f1>] sys_write+0x51/0x80 [<ffffffff810121b2>] system_call_fastpath+0x16/0x1b
Quoted 3 lines
Fix by explicitly returning NULL if no match is found.
Signed-off-by dann frazier <[email protected]>
This patch is now in the fixes branch of ocfs2.git.
Joel
Signature · 8 lines
"I don't even butter my bread; I consider that cooking."
- Katherine Cebrian
Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127