Skip to contentSkip to conversation

arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check

PATCH In review Vasiliy Kulikov 3 participants 3 messages Nov 26, 2010 – Dec 6, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check

clk_get() returns ERR_PTR() on error, not NULL.

---
Cannot compile this driver, so it is not tested at all.

 arch/arm/plat-omap/counter_32k.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/counter_32k.c +1 -1
index 155fe43..c1e0d00 100644
@@ -164,7 +164,7 @@ static int __init omap_init_clocksource_32k(void)
 			return -ENODEV;
 
 		sync_32k_ick = clk_get(NULL, "omap_32ksync_ick");
-		if (sync_32k_ick)
+		if (!IS_ERR(sync_32k_ick))
 			clk_enable(sync_32k_ick);
 
 		clocksource_32k.mult = clocksource_hz2mult(32768,
Signature · 1 line
1.7.0.4
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Vasiliy Kulikov

clk_get() returns ERR_PTR() on error, not NULL.

Quoted 19 lines

---
Cannot compile this driver, so it is not tested at all.

 arch/arm/plat-omap/counter_32k.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/counter_32k.c +1 -1
index 155fe43..c1e0d00 100644
@@ -164,7 +164,7 @@ static int __init omap_init_clocksource_32k(void)
 			return -ENODEV;
 
 		sync_32k_ick = clk_get(NULL, "omap_32ksync_ick");
-		if (sync_32k_ick)
+		if (!IS_ERR(sync_32k_ick))
 			clk_enable(sync_32k_ick);
 
 		clocksource_32k.mult = clocksource_hz2mult(32768,
#2 lore raw
In reply to Vasiliy Kulikov
Quoted 5 lines · Vasiliy Kulikov

clk_get() returns ERR_PTR() on error, not NULL.

---
Cannot compile this driver, so it is not tested at all.

Thanks will merge this.

Tony

Quoted 20 lines
 arch/arm/plat-omap/counter_32k.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/counter_32k.c +1 -1
index 155fe43..c1e0d00 100644
@@ -164,7 +164,7 @@ static int __init omap_init_clocksource_32k(void)
 			return -ENODEV;
 
 		sync_32k_ick = clk_get(NULL, "omap_32ksync_ick");
-		if (sync_32k_ick)
+		if (!IS_ERR(sync_32k_ick))
 			clk_enable(sync_32k_ick);
 
 		clocksource_32k.mult = clocksource_hz2mult(32768,
Signature · 1 line
1.7.0.4