arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
Subsystems (3)
PATCH 1/1 arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
clk_get() returns ERR_PTR() on error, not NULL.
Signed-off-by Vasiliy Kulikov <[email protected]>
---
Cannot compile this driver, so it is not tested at all.
arch/arm/plat-omap/counter_32k.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/counter_32k.c +1 -1
@@ -164,7 +164,7 @@ static int __init omap_init_clocksource_32k(void)return -ENODEV ; sync_32k_ick =clk_get (NULL ,"omap_32ksync_ick" ); -if (sync_32k_ick) +if (!IS_ERR (sync_32k_ick))clk_enable (sync_32k_ick); clocksource_32k.mult = clocksource_hz2mult(32768,
Signature · 1 line
1.7.0.4
Quoted 3 lines · Vasiliy Kulikov
clk_get()returnsERR_PTR()on error, not NULL.Signed-off-by Vasiliy Kulikov <[email protected]>
Acked-by Kevin Hilman <[email protected]>
Quoted 19 lines
---
Cannot compile this driver, so it is not tested at all.arch/arm/plat-omap/counter_32k.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-omap/counter_32k.c +1
-1@@ -164,7 +164,7 @@ static int __init omap_init_clocksource_32k(void)return -ENODEV ; sync_32k_ick =clk_get (NULL ,"omap_32ksync_ick" ); -if (sync_32k_ick) +if (!IS_ERR (sync_32k_ick))clk_enable (sync_32k_ick); clocksource_32k.mult = clocksource_hz2mult(32768,
Quoted 5 lines · Vasiliy Kulikov
clk_get()returnsERR_PTR()on error, not NULL.Signed-off-by Vasiliy Kulikov <[email protected]>---
Cannot compile this driver, so it is not tested at all.
Thanks will merge this.
Tony
Quoted 20 lines
arch/arm/plat-omap/counter_32k.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/plat-omap/counter_32k.c +1
-1@@ -164,7 +164,7 @@ static int __init omap_init_clocksource_32k(void)return -ENODEV ; sync_32k_ick =clk_get (NULL ,"omap_32ksync_ick" ); -if (sync_32k_ick) +if (!IS_ERR (sync_32k_ick))clk_enable (sync_32k_ick); clocksource_32k.mult = clocksource_hz2mult(32768,Signature · 1 line
1.7.0.4