Skip to contentSkip to conversation

ath9k: Check for NULL sta in ath_tx_start

PATCH New greearb at gmail.com 4 participants 9 messages Dec 7, 2010 – Dec 8, 2010 Qualcomm Atheros ATH9K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath9k: Check for NULL sta in ath_tx_start

From: Ben Greear <[email protected]>

It can be NULL according to docs, and logging showed it to be NULL in practice.

---
:100644 100644 8b0b076... 5ddca08... M drivers/net/wireless/ath/ath9k/xmit.c

 drivers/net/wireless/ath/ath9k/xmit.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/net/wireless/ath/ath9k/xmit.c +4 -1
index 8b0b076..5ddca08 100644
@@ -1764,7 +1764,10 @@ int ath_tx_start(struct ieee80211_hw *hw, struct sk_buff *skb,
 	int frmlen = skb->len + FCS_LEN;
 	int q;
 
-	txctl->an = (struct ath_node *)sta->drv_priv;
+	/* NOTE:  sta can be NULL according to net/mac80211.h */
+	if (sta)
+		txctl->an = (struct ath_node *)sta->drv_priv;
+
 	if (info->control.hw_key)
 		frmlen += info->control.hw_key->icv_len;
 
Signature · 1 line
1.7.2.3
#2 lore raw

PATCH 1/1 ath9k: Check for NULL sta in ath_tx_start

Quoted 10 lines · Luis R. Rodriguez
Quoted 6 lines · On Mon, Dec 6, 2010 at 9:13 PM,<[email protected]> wrote:

From: Ben Greear<[email protected]>

It can be NULL according to docs, and logging showed it to be NULL in practice.

Does this fix an oops? If so can you explain and provide the trace and resubmit and cc stable in the commit log?

I think it fixes the TID corruption I posted about earlier. It seems so obvious though, that I'm curious why no one else sees problems, and why I didn't see more crashes in my setup.

(The paprd code appears to send with null STA, for instance, and my printks showed lots of NULL stas in my 16-sta test setup, though I don't think I'm using the paprd code path.)

I'll test some more and re-post tomorrow if all goes well.

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
#3 lore raw

PATCH 1/1 ath9k: Check for NULL sta in ath_tx_start

Quoted 12 lines · Ben Greear
Quoted 10 lines · Luis R. Rodriguez
Quoted 6 lines · On Mon, Dec 6, 2010 at 9:13 PM,<[email protected]> wrote:

From: Ben Greear<[email protected]>

It can be NULL according to docs, and logging showed it to be NULL in practice.

Does this fix an oops? If so can you explain and provide the trace and resubmit and cc stable in the commit log?

Quoted 7 lines

I think it fixes the TID corruption I posted about earlier. It seems so obvious though, that I'm curious why no one else sees problems, and why I didn't see more crashes in my setup.

(The paprd code appears to send with null STA, for instance, and my printks showed lots of NULL stas in my 16-sta test setup, though I don't think I'm using the paprd code path.)

paprd is used only with >= AR9003.

Vasanth

#4 lore raw

PATCH 1/1 ath9k: Check for NULL sta in ath_tx_start

Quoted 17 lines · Vasanthakumar Thiagarajan
Quoted 16 lines · Ben Greear
Quoted 10 lines · Luis R. Rodriguez
Quoted 6 lines · On Mon, Dec 6, 2010 at 9:13 PM,<[email protected]> wrote:

From: Ben Greear<[email protected]>

It can be NULL according to docs, and logging showed it to be NULL in practice.

Does this fix an oops? If so can you explain and provide the trace and resubmit and cc stable in the commit log?

I think it fixes the TID corruption I posted about earlier. It seems so obvious though, that I'm curious why no one else sees problems, and why I didn't see more crashes in my setup.

Quoted 5 lines
Quoted 3 lines

(The paprd code appears to send with null STA, for instance, and my printks showed lots of NULL stas in my 16-sta test setup, though I don't think I'm using the paprd code path.)

paprd is used only with>= AR9003.

Whoever coded it up hopefully had that hardware...so why didn't they see lots of crashes?

Thanks,
Ben

Quoted 2 lines

Vasanth

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
#5 lore raw

PATCH 1/1 ath9k: Check for NULL sta in ath_tx_start

Quoted 18 lines · Ben Greear
Quoted 17 lines · Vasanthakumar Thiagarajan
Quoted 16 lines · Ben Greear
Quoted 10 lines · Luis R. Rodriguez
Quoted 6 lines · On Mon, Dec 6, 2010 at 9:13 PM,<[email protected]> wrote:

From: Ben Greear<[email protected]>

It can be NULL according to docs, and logging showed it to be NULL in practice.

Does this fix an oops? If so can you explain and provide the trace and resubmit and cc stable in the commit log?

I think it fixes the TID corruption I posted about earlier. It seems so obvious though, that I'm curious why no one else sees problems, and why I didn't see more crashes in my setup.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

(The paprd code appears to send with null STA, for instance, and my printks showed lots of NULL stas in my 16-sta test setup, though I don't think I'm using the paprd code path.)

paprd is used only with>= AR9003.

Whoever coded it up hopefully had that hardware...so why didn't they see lots of crashes?

I myself tested it lot of times, but did not see any crash, weird.

Vasanth

Quoted 11 lines

Thanks,
Ben

Quoted 2 lines

Vasanth

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
#6 lore raw

PATCH 1/1 ath9k: Check for NULL sta in ath_tx_start

Quoted 23 lines · Vasanthakumar Thiagarajan
Quoted 22 lines · Ben Greear
Quoted 21 lines · Vasanthakumar Thiagarajan
Quoted 19 lines · Ben Greear
Quoted 10 lines · Luis R. Rodriguez
Quoted 6 lines · On Mon, Dec 6, 2010 at 9:13 PM,<[email protected]> wrote:

From: Ben Greear<[email protected]>

It can be NULL according to docs, and logging showed it to be NULL in practice.

Does this fix an oops? If so can you explain and provide the trace and resubmit and cc stable in the commit log?

I think it fixes the TID corruption I posted about earlier. It seems so obvious though, that I'm curious why no one else sees problems, and why I didn't see more crashes in my setup.

(The paprd code appears to send with null STA, for instance, and my printks showed lots of NULL stas in my 16-sta test setup, though I don't think I'm using the paprd code path.)

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

paprd is used only with>= AR9003.

Whoever coded it up hopefully had that hardware...so why didn't they see lots of crashes?

I myself tested it lot of times, but did not see any crash, weird.

Looks like the offending change when in recently (11/4/10, one of Felix's patches).

That is probably why no one else is hitting this yet, and it isn't needed for stable I'm guessing....

Thanks,
Ben

Quoted 18 lines

Vasanth

Quoted 11 lines

Thanks,
Ben

Quoted 2 lines

Vasanth

--
Ben Greear<[email protected]>
Candela Technologies Inc http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
#7 lore raw

PATCH 1/1 ath9k: Check for NULL sta in ath_tx_start

Quoted 29 lines · Ben Greear
Quoted 28 lines · Vasanthakumar Thiagarajan
Quoted 26 lines · Ben Greear
Quoted 17 lines · Vasanthakumar Thiagarajan
Quoted 16 lines · Ben Greear
Quoted 10 lines · Luis R. Rodriguez
Quoted 6 lines · On Mon, Dec 6, 2010 at 9:13 PM,<[email protected]> wrote:

From: Ben Greear<[email protected]>

It can be NULL according to docs, and logging showed it to be NULL in practice.

Does this fix an oops? If so can you explain and provide the trace and resubmit and cc stable in the commit log?

I think it fixes the TID corruption I posted about earlier. It seems so obvious though, that I'm curious why no one else sees problems, and why I didn't see more crashes in my setup.

Quoted 5 lines
Quoted 3 lines

(The paprd code appears to send with null STA, for instance, and my printks showed lots of NULL stas in my 16-sta test setup, though I don't think I'm using the paprd code path.)

paprd is used only with>= AR9003.

Whoever coded it up hopefully had that hardware...so why didn't they see lots of crashes?

Quoted 7 lines
Quoted 1 line

I myself tested it lot of times, but did not see any crash, weird.

Looks like the offending change when in recently (11/4/10, one of Felix's patches).

That is probably why no one else is hitting this yet, and it isn't needed for stable I'm guessing....

Nice, care to send a patch?. Yeah, it is not needed for stable.

Vasanth

#8 lore raw

PATCH 1/1 ath9k: Check for NULL sta in ath_tx_start

Quoted 32 lines · Vasanthakumar Thiagarajan
Quoted 31 lines · Ben Greear
Quoted 29 lines · Vasanthakumar Thiagarajan
Quoted 18 lines · Ben Greear
Quoted 17 lines · Vasanthakumar Thiagarajan
Quoted 16 lines · Ben Greear
Quoted 10 lines · Luis R. Rodriguez
Quoted 6 lines · On Mon, Dec 6, 2010 at 9:13 PM,<[email protected]> wrote:

From: Ben Greear<[email protected]>

It can be NULL according to docs, and logging showed it to be NULL in practice.

Does this fix an oops? If so can you explain and provide the trace and resubmit and cc stable in the commit log?

I think it fixes the TID corruption I posted about earlier. It seems so obvious though, that I'm curious why no one else sees problems, and why I didn't see more crashes in my setup.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

(The paprd code appears to send with null STA, for instance, and my printks showed lots of NULL stas in my 16-sta test setup, though I don't think I'm using the paprd code path.)

paprd is used only with>= AR9003.

Whoever coded it up hopefully had that hardware...so why didn't they see lots of crashes?

I myself tested it lot of times, but did not see any crash, weird.

Quoted 7 lines
Quoted 5 lines

Looks like the offending change when in recently (11/4/10, one of Felix's patches).

That is probably why no one else is hitting this yet, and it isn't needed for stable I'm guessing....

Nice, care to send a patch?. Yeah, it is not needed for stable.

The same patch I originally posted to to start this thread should do just fine.

If someone really wants an oops report, I can add an artificial BUG_ON to catch this, but for whatever reason, it normally just crashes things weirdly and perhaps sometimes screwed up the file-system, so I'd rather just have the patch go in as it is..I think it is obviously more correct than the existing code.

Thanks,
Ben

Quoted 2 lines

Vasanth

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com