fbdev: Fix fb_find_nearest_mode refresh comparison
PATCH 1/1 fbdev: Fix fb_find_nearest_mode refresh comparison
Refresh rate nearness is not calculated or reset when nearest resolution changes.
This patch resets the refresh rate differential measurement whenever a new nearest resolution is discovered. This fixes two error cases; first, wherein the first mode's refresh rate differential is never calculated and second, when the closest refresh rate from a previous nearest resolution is erroneously preserved.
-andrew
drivers/video/modedb.c +0 -0
@@ -902,6 +902,7 @@ const struct fb_videomode
*fb_find_nearest_mode(const struct fb_videomode *mode,
abs(cmode->yres - mode->yres);
if (diff > d) {
diff = d;
+ diff_refresh = abs(cmode->refresh - mode->refresh);
best = cmode;
} else if (diff = d) {
d = abs(cmode->refresh - mode->refresh);ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±ıöİzÿâ�Ø^n‡r¡ö¦zË�ëh™¨èÚ&£ûàz¿äz¹Ş—ú+€Ê+zf£¢·hšˆ§~††Ûiÿÿï�êÿ‘êçz_è®æj:+v‰¨ş)ߣøm
Quoted 9 lines · Andrew Kephart
Refresh rate nearness is not calculated or reset when nearest resolution changes.
This patch resets the refresh rate differential measurement whenever a new nearest resolution is discovered. This fixes two error cases; first, wherein the first mode's refresh rate differential is never calculated and second, when the closest refresh rate from a previous nearest resolution is erroneously preserved.
You're missing a signed-off-by tag.
Refresh rate nearness is not calculated or reset when nearest resolution changes.
This patch resets the refresh rate differential measurement whenever a new nearest resolution is discovered. This fixes two error cases; first, wherein the first mode's refresh rate differential is never calculated and second, when the closest refresh rate from a previous nearest resolution is erroneously preserved.
---
drivers/video/modedb.c +0 -0
@@ -902,6 +902,7 @@ const struct fb_videomode
*fb_find_nearest_mode(const struct fb_videomode *mode,
abs(cmode->yres - mode->yres);
if (diff > d) {
diff = d;
+ diff_refresh = abs(cmode->refresh -
mode->refresh);
best = cmode;
} else if (diff = d) {
d = abs(cmode->refresh - mode->refresh);Quoted 10 lines · Andrew Kephart
Refresh rate nearness is not calculated or reset when nearest resolution changes.
This patch resets the refresh rate differential measurement whenever a new nearest resolution is discovered. This fixes two error cases; first, wherein the first mode's refresh rate differential is never calculated and second, when the closest refresh rate from a previous nearest resolution is erroneously preserved.
Signed-off-by Andrew Kephart <[email protected]>
The patch itself is line-wrapped, so please check your mailer settings for future patches. I've applied it by hand this time, thanks.
Paul,
Thanks, will do.
-andrew
Quoted 6 lines · Paul Mundt
The patch itself is line-wrapped, so please check your mailer settings for future patches. I've applied it by hand this time, thanks. --
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html