Skip to contentSkip to conversation

fbdev: Fix fb_find_nearest_mode refresh comparison

PATCH In review Andrew Kephart 2 participants 5 messages Dec 10, 2010 – Dec 14, 2010 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fbdev: Fix fb_find_nearest_mode refresh comparison

Refresh rate nearness is not calculated or reset when nearest resolution changes.

This patch resets the refresh rate differential measurement whenever a new nearest resolution is discovered. This fixes two error cases; first, wherein the first mode's refresh rate differential is never calculated and second, when the closest refresh rate from a previous nearest resolution is erroneously preserved.

-andrew

drivers/video/modedb.c +0 -0
index c3a1825..7a61ba6 100644
@@ -902,6 +902,7 @@ const struct fb_videomode

*fb_find_nearest_mode(const struct fb_videomode *mode,

                        abs(cmode->yres - mode->yres);
                if (diff > d) {
                        diff = d;
+                       diff_refresh = abs(cmode->refresh -  mode->refresh);
                        best = cmode;
                } else if (diff = d) {
                        d = abs(cmode->refresh - mode->refresh);

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±ıöİzÿâ�Ø^n‡r¡ö¦zË�ëh™¨è­Ú&£ûàz¿äz¹Ş—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿï�êÿ‘êçz_è®æj:+v‰¨ş)ߣøm

#1 lore raw
Quoted 9 lines · Andrew Kephart

Refresh rate nearness is not calculated or reset when nearest resolution changes.

This patch resets the refresh rate differential measurement whenever a new nearest resolution is discovered. This fixes two error cases; first, wherein the first mode's refresh rate differential is never calculated and second, when the closest refresh rate from a previous nearest resolution is erroneously preserved.

You're missing a signed-off-by tag.

#2 lore raw
In reply to Andrew Kephart

Refresh rate nearness is not calculated or reset when nearest resolution changes.

This patch resets the refresh rate differential measurement whenever a new nearest resolution is discovered. This fixes two error cases; first, wherein the first mode's refresh rate differential is never calculated and second, when the closest refresh rate from a previous nearest resolution is erroneously preserved.

---

drivers/video/modedb.c +0 -0
index c3a1825..7a61ba6 100644
@@ -902,6 +902,7 @@ const struct fb_videomode

*fb_find_nearest_mode(const struct fb_videomode *mode,

                        abs(cmode->yres - mode->yres);
                if (diff > d) {
                        diff = d;
+                       diff_refresh = abs(cmode->refresh -
mode->refresh);
                        best = cmode;
                } else if (diff = d) {
                        d = abs(cmode->refresh - mode->refresh);
#3 lore raw
In reply to Andrew Kephart
Quoted 10 lines · Andrew Kephart

Refresh rate nearness is not calculated or reset when nearest resolution changes.

This patch resets the refresh rate differential measurement whenever a new nearest resolution is discovered. This fixes two error cases; first, wherein the first mode's refresh rate differential is never calculated and second, when the closest refresh rate from a previous nearest resolution is erroneously preserved.

The patch itself is line-wrapped, so please check your mailer settings for future patches. I've applied it by hand this time, thanks.