Go to common initdram() on 85xx-based boards
v3 cover Go to common initdram() on 85xx-based boards
This patch series consists of a bunch of cleanups that allow us to use a common initdram() on all of the non-corenet 85xx-based boards. Also, switch to using phys_size_t to represent the size of memory returned.
Most of these patches are just code rearranges or renaming things to get a common scheme in place. There are also lots of cleanups - the various initdram() implementations had a variety of issues that I have hopefully fixed.
This is a large patch series, and I've had to hack on a bunch of different boards that I know nothing about, so I'd appreciate any review commentary. I have tested this on 8572DS and confirmed that the results of a MAKEALL powerpc are the same before and after this series.
Changes from V1:
- Removed prints from initdram() as suggested by Peter
- Changed spacing of 36-bit DRAM size warning messages to better line up after the removal of the excess prints from initdram()
- Switched sdram_init() to be a weak function
- renamed sdram_init() to lbc_sdram_init()
Changes from V2:
- dropped boards that Kumar is removing
- changed spacing of printouts from lbc_sdram_init
- added the "DDR:" back to the boot messages - it makes sense to have this for some boards, and it's not much clutter
- renamed the DDR_WIMGE define per feedback
Diffstat below.
Cheers,
Becly
arch/powerpc/cpu/mpc85xx/cmd_errata.c | 3 + arch/powerpc/cpu/mpc85xx/cpu.c | 52 +++++++++++++++++ arch/powerpc/cpu/mpc85xx/tlb.c | 6 ++- arch/powerpc/cpu/mpc8xxx/ddr/main.c | 5 +- arch/powerpc/cpu/mpc8xxx/fsl_lbc.c | 10 +++ arch/powerpc/include/asm/fsl_ddr_sdram.h | 13 ++++ arch/powerpc/include/asm/fsl_lbc.h | 4 + board/freescale/mpc8536ds/mpc8536ds.c | 21 ------- board/freescale/mpc8540ads/mpc8540ads.c | 61 ++------------------ board/freescale/mpc8540ads/tlb.c | 19 ------ board/freescale/mpc8541cds/mpc8541cds.c | 52 +--------------- board/freescale/mpc8544ds/mpc8544ds.c | 17 ------ board/freescale/mpc8548cds/mpc8548cds.c | 47 +-------------- board/freescale/mpc8555cds/mpc8555cds.c | 54 +---------------- board/freescale/mpc8560ads/mpc8560ads.c | 61 ++------------------ board/freescale/mpc8560ads/tlb.c | 19 ------ board/freescale/mpc8568mds/mpc8568mds.c | 47 +-------------- board/freescale/mpc8569mds/mpc8569mds.c | 36 ------------ board/freescale/mpc8572ds/mpc8572ds.c | 19 ------ board/freescale/p1022ds/p1022ds.c | 13 ---- board/freescale/p1_p2_rdb/ddr.c | 15 +----- board/freescale/p2020ds/p2020ds.c | 34 ++--------- board/sbc8548/sbc8548.c | 48 +--------------- board/sbc8548/tlb.c | 34 ++++------- board/sbc8560/sbc8560.c | 93 +----------------------------- board/socrates/sdram.c | 15 +----- board/stx/stxgp3/stxgp3.c | 32 ---------- board/stx/stxssa/stxssa.c | 33 ----------- board/tqc/tqm85xx/sdram.c | 70 +++++++---------------- board/tqc/tqm85xx/tlb.c | 47 --------------- board/xes/common/Makefile | 2 - board/xes/common/fsl_8xxx_ddr.c | 46 --------------- board/xes/xpedite517x/xpedite517x.c | 13 ++++ doc/README.mpc85xxads | 4 +- include/configs/MPC8536DS.h | 1 - include/configs/MPC8548CDS.h | 2 +- include/configs/MPC8572DS.h | 1 - include/configs/P1_P2_RDB.h | 1 - include/configs/SBC8540.h | 2 +- include/configs/TQM85xx.h | 6 ++- include/configs/sbc8560.h | 2 +- include/configs/stxgp3.h | 2 +- include/configs/stxssa.h | 1 - 43 files changed, 185 insertions(+), 878 deletions(-)
PATCH v3 1/6 tqm85xx: create fixed_sdram() to do sdram setup
Also, change this code to use phys_size_t instead of long int. Using common naming for this function will enable us to use the common initdram() for 85xx going forward. Other than the type change, this is just a code rearrange.
--- board/tqc/tqm85xx/sdram.c | 37 +++++++++++++++++++++++-------------- 1 files changed, 23 insertions(+), 14 deletions(-)
board/tqc/tqm85xx/sdram.c +23 -14
@@ -65,6 +65,7 @@ sdram_conf_t ddr_cs_conf[] = {#define N_DDR_CS_CONF (sizeof(ddr_cs_conf) / sizeof(ddr_cs_conf[0]))int cas_latency (void ); +static phys_size_t sdram_setup (int );/* * Autodetect onboard DDR SDRAM on 85xx platforms
@@ -73,7 +74,26 @@ int cas_latency (void);* so this should be extended for other future boards * using this routine! */ -long int sdram_setup (int casl) +phys_size_t fixed_sdram (void ) +{ +int casl =0 ; +phys_size_t dram_size =0 ; + + casl =cas_latency (); + dram_size =sdram_setup (casl); +if ((dram_size ==0 ) && (casl !=CONFIG_DDR_DEFAULT_CL )) { +/* +* Try again with default CAS latency +*/ +printf ("Problem with CAS lantency, using default CL %d/10!\n" , +CONFIG_DDR_DEFAULT_CL ); + dram_size =sdram_setup (CONFIG_DDR_DEFAULT_CL ); +puts (" " ); + } +return dram_size; +} + +static phys_size_t sdram_setup (int casl) {int i;volatile ccsr_ddr_t *ddr = (void *)(CONFIG_SYS_MPC85xx_DDR_ADDR);
@@ -376,8 +396,7 @@ long int sdram_setup (int casl)phys_size_t initdram (int board_type) { -long dram_size =0 ; -int casl; +phys_size_t dram_size =0 ;#if defined(CONFIG_DDR_DLL )/*
@@ -407,17 +426,7 @@ phys_size_t initdram (int board_type) }#endif - casl =cas_latency (); - dram_size =sdram_setup (casl); -if ((dram_size ==0 ) && (casl !=CONFIG_DDR_DEFAULT_CL )) { -/* -* Try again with default CAS latency -*/ -printf ("Problem with CAS lantency, using default CL %d/10!\n" , -CONFIG_DDR_DEFAULT_CL ); - dram_size =sdram_setup (CONFIG_DDR_DEFAULT_CL ); -puts (" " ); - } + dram_size =fixed_sdram ();return dram_size; }
Signature · 1 line
1.5.6.5
PATCH v3 2/6 mpc85xx/tlb.c: Allow platforms to specify wimge bits
Some platforms might want to override the default wimge=0 for DDR. Add CONFIG_SYS_PPC_DDR_WIMGE for those platforms to use. This will initially only be used by TQM85xx, but could be useful for other boards or testing going forward. Note that the name of this define is not 85xx-specific. WIMGE is a fairly universal concept, so any ppc platforms that require different WIMGE settings for DDR can use the same #define.
--- arch/powerpc/cpu/mpc85xx/tlb.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
arch/powerpc/cpu/mpc85xx/tlb.c +5 -1
@@ -250,10 +250,14 @@ setup_ddr_tlbs_phys(phys_addr_t p_addr, unsigned int memsize_in_meg) {int i;unsigned int tlb_size; +unsigned int wimge =0 ;unsigned int ram_tlb_address = (unsigned int )CONFIG_SYS_DDR_SDRAM_BASE ;unsigned int max_cam = (mfspr (SPRN_TLB1CFG ) >>16 ) &0xf ;u64 size, memsize = (u64 )memsize_in_meg <<20 ; +#ifdef CONFIG_SYS_PPC_DDR_WIMGE + wimge =CONFIG_SYS_PPC_DDR_WIMGE ; +#endif size =min (memsize,CONFIG_MAX_MEM_MAPPED );/* Convert (4^max) kB to (2^max) bytes */
@@ -277,7 +281,7 @@ setup_ddr_tlbs_phys(phys_addr_t p_addr, unsigned int memsize_in_meg) tlb_size = (camsize -10 ) /2 ;set_tlb (1 , ram_tlb_address, p_addr, -MAS3_SX |MAS3_SW |MAS3_SR ,0 , +MAS3_SX |MAS3_SW |MAS3_SR , wimge,0 , ram_tlb_index, tlb_size,1 ); size -=1ULL << camsize;
Signature · 1 line
1.5.6.5
PATCH v3 3/6 mpc85xx boards: initdram() cleanup/bugfix
Correct initdram to use phys_size_t to represent the size of dram; instead of changing this all over the place, and correcting all the other random errors I've noticed, create a
common initdram that is used by all non-corenet 85xx parts. Most of the initdram() functions were identical, with 2 common differences:
1) DDR tlbs for the fixed_sdram case were set up in initdram() on some boards, and were part of the tlb_table on others. I have changed them all over to the initdram() method - we shouldn't be accessing dram before this point so they don't need to be done sooner, and this seems cleaner.
2) Parts that require the DDR11 erratum workaround had different implementations - I have adopted the version from the Freescale errata document. It also looks like some of the versions were buggy, and, depending on timing, could have resulted in the DDR controller being disabled. This seems bad.
The xpedite boards had a common/fsl_8xxx_ddr.c; with this change only the 517 board uses this so I have moved the ddr code into that board's directory in xpedite517x.c
The ATUM8548 board didn't appear to set up any tlbs in the fixed_sdram case; this patch fixes that.
--- arch/powerpc/cpu/mpc85xx/cpu.c | 52 +++++++++++++++++ arch/powerpc/cpu/mpc8xxx/fsl_lbc.c | 10 +++ arch/powerpc/include/asm/fsl_ddr_sdram.h | 13 ++++ arch/powerpc/include/asm/fsl_lbc.h | 4 + board/freescale/mpc8536ds/mpc8536ds.c | 21 ------- board/freescale/mpc8540ads/mpc8540ads.c | 52 +---------------- board/freescale/mpc8540ads/tlb.c | 19 ------ board/freescale/mpc8541cds/mpc8541cds.c | 43 -------------- board/freescale/mpc8544ds/mpc8544ds.c | 17 ------ board/freescale/mpc8548cds/mpc8548cds.c | 38 ------------ board/freescale/mpc8555cds/mpc8555cds.c | 45 -------------- board/freescale/mpc8560ads/mpc8560ads.c | 52 +---------------- board/freescale/mpc8560ads/tlb.c | 19 ------ board/freescale/mpc8568mds/mpc8568mds.c | 38 ------------ board/freescale/mpc8569mds/mpc8569mds.c | 36 ------------ board/freescale/mpc8572ds/mpc8572ds.c | 19 ------ board/freescale/p1022ds/p1022ds.c | 13 ---- board/freescale/p1_p2_rdb/ddr.c | 15 +----- board/freescale/p2020ds/p2020ds.c | 34 ++--------- board/sbc8548/sbc8548.c | 45 +-------------- board/sbc8548/tlb.c | 34 ++++------- board/sbc8560/sbc8560.c | 93 +----------------------------- board/socrates/sdram.c | 15 +----- board/stx/stxgp3/stxgp3.c | 32 ---------- board/stx/stxssa/stxssa.c | 33 ----------- board/tqc/tqm85xx/sdram.c | 37 ------------ board/tqc/tqm85xx/tlb.c | 47 --------------- board/xes/common/Makefile | 2 - board/xes/common/fsl_8xxx_ddr.c | 46 --------------- board/xes/xpedite517x/xpedite517x.c | 13 ++++ include/configs/TQM85xx.h | 4 + 31 files changed, 121 insertions(+), 820 deletions(-) delete mode 100644 board/xes/common/fsl_8xxx_ddr.c
arch/powerpc/cpu/mpc85xx/cpu.c +52 -0
@@ -34,6 +34,7 @@#include <asm/io.h> #include <asm/mmu.h> #include <asm/fsl_law.h> +#include <asm/fsl_lbc.h> #include <post.h> #include <asm/processor.h> #include <asm/fsl_ddr_sdram.h>
@@ -286,6 +287,57 @@ void mpc85xx_reginfo(void)print_lbc_regs (); } +/* Common ddr init for non-corenet fsl 85xx platforms */ +#ifndef CONFIG_FSL_CORENET +phys_size_t initdram (int board_type) +{ +phys_size_t dram_size =0 ; + +#if defined(CONFIG_DDR_DLL ) + { +ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR); +unsigned int x =10 ; +unsigned int i; + +/* +* Work around to stabilize DDR DLL +*/ +out_be32 (&gur->ddrdllcr,0x81000000 ); + asm("sync;isync;msync" ); +udelay (200 ); +while (in_be32 (&gur->ddrdllcr) !=0x81000100 ) { +setbits_be32 (&gur->devdisr,0x00010000 ); +for (i =0 ; i < x; i++) + ; +clrbits_be32 (&gur->devdisr,0x00010000 ); + x++; + } + } +#endif + +#if defined(CONFIG_SPD_EEPROM ) || defined(CONFIG_DDR_SPD ) + dram_size =fsl_ddr_sdram (); +#else + dram_size =fixed_sdram (); +#endif + dram_size =setup_ddr_tlbs (dram_size /0x100000 ); + dram_size *=0x100000 ; + +#if defined(CONFIG_DDR_ECC ) && !defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER ) +/* +* Initialize and enable DDR ECC. +*/ +ddr_enable_ecc (dram_size); +#endif + +/* Some boards also have sdram on the lbc */ +sdram_init (); + +puts ("DDR: " ); +return dram_size; +} +#endif +#if CONFIG_POST &CONFIG_SYS_POST_MEMORY /* Board-specific functions defined in each board's ddr.c */
arch/powerpc/cpu/mpc8xxx/fsl_lbc.c +10 -0
@@ -9,6 +9,16 @@#include <common.h> #include <asm/fsl_lbc.h> +#ifdef CONFIG_MPC85xx +/* Boards should provide their own version of this if they use lbc sdram */ +void __sdram_init (void ) +{ +/* Do nothing */ +} +void sdram_init (void ) __attribute__((weak,alias ("__sdram_init" ))); +#endif + +void print_lbc_regs (void ) {int i;
arch/powerpc/include/asm/fsl_ddr_sdram.h +13 -0
@@ -214,6 +214,19 @@ typedef struct memctl_options_s {extern phys_size_t fsl_ddr_sdram (void ); +/* +* The 85xx boards have a common prototype for fixed_sdram so put the +* declaration here. +*/ +#ifdef CONFIG_MPC85xx +extern phys_size_t fixed_sdram (void ); +#endif + +#if defined(CONFIG_DDR_ECC ) +extern void ddr_enable_ecc (unsigned int dram_size); +#endif + + typedef struct fixed_ddr_parm{ int min_freq; int max_freq;
arch/powerpc/include/asm/fsl_lbc.h +4 -0
@@ -16,6 +16,10 @@#include <config.h> #include <common.h> +#ifdef CONFIG_MPC85xx +void sdram_init (void ); +#endif +/* BR - Base Registers */ #define BR0 0x5000/* Register offset to immr */
board/freescale/mpc8536ds/mpc8536ds.c +0 -21
@@ -42,8 +42,6 @@#include "../common/sgmii_riser.h" -phys_size_t fixed_sdram (void ); -int board_early_init_f (void ) {#ifdef CONFIG_MMC
@@ -98,25 +96,6 @@ int checkboard (void)return 0 ; } -phys_size_t -initdram (int board_type) -{ -phys_size_t dram_size =0 ; - -puts ("Initializing...." ); - -#ifdef CONFIG_SPD_EEPROM - dram_size =fsl_ddr_sdram (); -#else - dram_size =fixed_sdram (); -#endif - dram_size =setup_ddr_tlbs (dram_size /0x100000 ); - dram_size *=0x100000 ; - -puts (" DDR: " ); -return dram_size; -} -#if !defined(CONFIG_SPD_EEPROM )/* * Fixed sdram init -- doesn't use serial presence detect.
board/freescale/mpc8540ads/mpc8540ads.c +1 -51
70 lines not on this page · raw message
board/freescale/mpc8540ads/tlb.c +0 -19
@@ -106,25 +106,6 @@ struct fsl_e_tlb_entry tlb_table[] = {SET_TLB_ENTRY (1 ,CONFIG_SYS_BCSR ,CONFIG_SYS_BCSR ,MAS3_SX |MAS3_SW |MAS3_SR ,MAS2_I |MAS2_G , 0, 7, BOOKE_PAGESZ_16K, 1), - -#if !defined(CONFIG_SPD_EEPROM) -/* -* TLB 8, 9: 128M DDR -* 0x00000000 64M DDR System memory -* 0x04000000 64M DDR System memory -* Without SPD EEPROM configured DDR, this must be setup manually. -* Make sure the TLB count@the top of this table is correct. -* Likely it needs to be increased by two for these entries. - */ -#error ("Update the number of table entries in tlb1_entry") -SET_TLB_ENTRY (1 ,CONFIG_SYS_DDR_SDRAM_BASE ,CONFIG_SYS_DDR_SDRAM_BASE , -MAS3_SX |MAS3_SW |MAS3_SR ,0 , -0 ,8 ,BOOKE_PAGESZ_64M ,1 ), - -SET_TLB_ENTRY (1 ,CONFIG_SYS_DDR_SDRAM_BASE +0x4000000 ,CONFIG_SYS_DDR_SDRAM_BASE +0x4000000 , -MAS3_SX |MAS3_SW |MAS3_SR ,0 , - 0, 9, BOOKE_PAGESZ_64M, 1), -#endif };int num_tlb_entries =ARRAY_SIZE (tlb_table);
board/freescale/mpc8541cds/mpc8541cds.c +0 -43
55 lines not on this page · raw message
board/freescale/mpc8544ds/mpc8544ds.c +0 -17
@@ -68,23 +68,6 @@ int checkboard (void)return 0 ; } -phys_size_t -initdram (int board_type) -{ -long dram_size =0 ; - -puts ("Initializing\n" ); - - dram_size =fsl_ddr_sdram (); - - dram_size =setup_ddr_tlbs (dram_size /0x100000 ); - - dram_size *=0x100000 ; - -puts (" DDR: " ); -return dram_size; -} -#ifdef CONFIG_PCI1 static struct pci_controller pci1_hose;#endif
board/freescale/mpc8548cds/mpc8548cds.c +0 -38
@@ -42,7 +42,6 @@DECLARE_GLOBAL_DATA_PTR ;void local_bus_init (void ); -void sdram_init (void );int checkboard (void ) {
@@ -75,43 +74,6 @@ int checkboard (void)return 0 ; } -phys_size_t -initdram (int board_type) -{ -long dram_size =0 ; - -puts ("Initializing\n" ); - -#if defined(CONFIG_DDR_DLL ) - { -/* -* Work around to stabilize DDR DLL MSYNC_IN. -* Errata DDR9 seems to have been fixed. -* This is now the workaround for Errata DDR11: -* Override DLL = 1, Course Adj = 1, Tap Select = 0 -*/ - -volatile ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR); - - gur->ddrdllcr =0x81000000 ; - asm("sync;isync;msync" ); -udelay (200 ); - } -#endif - - dram_size =fsl_ddr_sdram (); - dram_size =setup_ddr_tlbs (dram_size /0x100000 ); - dram_size *=0x100000 ; - -/* -* SDRAM Initialization -*/ -sdram_init (); - -puts (" DDR: " ); -return dram_size; -} -/* * Initialize Local Bus */
board/freescale/mpc8555cds/mpc8555cds.c +0 -45
57 lines not on this page · raw message
board/freescale/mpc8560ads/mpc8560ads.c +1 -51
70 lines not on this page · raw message
board/freescale/mpc8560ads/tlb.c +0 -19
@@ -106,25 +106,6 @@ struct fsl_e_tlb_entry tlb_table[] = {SET_TLB_ENTRY (1 ,CONFIG_SYS_BCSR ,CONFIG_SYS_BCSR ,MAS3_SX |MAS3_SW |MAS3_SR ,MAS2_I |MAS2_G , 0, 7, BOOKE_PAGESZ_16K, 1), - -#if !defined(CONFIG_SPD_EEPROM) -/* -* TLB 8, 9: 128M DDR -* 0x00000000 64M DDR System memory -* 0x04000000 64M DDR System memory -* Without SPD EEPROM configured DDR, this must be setup manually. -* Make sure the TLB count@the top of this table is correct. -* Likely it needs to be increased by two for these entries. - */ -#error ("Update the number of table entries in tlb1_entry") -SET_TLB_ENTRY (1 ,CONFIG_SYS_DDR_SDRAM_BASE ,CONFIG_SYS_DDR_SDRAM_BASE , -MAS3_SX |MAS3_SW |MAS3_SR ,0 , -0 ,8 ,BOOKE_PAGESZ_64M ,1 ), - -SET_TLB_ENTRY (1 ,CONFIG_SYS_DDR_SDRAM_BASE +0x4000000 ,CONFIG_SYS_DDR_SDRAM_BASE +0x4000000 , -MAS3_SX |MAS3_SW |MAS3_SR ,0 , - 0, 9, BOOKE_PAGESZ_64M, 1), -#endif };int num_tlb_entries =ARRAY_SIZE (tlb_table);
board/freescale/mpc8568mds/mpc8568mds.c +0 -38
@@ -101,7 +101,6 @@ const qe_iop_conf_t qe_iop_conf_tab[] = { };void local_bus_init (void ); -void sdram_init (void );int board_early_init_f (void ) {
@@ -138,43 +137,6 @@ int checkboard (void)return 0 ; } -phys_size_t -initdram (int board_type) -{ -long dram_size =0 ; - -puts ("Initializing\n" ); - -#if defined(CONFIG_DDR_DLL ) - { -/* -* Work around to stabilize DDR DLL MSYNC_IN. -* Errata DDR9 seems to have been fixed. -* This is now the workaround for Errata DDR11: -* Override DLL = 1, Course Adj = 1, Tap Select = 0 -*/ - -volatile ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR); - - gur->ddrdllcr =0x81000000 ; - asm("sync;isync;msync" ); -udelay (200 ); - } -#endif - - dram_size =fsl_ddr_sdram (); - dram_size =setup_ddr_tlbs (dram_size /0x100000 ); - dram_size *=0x100000 ; - -/* -* SDRAM Initialization -*/ -sdram_init (); - -puts (" DDR: " ); -return dram_size; -} -/* * Initialize Local Bus */
board/freescale/mpc8569mds/mpc8569mds.c +0 -36
@@ -45,8 +45,6 @@#include "../common/pq-mds-pib.h" #endif -phys_size_t fixed_sdram (void ); -const qe_iop_conf_t qe_iop_conf_tab[] = {/* QE_MUX_MDC */ {2 ,31 ,1 ,0 ,1 },/* QE_MUX_MDC */
@@ -245,40 +243,6 @@ int checkboard (void)return 0 ; } -phys_size_t -initdram (int board_type) -{ -long dram_size =0 ; - -puts ("Initializing\n" ); - -#if defined(CONFIG_DDR_DLL ) -/* -* Work around to stabilize DDR DLL MSYNC_IN. -* Errata DDR9 seems to have been fixed. -* This is now the workaround for Errata DDR11: -* Override DLL = 1, Course Adj = 1, Tap Select = 0 -*/ -volatile ccsr_gur_t *gur = - (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR); - -out_be32 (&gur->ddrdllcr,0x81000000 ); -udelay (200 ); -#endif - -#ifdef CONFIG_SPD_EEPROM - dram_size =fsl_ddr_sdram (); -#else - dram_size =fixed_sdram (); -#endif - - dram_size =setup_ddr_tlbs (dram_size /0x100000 ); - dram_size *=0x100000 ; - -puts (" DDR: " ); -return dram_size; -} -#if !defined(CONFIG_SPD_EEPROM )phys_size_t fixed_sdram (void ) {
board/freescale/mpc8572ds/mpc8572ds.c +0 -19
@@ -39,8 +39,6 @@#include "../common/sgmii_riser.h" -long int fixed_sdram (void ); -int checkboard (void ) {u8 vboot;
@@ -74,23 +72,6 @@ int checkboard (void)return 0 ; } -phys_size_t initdram (int board_type) -{ -phys_size_t dram_size =0 ; - -puts ("Initializing...." ); - -#ifdef CONFIG_SPD_EEPROM - dram_size =fsl_ddr_sdram (); -#else - dram_size =fixed_sdram (); -#endif - dram_size =setup_ddr_tlbs (dram_size /0x100000 ); - dram_size *=0x100000 ; - -puts (" DDR: " ); -return dram_size; -}#if !defined(CONFIG_SPD_EEPROM )/*
board/freescale/p1022ds/p1022ds.c +0 -13
@@ -76,19 +76,6 @@ int checkboard(void)return 0 ; } -phys_size_t initdram (int board_type) -{ -phys_size_t dram_size =0 ; - -puts ("Initializing....\n" ); - - dram_size =fsl_ddr_sdram (); - dram_size =setup_ddr_tlbs (dram_size /0x100000 ) *0x100000 ; - -puts (" DDR: " ); -return dram_size; -} -#define CONFIG_TFP410_I2C_ADDR 0x38/* Masks for the SSI_TDM and AUDCLK bits of the ngPIXIS BRDCFG1 register. */
board/freescale/p1_p2_rdb/ddr.c +1 -14
@@ -239,19 +239,6 @@ phys_size_t fixed_sdram (void)fsl_ddr_set_memctl_regs (&ddr_cfg_regs,0 ); +set_ddr_laws (0 , ddr_size,LAW_TRGT_IF_DDR_1 );return ddr_size; } - -phys_size_t initdram (int board_type) -{ -phys_size_t dram_size =0 ; - - dram_size =fixed_sdram (); -set_ddr_laws (0 , dram_size,LAW_TRGT_IF_DDR_1 ); - - dram_size =setup_ddr_tlbs (dram_size /0x100000 ); - dram_size *=0x100000 ; - -puts ("DDR: " ); -return dram_size; -}
board/freescale/p2020ds/p2020ds.c +7 -27
@@ -44,8 +44,6 @@DECLARE_GLOBAL_DATA_PTR ; -phys_size_t fixed_sdram (void ); -int checkboard (void ) {u8 sw;
@@ -70,31 +68,6 @@ int checkboard(void)return 0 ; } -phys_size_t initdram (int board_type) -{ -phys_size_t dram_size =0 ; - -puts ("Initializing...." ); - -#ifdef CONFIG_DDR_SPD - dram_size =fsl_ddr_sdram (); -#else - dram_size =fixed_sdram (); - -if (set_ddr_laws (CONFIG_SYS_DDR_SDRAM_BASE , - dram_size, -LAW_TRGT_IF_DDR ) <0 ) { -printf ("ERROR setting Local Access Windows for DDR\n" ); -return 0 ; - }; -#endif - dram_size =setup_ddr_tlbs (dram_size /0x100000 ); - dram_size *=0x100000 ; - -puts (" DDR: " ); -return dram_size; -} -#if !defined(CONFIG_DDR_SPD )/* * Fixed sdram init -- doesn't use serial presence detect.
@@ -170,6 +143,13 @@ phys_size_t fixed_sdram(void)udelay (500 );#endif +if (set_ddr_laws (CONFIG_SYS_DDR_SDRAM_BASE , +CONFIG_SYS_SDRAM_SIZE *1024 *1024 , +LAW_TRGT_IF_DDR ) <0 ) { +printf ("ERROR setting Local Access Windows for DDR\n" ); +return 0 ; + }; +return CONFIG_SYS_SDRAM_SIZE *1024 *1024 ; }
board/sbc8548/sbc8548.c +1 -44
63 lines not on this page · raw message
board/sbc8548/tlb.c +12 -22
@@ -65,44 +65,34 @@ struct fsl_e_tlb_entry tlb_table[] = { 0, 1, BOOKE_PAGESZ_1G, 1),/* -* TLB 2: 256M Cacheable, non-guarded -* 0x0 256M DDR SDRAM -*/ -#if !defined(CONFIG_SPD_EEPROM ) -SET_TLB_ENTRY (1 ,CONFIG_SYS_DDR_SDRAM_BASE ,CONFIG_SYS_DDR_SDRAM_BASE , -MAS3_SX |MAS3_SW |MAS3_SR ,0 , -0 ,2 ,BOOKE_PAGESZ_256M ,1 ), -#endif - -/* -* TLB 3: 64M Non-cacheable, guarded +* TLB 2: 64M Non-cacheable, guarded * 0xe0000000 1M CCSRBAR * 0xe2000000 8M PCI1 IO * 0xe2800000 8M PCIe IO */ SET_TLB_ENTRY (1 ,CONFIG_SYS_CCSRBAR ,CONFIG_SYS_CCSRBAR_PHYS ,MAS3_SX |MAS3_SW |MAS3_SR ,MAS2_I |MAS2_G , -0 ,3 ,BOOKE_PAGESZ_64M ,1 ), +0 ,2 ,BOOKE_PAGESZ_64M ,1 ),/* -* TLB 4: 64M Cacheable, non-guarded +* TLB 3: 64M Cacheable, non-guarded * 0xf0000000 64M LBC SDRAM First half */ SET_TLB_ENTRY (1 ,CONFIG_SYS_LBC_SDRAM_BASE ,CONFIG_SYS_LBC_SDRAM_BASE ,MAS3_SX |MAS3_SW |MAS3_SR ,0 , -0 ,4 ,BOOKE_PAGESZ_64M ,1 ), +0 ,3 ,BOOKE_PAGESZ_64M ,1 ),/* -* TLB 5: 64M Cacheable, non-guarded +* TLB 4: 64M Cacheable, non-guarded * 0xf4000000 64M LBC SDRAM Second half */ SET_TLB_ENTRY (1 ,CONFIG_SYS_LBC_SDRAM_BASE +0x4000000 ,CONFIG_SYS_LBC_SDRAM_BASE +0x4000000 ,MAS3_SX |MAS3_SW |MAS3_SR ,0 , -0 ,5 ,BOOKE_PAGESZ_64M ,1 ), +0 ,4 ,BOOKE_PAGESZ_64M ,1 ),/* -* TLB 6: 16M Cacheable, non-guarded +* TLB 5: 16M Cacheable, non-guarded * 0xf8000000 1M 7-segment LED display * 0xf8100000 1M User switches * 0xf8300000 1M Board revision
@@ -110,24 +100,24 @@ struct fsl_e_tlb_entry tlb_table[] = {*/ SET_TLB_ENTRY (1 ,CONFIG_SYS_EPLD_BASE ,CONFIG_SYS_EPLD_BASE ,MAS3_SX |MAS3_SW |MAS3_SR ,MAS2_I |MAS2_G , -0 ,6 ,BOOKE_PAGESZ_16M ,1 ), +0 ,5 ,BOOKE_PAGESZ_16M ,1 ),/* -* TLB 7: 4M Non-cacheable, guarded +* TLB 6: 4M Non-cacheable, guarded * 0xfb800000 4M 1st 4MB block of 64MB user FLASH */ SET_TLB_ENTRY (1 ,CONFIG_SYS_ALT_FLASH ,CONFIG_SYS_ALT_FLASH ,MAS3_SX |MAS3_SW |MAS3_SR ,MAS2_I |MAS2_G , -0 ,7 ,BOOKE_PAGESZ_4M ,1 ), +0 ,6 ,BOOKE_PAGESZ_4M ,1 ),/* -* TLB 8: 4M Non-cacheable, guarded +* TLB 7: 4M Non-cacheable, guarded * 0xfbc00000 4M 2nd 4MB block of 64MB user FLASH */ SET_TLB_ENTRY (1 ,CONFIG_SYS_ALT_FLASH +0x400000 ,CONFIG_SYS_ALT_FLASH +0x400000 ,MAS3_SX |MAS3_SW |MAS3_SR ,MAS2_I |MAS2_G , - 0, 8, BOOKE_PAGESZ_4M, 1), + 0, 7, BOOKE_PAGESZ_4M, 1), };
board/sbc8560/sbc8560.c +1 -92
111 lines not on this page · raw message
board/socrates/sdram.c +1 -14
@@ -39,7 +39,7 @@* so this should be extended for other future boards * using this routine! */ -long int fixed_sdram (void ) +phys_size_t fixed_sdram (void ) {volatile ccsr_ddr_t *ddr = (void *)(CONFIG_SYS_MPC85xx_DDR_ADDR);
@@ -77,19 +77,6 @@ long int fixed_sdram(void) }#endif -phys_size_t initdram (int board_type) -{ -long dram_size =0 ; -#if defined(CONFIG_SPD_EEPROM ) - dram_size =fsl_ddr_sdram (); - dram_size =setup_ddr_tlbs (dram_size /0x100000 ); - dram_size *=0x100000 ; -#else - dram_size =fixed_sdram (); -#endif -return dram_size; -} -#if defined(CONFIG_SYS_DRAM_TEST )int testdram (void ) {
board/stx/stxgp3/stxgp3.c +0 -32
@@ -40,8 +40,6 @@#include <spd_sdram.h> #include <miiphy.h> -long int fixed_sdram (void ); -/* * I/O Port configuration table *
@@ -277,36 +275,6 @@ show_activity(int flag) next_led_update += (get_tbclk () /4 ); } -phys_size_t -initdram (int board_type) -{ -long dram_size =0 ; - -#if defined(CONFIG_DDR_DLL ) - { -volatile ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR); -uint temp_ddrdll =0 ; - -/* Work around to stabilize DDR DLL */ - temp_ddrdll = gur->ddrdllcr; - gur->ddrdllcr = ((temp_ddrdll &0xff ) <<16 ) |0x80000000 ; - asm("sync;isync;msync" ); - } -#endif - - dram_size =fsl_ddr_sdram (); - dram_size =setup_ddr_tlbs (dram_size /0x100000 ); - dram_size *=0x100000 ; - -#if defined(CONFIG_DDR_ECC ) -/* Initialize and enable DDR ECC. -*/ -ddr_enable_ecc (dram_size); -#endif - -return dram_size; -} -#if defined(CONFIG_SYS_DRAM_TEST )int testdram (void )
board/stx/stxssa/stxssa.c +0 -33
@@ -41,8 +41,6 @@#include <miiphy.h> #include <netdev.h> -long int fixed_sdram (void ); -/* * I/O Port configuration table *
@@ -294,37 +292,6 @@ show_activity(int flag) next_led_update += (get_tbclk () /4 ); } -phys_size_t -initdram (int board_type) -{ -long dram_size =0 ; - -#if defined(CONFIG_DDR_DLL ) - { -volatile ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR); -uint temp_ddrdll =0 ; - -/* Work around to stabilize DDR DLL */ - temp_ddrdll = gur->ddrdllcr; - gur->ddrdllcr = ((temp_ddrdll &0xff ) <<16 ) |0x80000000 ; - asm("sync;isync;msync" ); - } -#endif - - dram_size =fsl_ddr_sdram (); - dram_size =setup_ddr_tlbs (dram_size /0x100000 ); - dram_size *=0x100000 ; - -#if defined(CONFIG_DDR_ECC ) -/* Initialize and enable DDR ECC. -*/ -ddr_enable_ecc (dram_size); -#endif - -return dram_size; -} - -#if defined(CONFIG_SYS_DRAM_TEST )int testdram (void ) {
board/tqc/tqm85xx/sdram.c +0 -37
@@ -394,43 +394,6 @@ static phys_size_t sdram_setup(int casl)return (i <N_DDR_CS_CONF ) ? ddr_cs_conf[i].size :0 ; } -phys_size_t initdram (int board_type) -{ -phys_size_t dram_size =0 ; - -#if defined(CONFIG_DDR_DLL ) -/* -* This DLL-Override only used on TQM8540 and TQM8560 -*/ - { -volatile ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR); -int i, x; - - x =10 ; - -/* -* Work around to stabilize DDR DLL -*/ - gur->ddrdllcr =0x81000000 ; - asm ("sync; isync; msync" ); -udelay (200 ); -while (gur->ddrdllcr !=0x81000100 ) { - gur->devdisr = gur->devdisr |0x00010000 ; - asm ("sync; isync; msync" ); -for (i =0 ; i < x; i++) - ; - gur->devdisr = gur->devdisr &0xfff7ffff ; - asm ("sync; isync; msync" ); - x++; - } - } -#endif - - dram_size =fixed_sdram (); - -return dram_size; -} -#if defined(CONFIG_SYS_DRAM_TEST )int testdram (void ) {
board/tqc/tqm85xx/tlb.c +0 -47
59 lines not on this page · raw message
board/xes/common/Makefile +0 -2
@@ -33,8 +33,6 @@ COBJS-$(CONFIG_FSL_PCI_INIT) += fsl_8xxx_pci.o COBJS-$(CONFIG_MPC8572) += fsl_8xxx_clk.o COBJS-$(CONFIG_MPC86xx) += fsl_8xxx_clk.o COBJS-$(CONFIG_P2020) += fsl_8xxx_clk.o -COBJS-$(CONFIG_FSL_DDR2) += fsl_8xxx_ddr.o -COBJS-$(CONFIG_FSL_DDR3) += fsl_8xxx_ddr.o COBJS-$(CONFIG_MPC85xx) += fsl_8xxx_misc.o board.o COBJS-$(CONFIG_MPC86xx) += fsl_8xxx_misc.o board.o COBJS-$(CONFIG_NAND_ACTL) += actl_nand.o
board/xes/common/fsl_8xxx_ddr.c deleted +0 -46
46 lines not on this page · raw message
board/xes/xpedite517x/xpedite517x.c +13 -0
@@ -22,6 +22,7 @@#include <common.h> #include <asm/processor.h> +#include <asm/fsl_ddr_sdram.h> #include <asm/mmu.h> #include <asm/io.h> #include <fdt_support.h>
@@ -71,6 +72,18 @@ int board_early_init_r(void)return 0 ; } +phys_size_t initdram (int board_type) +{ +phys_size_t dram_size =fsl_ddr_sdram (); + +#if defined(CONFIG_DDR_ECC ) && !defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER ) +/* Initialize and enable DDR ECC */ +ddr_enable_ecc (dram_size); +#endif + +return dram_size; +} +#if defined(CONFIG_OF_BOARD_SETUP )void ft_board_setup (void *blob,bd_t *bd) {
include/configs/TQM85xx.h +4 -0
@@ -147,6 +147,10 @@* DDR Setup */ #define CONFIG_SYS_DDR_SDRAM_BASE 0x00000000/* DDR is system memory */ +#if defined(CONFIG_TQM_BIGFLASH ) || \ + (!defined(CONFIG_TQM8548_AG ) && !defined(CONFIG_TQM8548_BE )) +#define CONFIG_SYS_PPC_DDR_WIMGE (MAS2_I | MAS2_G) +#endif #define CONFIG_SYS_SDRAM_BASE CONFIG_SYS_DDR_SDRAM_BASE#ifdef CONFIG_TQM8548_AG #define CONFIG_VERY_BIG_RAM
Signature · 1 line
1.5.6.5
PATCH v3 4/6 mpc85xx: rename sdram_init() lbc_sdram_init()
sdram_init() is used to initialize sdram on the lbc. Rename it accordingly.
--- arch/powerpc/cpu/mpc85xx/cpu.c | 2 +- arch/powerpc/cpu/mpc8xxx/fsl_lbc.c | 4 ++-- arch/powerpc/include/asm/fsl_lbc.h | 2 +- board/freescale/mpc8540ads/mpc8540ads.c | 4 +--- board/freescale/mpc8541cds/mpc8541cds.c | 3 +-- board/freescale/mpc8548cds/mpc8548cds.c | 3 +-- board/freescale/mpc8555cds/mpc8555cds.c | 3 +-- board/freescale/mpc8560ads/mpc8560ads.c | 4 +--- board/freescale/mpc8568mds/mpc8568mds.c | 3 +-- board/sbc8548/sbc8548.c | 3 +-- 10 files changed, 11 insertions(+), 20 deletions(-)
arch/powerpc/cpu/mpc85xx/cpu.c +1 -1
@@ -331,7 +331,7 @@ phys_size_t initdram(int board_type)#endif /* Some boards also have sdram on the lbc */ -sdram_init (); +lbc_sdram_init ();puts ("DDR: " );return dram_size;
arch/powerpc/cpu/mpc8xxx/fsl_lbc.c +2 -2
@@ -11,11 +11,11 @@#ifdef CONFIG_MPC85xx/* Boards should provide their own version of this if they use lbc sdram */ -void __sdram_init (void ) +void __lbc_sdram_init (void ) {/* Do nothing */ } -void sdram_init (void ) __attribute__((weak,alias ("__sdram_init" ))); +void lbc_sdram_init (void ) __attribute__((weak,alias ("__lbc_sdram_init" )));#endif
arch/powerpc/include/asm/fsl_lbc.h +1 -1
@@ -17,7 +17,7 @@#include <common.h> #ifdef CONFIG_MPC85xx -void sdram_init (void ); +void lbc_sdram_init (void );#endif /* BR - Base Registers
board/freescale/mpc8540ads/mpc8540ads.c +1 -3
@@ -122,9 +122,7 @@ local_bus_init(void)/* * Initialize SDRAM memory on the Local Bus. */ - -void -sdram_init (void ) +void lbc_sdram_init (void ) {volatile fsl_lbc_t *lbc =LBC_BASE_ADDR ;uint *sdram_addr = (uint *)CONFIG_SYS_LBC_SDRAM_BASE ;
board/freescale/mpc8541cds/mpc8541cds.c +1 -2
@@ -291,8 +291,7 @@ local_bus_init(void)/* * Initialize SDRAM memory on the Local Bus. */ -void -sdram_init (void ) +void lbc_sdram_init (void ) {#if defined(CONFIG_SYS_OR2_PRELIM ) && defined(CONFIG_SYS_BR2_PRELIM )
board/freescale/mpc8548cds/mpc8548cds.c +1 -2
@@ -111,8 +111,7 @@ local_bus_init(void)/* * Initialize SDRAM memory on the Local Bus. */ -void -sdram_init (void ) +void lbc_sdram_init (void ) {#if defined(CONFIG_SYS_OR2_PRELIM ) && defined(CONFIG_SYS_BR2_PRELIM )
board/freescale/mpc8555cds/mpc8555cds.c +1 -2
@@ -289,8 +289,7 @@ local_bus_init(void)/* * Initialize SDRAM memory on the Local Bus. */ -void -sdram_init (void ) +void lbc_sdram_init (void ) {#if defined(CONFIG_SYS_OR2_PRELIM ) && defined(CONFIG_SYS_BR2_PRELIM )
board/freescale/mpc8560ads/mpc8560ads.c +1 -3
@@ -327,9 +327,7 @@ local_bus_init(void)/* * Initialize SDRAM memory on the Local Bus. */ - -void -sdram_init (void ) +void lbc_sdram_init (void ) {volatile fsl_lbc_t *lbc =LBC_BASE_ADDR ;uint *sdram_addr = (uint *)CONFIG_SYS_LBC_SDRAM_BASE ;
board/freescale/mpc8568mds/mpc8568mds.c +1 -2
@@ -171,8 +171,7 @@ local_bus_init(void)/* * Initialize SDRAM memory on the Local Bus. */ -void -sdram_init (void ) +void lbc_sdram_init (void ) {#if defined(CONFIG_SYS_OR2_PRELIM ) && defined(CONFIG_SYS_BR2_PRELIM )
board/sbc8548/sbc8548.c +1 -2
@@ -104,8 +104,7 @@ local_bus_init(void)/* * Initialize SDRAM memory on the Local Bus. */ -void -sdram_init (void ) +void lbc_sdram_init (void ) {#if defined(CONFIG_SYS_LBC_SDRAM_SIZE )
Signature · 1 line
1.5.6.5
PATCH v3 5/6 85xx boards: Rename CONFIG_DDR_DLL to CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN
This config option is for an erratum workaround; rename it to be more clear. Also, drop it from config files don't need it and were undefining it.
--- arch/powerpc/cpu/mpc85xx/cmd_errata.c | 3 +++ arch/powerpc/cpu/mpc85xx/cpu.c | 2 +- doc/README.mpc85xxads | 4 ++-- include/configs/MPC8536DS.h | 1 - include/configs/MPC8548CDS.h | 2 +- include/configs/MPC8572DS.h | 1 - include/configs/P1_P2_RDB.h | 1 - include/configs/SBC8540.h | 2 +- include/configs/TQM85xx.h | 2 +- include/configs/sbc8560.h | 2 +- include/configs/stxgp3.h | 2 +- include/configs/stxssa.h | 1 - 12 files changed, 11 insertions(+), 12 deletions(-)
arch/powerpc/cpu/mpc85xx/cmd_errata.c +3 -0
@@ -47,6 +47,9 @@ static int do_errata(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])#if defined(CONFIG_SYS_P4080_ERRATUM_CPU22 )puts ("Work-around for Erratum CPU22 enabled\n" );#endif +#if defined(CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN ) +puts ("Work-around for DDR MSYNC_IN Erratum enabled\n" ); +#endif return 0 ; }
arch/powerpc/cpu/mpc85xx/cpu.c +1 -1
@@ -293,7 +293,7 @@ phys_size_t initdram(int board_type) {phys_size_t dram_size =0 ; -#if defined(CONFIG_DDR_DLL ) +#if defined(CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN ) {ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);unsigned int x =10 ;
doc/README.mpc85xxads +2 -2
@@ -144,8 +144,8 @@ Updated 13-July-2004 Jon Loeliger also manual config the DDR after undef this definition. CONFIG_DDR_ECC only for ECC DDR module - CONFIG_DDR_DLL DLL fix on some ADS boards needed for more - stability. + CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN DLL fix on some ADS boards needed + for more stability. CONFIG_HAS_FEC If an FEC is on chip, set to 1, else 0. Other than the above definitions, the rest in the config files are
include/configs/MPC8536DS.h +0 -1
@@ -144,7 +144,6 @@#undef CONFIG_FSL_DDR_INTERACTIVE#define CONFIG_SPD_EEPROM /* Use SPD EEPROM for DDR setup */ #define CONFIG_DDR_SPD -#undef CONFIG_DDR_DLL#define CONFIG_ECC_INIT_VIA_DDRCONTROLLER /* DDR controller or DMA? */ #define CONFIG_MEM_INIT_VALUE 0xDeadBeef
include/configs/MPC8548CDS.h +1 -1
@@ -89,7 +89,7 @@ extern unsigned long get_clock_freq(void);#undef CONFIG_FSL_DDR_INTERACTIVE#define CONFIG_SPD_EEPROM /* Use SPD EEPROM for DDR setup*/ #define CONFIG_DDR_SPD -#define CONFIG_DDR_DLL /* possible DLL fix needed */ +#define CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN /* possible DLL fix needed */ #define CONFIG_ECC_INIT_VIA_DDRCONTROLLER /* DDR controller or DMA? */ #define CONFIG_MEM_INIT_VALUE 0xDeadBeef
include/configs/MPC8572DS.h +0 -1
@@ -131,7 +131,6 @@#undef CONFIG_FSL_DDR_INTERACTIVE#define CONFIG_SPD_EEPROM /* Use SPD EEPROM for DDR setup */ #define CONFIG_DDR_SPD -#undef CONFIG_DDR_DLL#define CONFIG_ECC_INIT_VIA_DDRCONTROLLER #define CONFIG_MEM_INIT_VALUE 0xDeadBeef
include/configs/P1_P2_RDB.h +0 -1
@@ -146,7 +146,6 @@ extern unsigned long get_board_sys_clk(unsigned long dummy);#define CONFIG_FSL_DDR2 #undef CONFIG_FSL_DDR_INTERACTIVE#undef CONFIG_SPD_EEPROM/* Use SPD EEPROM for DDR setup */ -#undef CONFIG_DDR_DLL#define CONFIG_MEM_INIT_VALUE 0xDeadBeef
include/configs/SBC8540.h +1 -1
@@ -118,7 +118,7 @@#undef CONFIG_DDR_SPD#if defined(CONFIG_MPC85xx_REV1) -#define CONFIG_DDR_DLL /* possible DLL fix needed */ +#define CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN /* possible DLL fix needed */ #endif #undef CONFIG_DDR_ECC/* only for ECC DDR module */
include/configs/TQM85xx.h +1 -1
@@ -162,7 +162,7 @@#if defined(CONFIG_TQM8540 ) || defined(CONFIG_TQM8560 )/* TQM8540 & 8560 need DLL-override */ -#define CONFIG_DDR_DLL /* DLL fix needed */ +#define CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN /* possible DLL fix needed */ #define CONFIG_DDR_DEFAULT_CL 25/* CAS latency 2,5 */ #endif /* CONFIG_TQM8540 || CONFIG_TQM8560 */
include/configs/sbc8560.h +1 -1
@@ -116,7 +116,7 @@#undef CONFIG_DDR_SPD#if defined(CONFIG_MPC85xx_REV1) -#define CONFIG_DDR_DLL /* possible DLL fix needed */ +#define CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN /* possible DLL fix needed */ #endif #undef CONFIG_DDR_ECC/* only for ECC DDR module */
include/configs/stxgp3.h +1 -1
@@ -123,7 +123,7 @@#undef CONFIG_FSL_DDR_INTERACTIVE#undef CONFIG_DDR_ECC/* only for ECC DDR module */ -#define CONFIG_DDR_DLL /* possible DLL fix needed */ +#define CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN /* possible DLL fix needed */ #define CONFIG_DDR_2T_TIMING /* Sets the 2T timing bit */ #define CONFIG_MEM_INIT_VALUE 0xDeadBeef
include/configs/stxssa.h +0 -1
@@ -135,7 +135,6 @@#undef CONFIG_FSL_DDR_INTERACTIVE#undef CONFIG_DDR_ECC/* only for ECC DDR module */ -#undef CONFIG_DDR_DLL/* possible DLL fix needed */ #define CONFIG_DDR_2T_TIMING /* Sets the 2T timing bit */ #define CONFIG_MEM_INIT_VALUE 0xDeadBeef
Signature · 1 line
1.5.6.5
PATCH v3 6/6 MPC8xxx DDR: align informational prints
Add spaces to cause the informational prints to line up with the ones from init_func_ram() in board.c. Output now looks like this:
....
DRAM: Detected 4096 MB of memory
This U-Boot only supports < 4G of DDR You could rebuild it with CONFIG_PHYS_64BIT
DDR: 2 GiB (DDR2, 64-bit, CL=5, ECC off)
....
The prints from lbc_sdram_init() have also been modified to line line up and changed to start with "LBC SDRAM" instead of the confusing "SDRAM".
--- arch/powerpc/cpu/mpc8xxx/ddr/main.c | 5 +++-- board/freescale/mpc8540ads/mpc8540ads.c | 5 +++-- board/freescale/mpc8541cds/mpc8541cds.c | 6 +++--- board/freescale/mpc8548cds/mpc8548cds.c | 6 +++--- board/freescale/mpc8555cds/mpc8555cds.c | 6 +++--- board/freescale/mpc8560ads/mpc8560ads.c | 5 +++-- board/freescale/mpc8568mds/mpc8568mds.c | 6 +++--- 7 files changed, 21 insertions(+), 18 deletions(-)
arch/powerpc/cpu/mpc8xxx/ddr/main.c +3 -2
@@ -469,8 +469,9 @@ phys_size_t fsl_ddr_sdram(void)/* Check for 4G or more. Bad. */ if (total_memory >= (1ull <<32 )) {printf ("Detected %lld MB of memory\n" , total_memory >>20 ); -printf ("This U-Boot only supports < 4G of DDR\n" ); -printf ("You could rebuild it with CONFIG_PHYS_64BIT\n" ); +printf (" This U-Boot only supports < 4G of DDR\n" ); +printf (" You could rebuild it with CONFIG_PHYS_64BIT\n" ); +printf (" " );/* re-align to match init_func_ram print */ total_memory =CONFIG_MAX_MEM_MAPPED ; }#endif
board/freescale/mpc8540ads/mpc8540ads.c +3 -2
@@ -127,8 +127,9 @@ void lbc_sdram_init(void)volatile fsl_lbc_t *lbc =LBC_BASE_ADDR ;uint *sdram_addr = (uint *)CONFIG_SYS_LBC_SDRAM_BASE ; -puts (" SDRAM: " ); -print_size (CONFIG_SYS_LBC_SDRAM_SIZE *1024 *1024 ,"\n" ); +puts ("LBC SDRAM: " ); +print_size (CONFIG_SYS_LBC_SDRAM_SIZE *1024 *1024 , +"\n " );/* * Setup SDRAM Base and Option Registers
board/freescale/mpc8541cds/mpc8541cds.c +3 -3
@@ -301,9 +301,9 @@ void lbc_sdram_init(void)uint cpu_board_rev;uint lsdmr_common; -puts (" SDRAM: " ); - -print_size (CONFIG_SYS_LBC_SDRAM_SIZE *1024 *1024 ,"\n" ); +puts ("LBC SDRAM: " ); +print_size (CONFIG_SYS_LBC_SDRAM_SIZE *1024 *1024 , +"\n " );/* * Setup SDRAM Base and Option Registers
board/freescale/mpc8548cds/mpc8548cds.c +3 -3
@@ -121,9 +121,9 @@ void lbc_sdram_init(void)uint cpu_board_rev;uint lsdmr_common; -puts (" SDRAM: " ); - -print_size (CONFIG_SYS_LBC_SDRAM_SIZE *1024 *1024 ,"\n" ); +puts ("LBC SDRAM: " ); +print_size (CONFIG_SYS_LBC_SDRAM_SIZE *1024 *1024 , +"\n " );/* * Setup SDRAM Base and Option Registers
board/freescale/mpc8555cds/mpc8555cds.c +3 -3
@@ -299,9 +299,9 @@ void lbc_sdram_init(void)uint cpu_board_rev;uint lsdmr_common; -puts (" SDRAM: " ); - -print_size (CONFIG_SYS_LBC_SDRAM_SIZE *1024 *1024 ,"\n" ); +puts ("LBC SDRAM: " ); +print_size (CONFIG_SYS_LBC_SDRAM_SIZE *1024 *1024 , +"\n " );/* * Setup SDRAM Base and Option Registers
board/freescale/mpc8560ads/mpc8560ads.c +3 -2
@@ -332,8 +332,9 @@ void lbc_sdram_init(void)volatile fsl_lbc_t *lbc =LBC_BASE_ADDR ;uint *sdram_addr = (uint *)CONFIG_SYS_LBC_SDRAM_BASE ; -puts (" SDRAM: " ); -print_size (CONFIG_SYS_LBC_SDRAM_SIZE *1024 *1024 ,"\n" ); +puts ("LBC SDRAM: " ); +print_size (CONFIG_SYS_LBC_SDRAM_SIZE *1024 *1024 , +"\n " );/* * Setup SDRAM Base and Option Registers
board/freescale/mpc8568mds/mpc8568mds.c +3 -3
@@ -180,9 +180,9 @@ void lbc_sdram_init(void)uint *sdram_addr = (uint *)CONFIG_SYS_LBC_SDRAM_BASE ;uint lsdmr_common; -puts (" SDRAM: " ); - -print_size (CONFIG_SYS_LBC_SDRAM_SIZE *1024 *1024 ,"\n" ); +puts ("LBC SDRAM: " ); +print_size (CONFIG_SYS_LBC_SDRAM_SIZE *1024 *1024 , +"\n " );/* * Setup SDRAM Base and Option Registers
Signature · 1 line
1.5.6.5
Kumar Gala
AppliedPATCH v3 6/6 MPC8xxx DDR: align informational prints
Quoted 17 lines · Becky Bruce
Add spaces to cause the informational prints to line up with the ones from
init_func_ram()inboard.c. Output now looks like this:....
DRAM: Detected 4096 MB of memory
This U-Boot only supports < 4G of DDR
You could rebuild it withCONFIG_PHYS_64BIT
DDR: 2 GiB (DDR2, 64-bit, CL=5, ECC off)
....The prints from
lbc_sdram_init()have also been modified to line line up and changed to start with "LBC SDRAM" instead of the confusing "SDRAM".Signed-off-by Becky Bruce <[email protected]>---
Quoted 8 lines
arch/powerpc/cpu/mpc8xxx/ddr/main.c | 5 +++-- board/freescale/mpc8540ads/mpc8540ads.c | 5 +++-- board/freescale/mpc8541cds/mpc8541cds.c | 6 +++--- board/freescale/mpc8548cds/mpc8548cds.c | 6 +++--- board/freescale/mpc8555cds/mpc8555cds.c | 6 +++--- board/freescale/mpc8560ads/mpc8560ads.c | 5 +++-- board/freescale/mpc8568mds/mpc8568mds.c | 6 +++--- 7 files changed, 21 insertions(+), 18 deletions(-)
applied to 85xx
- k
Kumar Gala
AppliedPATCH v3 5/6 85xx boards: Rename CONFIG_DDR_DLL to CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN
In reply to Becky BruceQuoted 6 lines · Becky Bruce
This config option is for an erratum workaround; rename it to be more clear. Also, drop it from config files don't need it and were undefining it.
Signed-off-by Becky Bruce <[email protected]>---
Quoted 13 lines
arch/powerpc/cpu/mpc85xx/cmd_errata.c | 3 +++ arch/powerpc/cpu/mpc85xx/cpu.c | 2 +- doc/README.mpc85xxads | 4 ++-- include/configs/MPC8536DS.h | 1 - include/configs/MPC8548CDS.h | 2 +- include/configs/MPC8572DS.h | 1 - include/configs/P1_P2_RDB.h | 1 - include/configs/SBC8540.h | 2 +- include/configs/TQM85xx.h | 2 +- include/configs/sbc8560.h | 2 +- include/configs/stxgp3.h | 2 +- include/configs/stxssa.h | 1 - 12 files changed, 11 insertions(+), 12 deletions(-)
applied to 85xx
- k
Kumar Gala
AppliedPATCH v3 4/6 mpc85xx: rename sdram_init() lbc_sdram_init()
In reply to Becky BruceQuoted 5 lines · Becky Bruce
sdram_init()is used to initialize sdram on the lbc. Rename it accordingly.Signed-off-by Becky Bruce <[email protected]>---
Quoted 11 lines
arch/powerpc/cpu/mpc85xx/cpu.c | 2 +- arch/powerpc/cpu/mpc8xxx/fsl_lbc.c | 4 ++-- arch/powerpc/include/asm/fsl_lbc.h | 2 +- board/freescale/mpc8540ads/mpc8540ads.c | 4 +--- board/freescale/mpc8541cds/mpc8541cds.c | 3 +-- board/freescale/mpc8548cds/mpc8548cds.c | 3 +-- board/freescale/mpc8555cds/mpc8555cds.c | 3 +-- board/freescale/mpc8560ads/mpc8560ads.c | 4 +--- board/freescale/mpc8568mds/mpc8568mds.c | 3 +-- board/sbc8548/sbc8548.c | 3 +-- 10 files changed, 11 insertions(+), 20 deletions(-)
applied to 85xx
- k
Kumar Gala
AppliedPATCH v3 3/6 mpc85xx boards: initdram() cleanup/bugfix
In reply to Becky BruceQuoted 60 lines · Becky Bruce
Correct initdram to use
phys_size_tto represent the size of dram; instead of changing this all over the place, and correcting all the other random errors I've noticed, create a
common initdram that is used by all non-corenet 85xx parts. Most of theinitdram()functions were identical, with 2 common differences:1) DDR tlbs for the
fixed_sdramcase were set up ininitdram()on some boards, and were part of thetlb_tableon others. I have changed them all over to theinitdram()method - we shouldn't be accessing dram before this point so they don't need to be done sooner, and this seems cleaner.2) Parts that require the DDR11 erratum workaround had different implementations - I have adopted the version from the Freescale errata document. It also looks like some of the versions were buggy, and, depending on timing, could have resulted in the DDR controller being disabled. This seems bad.
The xpedite boards had a
common/fsl_8xxx_ddr.c; with this change only the 517 board uses this so I have moved the ddr code into that board's directory inxpedite517x.cThe ATUM8548 board didn't appear to set up any tlbs in the
fixed_sdramcase; this patch fixes that.Signed-off-by Becky Bruce <[email protected]>Tested-by Paul Gortmaker <[email protected]>---
arch/powerpc/cpu/mpc85xx/cpu.c | 52 +++++++++++++++++ arch/powerpc/cpu/mpc8xxx/fsl_lbc.c | 10 +++ arch/powerpc/include/asm/fsl_ddr_sdram.h | 13 ++++ arch/powerpc/include/asm/fsl_lbc.h | 4 + board/freescale/mpc8536ds/mpc8536ds.c | 21 ------- board/freescale/mpc8540ads/mpc8540ads.c | 52 +---------------- board/freescale/mpc8540ads/tlb.c | 19 ------ board/freescale/mpc8541cds/mpc8541cds.c | 43 -------------- board/freescale/mpc8544ds/mpc8544ds.c | 17 ------ board/freescale/mpc8548cds/mpc8548cds.c | 38 ------------ board/freescale/mpc8555cds/mpc8555cds.c | 45 -------------- board/freescale/mpc8560ads/mpc8560ads.c | 52 +---------------- board/freescale/mpc8560ads/tlb.c | 19 ------ board/freescale/mpc8568mds/mpc8568mds.c | 38 ------------ board/freescale/mpc8569mds/mpc8569mds.c | 36 ------------ board/freescale/mpc8572ds/mpc8572ds.c | 19 ------ board/freescale/p1022ds/p1022ds.c | 13 ---- board/freescale/p1_p2_rdb/ddr.c | 15 +----- board/freescale/p2020ds/p2020ds.c | 34 ++--------- board/sbc8548/sbc8548.c | 45 +-------------- board/sbc8548/tlb.c | 34 ++++------- board/sbc8560/sbc8560.c | 93 +----------------------------- board/socrates/sdram.c | 15 +----- board/stx/stxgp3/stxgp3.c | 32 ---------- board/stx/stxssa/stxssa.c | 33 ----------- board/tqc/tqm85xx/sdram.c | 37 ------------ board/tqc/tqm85xx/tlb.c | 47 --------------- board/xes/common/Makefile | 2 - board/xes/common/fsl_8xxx_ddr.c | 46 --------------- board/xes/xpedite517x/xpedite517x.c | 13 ++++ include/configs/TQM85xx.h | 4 + 31 files changed, 121 insertions(+), 820 deletions(-)
Quoted 1 line
delete mode 100644
board/xes/common/fsl_8xxx_ddr.c
[remove bit about ATUM8548 since board has been removed]
applied to 85xx
- k
PATCH v3 3/6 mpc85xx boards: initdram() cleanup/bugfix
In reply to Becky BruceDear Becky Bruce,
Quoted 53 lines · In message <[email protected]> you…
Correct initdram to use
phys_size_tto represent the size of dram; instead of changing this all over the place, and correcting all the other random errors I've noticed, create a
common initdram that is used by all non-corenet 85xx parts. Most of theinitdram()functions were identical, with 2 common differences:1) DDR tlbs for the
fixed_sdramcase were set up ininitdram()on some boards, and were part of thetlb_tableon others. I have changed them all over to theinitdram()method - we shouldn't be accessing dram before this point so they don't need to be done sooner, and this seems cleaner.2) Parts that require the DDR11 erratum workaround had different implementations - I have adopted the version from the Freescale errata document. It also looks like some of the versions were buggy, and, depending on timing, could have resulted in the DDR controller being disabled. This seems bad.
The xpedite boards had a
common/fsl_8xxx_ddr.c; with this change only the 517 board uses this so I have moved the ddr code into that board's directory inxpedite517x.cThe ATUM8548 board didn't appear to set up any tlbs in the
fixed_sdramcase; this patch fixes that.Signed-off-by Becky Bruce <[email protected]>Tested-by Paul Gortmaker <[email protected]>--- arch/powerpc/cpu/mpc85xx/cpu.c | 52 +++++++++++++++++ arch/powerpc/cpu/mpc8xxx/fsl_lbc.c | 10 +++ arch/powerpc/include/asm/fsl_ddr_sdram.h | 13 ++++ arch/powerpc/include/asm/fsl_lbc.h | 4 + board/freescale/mpc8536ds/mpc8536ds.c | 21 ------- board/freescale/mpc8540ads/mpc8540ads.c | 52 +---------------- board/freescale/mpc8540ads/tlb.c | 19 ------ board/freescale/mpc8541cds/mpc8541cds.c | 43 -------------- board/freescale/mpc8544ds/mpc8544ds.c | 17 ------ board/freescale/mpc8548cds/mpc8548cds.c | 38 ------------ board/freescale/mpc8555cds/mpc8555cds.c | 45 -------------- board/freescale/mpc8560ads/mpc8560ads.c | 52 +---------------- board/freescale/mpc8560ads/tlb.c | 19 ------ board/freescale/mpc8568mds/mpc8568mds.c | 38 ------------ board/freescale/mpc8569mds/mpc8569mds.c | 36 ------------ board/freescale/mpc8572ds/mpc8572ds.c | 19 ------ board/freescale/p1022ds/p1022ds.c | 13 ---- board/freescale/p1_p2_rdb/ddr.c | 15 +----- board/freescale/p2020ds/p2020ds.c | 34 ++--------- board/sbc8548/sbc8548.c | 45 +-------------- board/sbc8548/tlb.c | 34 ++++------- board/sbc8560/sbc8560.c | 93 +----------------------------- board/socrates/sdram.c | 15 +----- board/stx/stxgp3/stxgp3.c | 32 ---------- board/stx/stxssa/stxssa.c | 33 -----------
Quoted 8 lines
board/tqc/tqm85xx/sdram.c | 37 ------------ board/tqc/tqm85xx/tlb.c | 47 --------------- board/xes/common/Makefile | 2 - board/xes/common/fsl_8xxx_ddr.c | 46 --------------- board/xes/xpedite517x/xpedite517x.c | 13 ++++ include/configs/TQM85xx.h | 4 + 31 files changed, 121 insertions(+), 820 deletions(-) delete mode 100644 board/xes/common/fsl_8xxx_ddr.c
As it turns out, the TQM85xx boards don't boot any more; they hang in the RAM init code.
git bisect says:
38dba0c2ff685e3f8276a236bd70eaa09c84ead5 is the first bad commit commit 38dba0c2ff685e3f8276a236bd70eaa09c84ead5
Author: Becky Bruce <[email protected]> Date: Fri Dec 17 17:17:56 2010 -0600
mpc85xx boards: initdram() cleanup/bugfix
Please help with a fix!
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Life would be so much easier if everyone read the manual.
PATCH v3 3/6 mpc85xx boards: initdram() cleanup/bugfix
Dear Becky,
ping...
Quoted 93 lines · In message <[email protected]> I wrote:
Quoted 53 lines · In message <[email protected]> you…
Correct initdram to use
phys_size_tto represent the size of dram; instead of changing this all over the place, and correcting all the other random errors I've noticed, create a
common initdram that is used by all non-corenet 85xx parts. Most of theinitdram()functions were identical, with 2 common differences:1) DDR tlbs for the
fixed_sdramcase were set up ininitdram()on some boards, and were part of thetlb_tableon others. I have changed them all over to theinitdram()method - we shouldn't be accessing dram before this point so they don't need to be done sooner, and this seems cleaner.2) Parts that require the DDR11 erratum workaround had different implementations - I have adopted the version from the Freescale errata document. It also looks like some of the versions were buggy, and, depending on timing, could have resulted in the DDR controller being disabled. This seems bad.
The xpedite boards had a
common/fsl_8xxx_ddr.c; with this change only the 517 board uses this so I have moved the ddr code into that board's directory inxpedite517x.cThe ATUM8548 board didn't appear to set up any tlbs in the
fixed_sdramcase; this patch fixes that.Signed-off-by Becky Bruce <[email protected]>Tested-by Paul Gortmaker <[email protected]>--- arch/powerpc/cpu/mpc85xx/cpu.c | 52 +++++++++++++++++ arch/powerpc/cpu/mpc8xxx/fsl_lbc.c | 10 +++ arch/powerpc/include/asm/fsl_ddr_sdram.h | 13 ++++ arch/powerpc/include/asm/fsl_lbc.h | 4 + board/freescale/mpc8536ds/mpc8536ds.c | 21 ------- board/freescale/mpc8540ads/mpc8540ads.c | 52 +---------------- board/freescale/mpc8540ads/tlb.c | 19 ------ board/freescale/mpc8541cds/mpc8541cds.c | 43 -------------- board/freescale/mpc8544ds/mpc8544ds.c | 17 ------ board/freescale/mpc8548cds/mpc8548cds.c | 38 ------------ board/freescale/mpc8555cds/mpc8555cds.c | 45 -------------- board/freescale/mpc8560ads/mpc8560ads.c | 52 +---------------- board/freescale/mpc8560ads/tlb.c | 19 ------ board/freescale/mpc8568mds/mpc8568mds.c | 38 ------------ board/freescale/mpc8569mds/mpc8569mds.c | 36 ------------ board/freescale/mpc8572ds/mpc8572ds.c | 19 ------ board/freescale/p1022ds/p1022ds.c | 13 ---- board/freescale/p1_p2_rdb/ddr.c | 15 +----- board/freescale/p2020ds/p2020ds.c | 34 ++--------- board/sbc8548/sbc8548.c | 45 +-------------- board/sbc8548/tlb.c | 34 ++++------- board/sbc8560/sbc8560.c | 93 +----------------------------- board/socrates/sdram.c | 15 +----- board/stx/stxgp3/stxgp3.c | 32 ---------- board/stx/stxssa/stxssa.c | 33 -----------Quoted 8 lines
board/tqc/tqm85xx/sdram.c | 37 ------------ board/tqc/tqm85xx/tlb.c | 47 --------------- board/xes/common/Makefile | 2 - board/xes/common/fsl_8xxx_ddr.c | 46 --------------- board/xes/xpedite517x/xpedite517x.c | 13 ++++ include/configs/TQM85xx.h | 4 + 31 files changed, 121 insertions(+), 820 deletions(-) delete mode 100644 board/xes/common/fsl_8xxx_ddr.cAs it turns out, the TQM85xx boards don't boot any more; they hang in the RAM init code.
git bisect says:
38dba0c2ff685e3f8276a236bd70eaa09c84ead5is the first bad commit commit38dba0c2ff685e3f8276a236bd70eaa09c84ead5Author: Becky Bruce <[email protected]> Date: Fri Dec 17 17:17:56 2010 -0600mpc85xx boards:
initdram()cleanup/bugfixPlease help with a fix!
Best regards,
Wolfgang Denk
Signature · 8 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Life would be so much easier if everyone read the manual. _______________________________________________ U-Boot mailing list U-Boot at lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Kumar Gala
AppliedPATCH v3 2/6 mpc85xx/tlb.c: Allow platforms to specify wimge bits
In reply to Becky BruceQuoted 8 lines · Becky Bruce
Some platforms might want to override the default wimge=0 for DDR. Add
CONFIG_SYS_PPC_DDR_WIMGEfor those platforms to use. This will initially only be used by TQM85xx, but could be useful for other boards or testing going forward. Note that the name of this define is not 85xx-specific. WIMGE is a fairly universal concept, so any ppc platforms that require different WIMGE settings for DDR can use the same #define.
Quoted 4 lines
Signed-off-by Becky Bruce <[email protected]>---
arch/powerpc/cpu/mpc85xx/tlb.c| 6 +++++-1 files changed, 5 insertions(+), 1 deletions(-)
applied to 85xx
- k
PATCH v3 1/6 tqm85xx: create fixed_sdram() to do sdram setup
In reply to Becky BruceQuoted 9 lines · Becky Bruce
Also, change this code to use
phys_size_tinstead of long int. Using common naming for this function will enable us to use the commoninitdram()for 85xx going forward. Other than the type change, this is just a code rearrange.Signed-off-by Becky Bruce <[email protected]>---
board/tqc/tqm85xx/sdram.c| 37 +++++++++++++++++++++++--------------1 files changed, 23 insertions(+), 14 deletions(-)
Stefan, Wolfgang,
Any comment as TQM85xx maintainers
- k
PATCH v3 1/6 tqm85xx: create fixed_sdram() to do sdram setup
Quoted 6 lines · On Tuesday 21 December 2010 18:52:30 Kumar Gala wrote:
Quoted 5 lines · Becky Bruce
Also, change this code to use
phys_size_tinstead of long int. Using common naming for this function will enable us to use the commoninitdram()for 85xx going forward. Other than the type change, this is just a code rearrange.
Quoted 8 lines
Quoted 4 lines
Signed-off-by Becky Bruce <[email protected]>---
board/tqc/tqm85xx/sdram.c| 37 +++++++++++++++++++++++--------------1 files changed, 23 insertions(+), 14 deletions(-)Stefan, Wolfgang,
Any comment as TQM85xx maintainers
Looks good to me, thanks:
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
Kumar Gala
AppliedPATCH v3 1/6 tqm85xx: create fixed_sdram() to do sdram setup
In reply to Becky BruceQuoted 9 lines · Becky Bruce
Also, change this code to use
phys_size_tinstead of long int. Using common naming for this function will enable us to use the commoninitdram()for 85xx going forward. Other than the type change, this is just a code rearrange.Signed-off-by Becky Bruce <[email protected]>---
board/tqc/tqm85xx/sdram.c| 37 +++++++++++++++++++++++--------------1 files changed, 23 insertions(+), 14 deletions(-)
applied to 85xx
- k