Skip to content

Go to common initdram() on 85xx-based boards

Becky Bruce u-boot 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 0 repliesNew
  2. v212 patches 0 repliesSuperseded
  3. v113 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- dropped boards that Kumar is removing
- changed spacing of printouts from lbc_sdram_init
- added the "DDR:" back to the boot messages - it makes sense to have this for some boards, and it's not much clutter
- renamed the DDR_WIMGE define per feedback

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6tqm85xx: create fixed_sdram() to do sdram setupboard/tqc/tqm85xx/sdram.c+23 -143 replies
2/6mpc85xx/tlb.c: Allow platforms to specify wimge bitsarch/powerpc/cpu/mpc85xx/tlb.c+5 -11 reply
3/6mpc85xx boards: initdram() cleanup/bugfixarch/powerpc/cpu/mpc85xx/cpu.c arch/powerpc/cpu/mpc8xxx/fsl_lbc.c arch/powerpc/include/asm/fsl_ddr_sdram.h +28 more+121 -8203 replies
4/6mpc85xx: rename sdram_init() lbc_sdram_init()arch/powerpc/cpu/mpc85xx/cpu.c arch/powerpc/cpu/mpc8xxx/fsl_lbc.c arch/powerpc/include/asm/fsl_lbc.h +7 more+11 -201 reply
5/685xx boards: Rename CONFIG_DDR_DLL to CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_INarch/powerpc/cpu/mpc85xx/cmd_errata.c arch/powerpc/cpu/mpc85xx/cpu.c doc/README.mpc85xxads +9 more+11 -121 reply
6/6MPC8xxx DDR: align informational printsarch/powerpc/cpu/mpc8xxx/ddr/main.c board/freescale/mpc8540ads/mpc8540ads.c board/freescale/mpc8541cds/mpc8541cds.c +4 more+21 -181 reply

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchPaul GortmakerStefan Roese
1/6A-b
2/6
3/6T-b
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [U-Boot] [PATCH V3 00/06] Go to common initdram() on 85xx-based boards

This patch series consists of a bunch of cleanups that allow us to use a common initdram() on all of the non-corenet 85xx-based boards. Also, switch to using phys_size_t to represent the size of memory returned.

Most of these patches are just code rearranges or renaming things to get a common scheme in place. There are also lots of cleanups - the various initdram() implementations had a variety of issues that I have hopefully fixed.

This is a large patch series, and I've had to hack on a bunch of different boards that I know nothing about, so I'd appreciate any review commentary. I have tested this on 8572DS and confirmed that the results of a MAKEALL powerpc are the same before and after this series.

Changes from V1:
- Removed prints from initdram() as suggested by Peter
- Changed spacing of 36-bit DRAM size warning messages to better line up after the removal of the excess prints from initdram()
- Switched sdram_init() to be a weak function
- renamed sdram_init() to lbc_sdram_init()

Changes from V2:
- dropped boards that Kumar is removing
- changed spacing of printouts from lbc_sdram_init
- added the "DDR:" back to the boot messages - it makes sense to have this for some boards, and it's not much clutter
- renamed the DDR_WIMGE define per feedback

Diffstat below.

Cheers,
Becly

 arch/powerpc/cpu/mpc85xx/cmd_errata.c    |    3 +
 arch/powerpc/cpu/mpc85xx/cpu.c           |   52 +++++++++++++++++
 arch/powerpc/cpu/mpc85xx/tlb.c           |    6 ++-
 arch/powerpc/cpu/mpc8xxx/ddr/main.c      |    5 +-
 arch/powerpc/cpu/mpc8xxx/fsl_lbc.c       |   10 +++
 arch/powerpc/include/asm/fsl_ddr_sdram.h |   13 ++++
 arch/powerpc/include/asm/fsl_lbc.h       |    4 +
 board/freescale/mpc8536ds/mpc8536ds.c    |   21 -------
 board/freescale/mpc8540ads/mpc8540ads.c  |   61 ++------------------
 board/freescale/mpc8540ads/tlb.c         |   19 ------
 board/freescale/mpc8541cds/mpc8541cds.c  |   52 +---------------
 board/freescale/mpc8544ds/mpc8544ds.c    |   17 ------
 board/freescale/mpc8548cds/mpc8548cds.c  |   47 +--------------
 board/freescale/mpc8555cds/mpc8555cds.c  |   54 +----------------
 board/freescale/mpc8560ads/mpc8560ads.c  |   61 ++------------------
 board/freescale/mpc8560ads/tlb.c         |   19 ------
 board/freescale/mpc8568mds/mpc8568mds.c  |   47 +--------------
 board/freescale/mpc8569mds/mpc8569mds.c  |   36 ------------
 board/freescale/mpc8572ds/mpc8572ds.c    |   19 ------
 board/freescale/p1022ds/p1022ds.c        |   13 ----
 board/freescale/p1_p2_rdb/ddr.c          |   15 +-----
 board/freescale/p2020ds/p2020ds.c        |   34 ++---------
 board/sbc8548/sbc8548.c                  |   48 +---------------
 board/sbc8548/tlb.c                      |   34 ++++-------
 board/sbc8560/sbc8560.c                  |   93 +-----------------------------
 board/socrates/sdram.c                   |   15 +-----
 board/stx/stxgp3/stxgp3.c                |   32 ----------
 board/stx/stxssa/stxssa.c                |   33 -----------
 board/tqc/tqm85xx/sdram.c                |   70 +++++++----------------
 board/tqc/tqm85xx/tlb.c                  |   47 ---------------
 board/xes/common/Makefile                |    2 -
 board/xes/common/fsl_8xxx_ddr.c          |   46 ---------------
 board/xes/xpedite517x/xpedite517x.c      |   13 ++++
 doc/README.mpc85xxads                    |    4 +-
 include/configs/MPC8536DS.h              |    1 -
 include/configs/MPC8548CDS.h             |    2 +-
 include/configs/MPC8572DS.h              |    1 -
 include/configs/P1_P2_RDB.h              |    1 -
 include/configs/SBC8540.h                |    2 +-
 include/configs/TQM85xx.h                |    6 ++-
 include/configs/sbc8560.h                |    2 +-
 include/configs/stxgp3.h                 |    2 +-
 include/configs/stxssa.h                 |    1 -
 43 files changed, 185 insertions(+), 878 deletions(-)