ARM: stm32: Use __section(".data") with dot in the section name on DHSOM
PATCH 1/1 ARM: stm32: Use __section(".data") with dot in the section name on DHSOM
The correct specifier of the section is ".data" and not "data", use the former to place the variables in ".data" section.
---
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
Cc: [email protected]
--- board/dhelectronics/dh_stm32mp1/board.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
board/dhelectronics/dh_stm32mp1/board.c +3 -3
@@ -185,9 +185,9 @@ int checkboard(void) }#ifdef CONFIG_BOARD_EARLY_INIT_F -static u8 brdcode __section("data"); -static u8 ddr3code __section("data"); -static u8 somcode __section("data"); +static u8 brdcode __section(".data"); +static u8 ddr3code __section(".data"); +static u8 somcode __section(".data"); static u32 opp_voltage_mv __section(".data");static void board_get_coding_straps (void )
Signature · 1 line
2.39.2
Hi Marek
Quoted 22 lines · Marek Vasut
The correct specifier of the section is ".data" and not "data", use the former to place the variables in ".data" section.
Fixes 731fd50e27f ("ARM: stm32: Implement board coding on AV96")Fixes 92ca0f7446c ("ARM: dts: stm32: Synchronize DDR setttings on DH SoMs")Signed-off-by Marek Vasut <[email protected]>---
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
Cc: [email protected]--- board/dhelectronics/dh_stm32mp1/board.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)board/dhelectronics/dh_stm32mp1/board.c +0
-0@@ -185,9 +185,9 @@ int checkboard(void) }
board/dhelectronics/dh_stm32mp1/board.c int checkboard(void) · line 193
Quoted 10 lines
board/dhelectronics/dh_stm32mp1/board.c +3
-3#ifdef CONFIG_BOARD_EARLY_INIT_F -static u8 brdcode __section("data"); -static u8 ddr3code __section("data"); -static u8 somcode __section("data"); +static u8 brdcode __section(".data"); +static u8 ddr3code __section(".data"); +static u8 somcode __section(".data"); static u32 opp_voltage_mv __section(".data");static void board_get_coding_straps (void )
Thanks
Patrice
Hi,
Quoted 6 lines · Marek Vasut
The correct specifier of the section is ".data" and not "data", use the former to place the variables in ".data" section.
Fixes 731fd50e27f ("ARM: stm32: Implement board coding on AV96")Fixes 92ca0f7446c ("ARM: dts: stm32: Synchronize DDR setttings on DH SoMs")Signed-off-by Marek Vasut <[email protected]>
Quoted 9 lines
---
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
Cc: [email protected]--- board/dhelectronics/dh_stm32mp1/board.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks
Patrick
Quoted 22 lines · Marek Vasut
The correct specifier of the section is ".data" and not "data", use the former to place the variables in ".data" section.
Fixes 731fd50e27f ("ARM: stm32: Implement board coding on AV96")Fixes 92ca0f7446c ("ARM: dts: stm32: Synchronize DDR setttings on DH SoMs")Signed-off-by Marek Vasut <[email protected]>---
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
Cc: [email protected]--- board/dhelectronics/dh_stm32mp1/board.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)board/dhelectronics/dh_stm32mp1/board.c +0
-0@@ -185,9 +185,9 @@ int checkboard(void) }
board/dhelectronics/dh_stm32mp1/board.c int checkboard(void) · line 193
Quoted 10 lines
board/dhelectronics/dh_stm32mp1/board.c +3
-3#ifdef CONFIG_BOARD_EARLY_INIT_F -static u8 brdcode __section("data"); -static u8 ddr3code __section("data"); -static u8 somcode __section("data"); +static u8 brdcode __section(".data"); +static u8 ddr3code __section(".data"); +static u8 somcode __section(".data"); static u32 opp_voltage_mv __section(".data");static void board_get_coding_straps (void )
Applied to u-boot-stm/next
Thanks
Patrice
Quoted 34 lines · Patrice CHOTARD
Quoted 31 lines · Marek Vasut
The correct specifier of the section is ".data" and not "data", use the former to place the variables in ".data" section.
Fixes 731fd50e27f ("ARM: stm32: Implement board coding on AV96")Fixes 92ca0f7446c ("ARM: dts: stm32: Synchronize DDR setttings on DH SoMs")Signed-off-by Marek Vasut <[email protected]>---
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
Cc: [email protected]--- board/dhelectronics/dh_stm32mp1/board.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)board/dhelectronics/dh_stm32mp1/board.c +3
-3@@ -185,9 +185,9 @@ int checkboard(void) }#ifdef CONFIG_BOARD_EARLY_INIT_F -static u8 brdcode __section("data"); -static u8 ddr3code __section("data"); -static u8 somcode __section("data"); +static u8 brdcode __section(".data"); +static u8 ddr3code __section(".data"); +static u8 somcode __section(".data"); static u32 opp_voltage_mv __section(".data");
Quoted 3 lines
board/dhelectronics/dh_stm32mp1/board.c int checkboard(void) · line 193
Quoted 1 line
board/dhelectronics/dh_stm32mp1/board.c +0
-0static void board_get_coding_straps (void )Applied to u-boot-stm/next
Since this is a bugfix, should be for current.
Quoted 37 lines · Marek Vasut
Quoted 27 lines · Patrice CHOTARD
Quoted 24 lines · Marek Vasut
The correct specifier of the section is ".data" and not "data", use the former to place the variables in ".data" section.
Fixes 731fd50e27f ("ARM: stm32: Implement board coding on AV96")Fixes 92ca0f7446c ("ARM: dts: stm32: Synchronize DDR setttings on DH SoMs")Signed-off-by Marek Vasut <[email protected]>---
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
board/dhelectronics/dh_stm32mp1/board.c| 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)board/dhelectronics/dh_stm32mp1/board.c +0
-2@@ -185,9 +185,9 @@ int checkboard(void) } #ifdef CONFIG_BOARD_EARLY_INIT_F -static u8 brdcode __section("data"); -static u8 ddr3code __section("data");Quoted 8 lines
board/dhelectronics/dh_stm32mp1/board.c int checkboard(void) · line 193
Quoted 6 lines
board/dhelectronics/dh_stm32mp1/board.c +3
-1-static u8 somcode __section("data"); +static u8 brdcode __section(".data"); +static u8 ddr3code __section(".data"); +static u8 somcode __section(".data"); static u32 opp_voltage_mv __section(".data"); static void board_get_coding_straps(void)Applied to u-boot-stm/next
Quoted 1 line
Since this is a bugfix, should be for current.
Hi Marek
Unfortunately the pull request has already sent to the mailing list :-( I will take care next time.
Patrice
Quoted 40 lines · Patrice CHOTARD
Quoted 37 lines · Marek Vasut
Quoted 35 lines · Patrice CHOTARD
Quoted 20 lines · Marek Vasut
The correct specifier of the section is ".data" and not "data", use the former to place the variables in ".data" section.
Fixes 731fd50e27f ("ARM: stm32: Implement board coding on AV96")Fixes 92ca0f7446c ("ARM: dts: stm32: Synchronize DDR setttings on DH SoMs")Signed-off-by Marek Vasut <[email protected]>---
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
Cc: [email protected]--- board/dhelectronics/dh_stm32mp1/board.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)board/dhelectronics/dh_stm32mp1/board.c +0
-0board/dhelectronics/dh_stm32mp1/board.c int checkboard(void) · line 191
Quoted 10 lines
board/dhelectronics/dh_stm32mp1/board.c +3
-3@@ -185,9 +185,9 @@ int checkboard(void) } #ifdef CONFIG_BOARD_EARLY_INIT_F -static u8 brdcode __section("data"); -static u8 ddr3code __section("data"); -static u8 somcode __section("data"); +static u8 brdcode __section(".data"); +static u8 ddr3code __section(".data"); +static u8 somcode __section(".data"); static u32 opp_voltage_mv __section(".data"); static void board_get_coding_straps(void)Applied to u-boot-stm/next
Quoted 6 lines
Quoted 1 line
Since this is a bugfix, should be for current.
Hi Marek
Unfortunately the pull request has already sent to the mailing list :-( I will take care next time.
Can you send another MR ?