Skip to contentSkip to conversation

afs: Fix memory leak in afs_put_sysnames()

PATCH Markus Elfring 2 participants 2 messages Jun 1, 2020 VFS

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines

sysnames should be freed after refcnt being decreased to zero in afs_put_sysnames().

* I suggest to use the wording “reference counter”.

* Where did you notice a “memory leak” here?

Quoted 3 lines

Besides, it would be better set net->sysnames
to 'NULL' after net->sysnames being released if afs_put_sysnames() aims on an afs_sysnames object.

* Would you like to consider an adjustment for this information?

* How do you think about to add an imperative wording?

* Will the tag “Fixes” become relevant for the commit message?

Regards,
Markus

#1 lore raw
Quoted 4 lines · Markus Elfring
Quoted 2 lines

sysnames should be freed after refcnt being decreased to zero in afs_put_sysnames().

* I suggest to use the wording “reference counter”.

Can you use ASCII quotes please? Not all fonts contain these quotes, and occasionally they got copied into commit messages.

Quoted 1 line

* Where did you notice a “memory leak” here?

He said "sysnames should be freed after refcnt being decreased to zero in afs_put_sysnames()".

Quoted 1 line

* Will the tag “Fixes” become relevant for the commit message?

It is the correct tag.

David