afs: Fix memory leak in afs_put_sysnames()
Quoted 2 lines
sysnames should be freed after refcnt being decreased to zero in
afs_put_sysnames().
* I suggest to use the wording “reference counter”.
* Where did you notice a “memory leak” here?
Quoted 3 lines
Besides, it would be better set
net->sysnames
to 'NULL' afternet->sysnamesbeing released ifafs_put_sysnames()aims on anafs_sysnamesobject.
* Would you like to consider an adjustment for this information?
* How do you think about to add an imperative wording?
* Will the tag “Fixes” become relevant for the commit message?
Regards,
Markus
Quoted 4 lines · Markus Elfring
Quoted 2 lines
sysnames should be freed after refcnt being decreased to zero in
afs_put_sysnames().* I suggest to use the wording “reference counter”.
Can you use ASCII quotes please? Not all fonts contain these quotes, and occasionally they got copied into commit messages.
Quoted 1 line
* Where did you notice a “memory leak” here?
He said "sysnames should be freed after refcnt being decreased to zero in afs_put_sysnames()".
Quoted 1 line
* Will the tag “Fixes” become relevant for the commit message?
It is the correct tag.
David