Skip to contentSkip to conversation

drm/i915: Set crtc DPMS mode to ON in intel_crtc_mode_set

PATCH In review Keith Packard 2 participants 2 messages Jul 27, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Set crtc DPMS mode to ON in intel_crtc_mode_set

This corrects the DPMS mode tracking so that the DPMS code will actually turn the CRTC off the next time the screen saves.

---
 drivers/gpu/drm/i915/intel_display.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/intel_display.c +2 -0
index fc26cb4..d9b8c15 100644
@@ -5273,6 +5273,8 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
 
 	drm_vblank_post_modeset(dev, pipe);
 
+	intel_crtc->dpms_mode = DRM_MODE_DPMS_ON;
+
 	return ret;
 }
 
Signature · 1 line
1.7.5.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · On Wed, 27 Jul 2011 01:33:36 -0700 Keith Packard <[email protected]> wrote:

This corrects the DPMS mode tracking so that the DPMS code will actually turn the CRTC off the next time the screen saves.

---
 drivers/gpu/drm/i915/intel_display.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index fc26cb4..d9b8c15 100644

drivers/gpu/drm/i915/intel_display.c static int intel_crtc_mode_set(struct drm_crtc *crtc, · line 5279

Quoted 7 lines
drivers/gpu/drm/i915/intel_display.c +2 -0
@@ -5273,6 +5273,8 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
 
 	drm_vblank_post_modeset(dev, pipe);
 
+	intel_crtc->dpms_mode = DRM_MODE_DPMS_ON;
+
 	return ret;
 }

Aside from a general objection about our seeming inability to track DPMS state properly:

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center