tags, powerpc: Update tags.sh to support _GLOBAL symbols

PATCH RESEND In review Ian Munsie 2 participants 2 messages Aug 30, 2011 – Aug 31, 2011 Kbuild

Share & tools

Ian Munsie

author

2011-08-30 01:48 UTC #0 lore raw

PATCH RESEND 1/1 tags, powerpc: Update tags.sh to support _GLOBAL symbols

On PowerPC we use _GLOBAL throughout the assembly to define symbols, but currently these symbols are missing from the tags generated with ARCH=powerpc make tags. This patch modifies the tags.sh script to recognise _GLOBAL(.*) so that these symbols will be in the tags.

This is almost (but not quite) PowerPC specific and this change should not affect anyone else:

$ git grep -E '^_GLOBAL\(([^)]*)\).*' |sed 's/^\([^/]*\/[^/]*\)\/.*$/\1/'|uniq -c
    627 arch/powerpc
      2 arch/um

Signed-off-by Ian Munsie <[email protected]>

---
I've had no (online) response to this so far - hoping that this can be picked up by someone.

 scripts/tags.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

scripts/tags.sh +2 -2

index 75c5d24f1..38f6617 100755
@@ -129,7 +129,7 @@ exuberant()
 	-I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL                      \
 	-I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
 	--extra=+f --c-kinds=+px                                \
-	--regex-asm='/^ENTRY\(([^)]*)\).*/\1/'                  \
+	--regex-asm='/^(ENTRY|_GLOBAL)\(([^)]*)\).*/\2/'        \
 	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/' \
 	--regex-c++='/^TRACE_EVENT\(([^,)]*).*/trace_\1/'		\
 	--regex-c++='/^DEFINE_EVENT\([^,)]*, *([^,)]*).*/trace_\1/'

@@ -151,7 +151,7 @@ exuberant()
 emacs()
 {
 	all_sources | xargs $1 -a                               \
-	--regex='/^ENTRY(\([^)]*\)).*/\1/'                      \
+	--regex='/^(ENTRY|_GLOBAL)(\([^)]*\)).*/\2/'            \
 	--regex='/^SYSCALL_DEFINE[0-9]?(\([^,)]*\).*/sys_\1/'   \
 	--regex='/^TRACE_EVENT(\([^,)]*\).*/trace_\1/'		\
 	--regex='/^DEFINE_EVENT([^,)]*, *\([^,)]*\).*/trace_\1/'

Signature · 1 line

1.7.2.5

Michal Marek

2011-08-31 14:32 UTC #1 lore raw

Quoted 8 lines · Ian Munsie

On PowerPC we use _GLOBAL throughout the assembly to define symbols, but currently these symbols are missing from the tags generated with ARCH=powerpc make tags. This patch modifies the tags.sh script to recognise _GLOBAL(.*) so that these symbols will be in the tags.
This is almost (but not quite) PowerPC specific and this change should not affect anyone else:

Quoted 8 lines

$ git grep -E '^_GLOBAL$([^)]*)$.*' |sed 's/^$[^/]*\/[^/]*$\/.*$/\1/'|uniq -c
    627 arch/powerpc
      2 arch/um
Signed-off-by Ian Munsie <[email protected]>
---
I've had no (online) response to this so far - hoping that this can be picked up by someone.

Applied to kbuild-2.6.git#misc now.

Thanks,
Michal