Skip to contentSkip to conversation

tags, powerpc: Update tags.sh to support _GLOBAL symbols

PATCH Superseded Ian Munsie 1 participant 1 message Aug 18, 2011

lore
Share & tools
lore

Ian Munsie

author
#0 lore raw

PATCH 1/1 tags, powerpc: Update tags.sh to support _GLOBAL symbols

I seem to have missed LKML in the CC for this patch...

--- Begin forwarded message from Ian Munsie ---
From: Ian Munsie <[email protected]>
To: Benjamin Herrenschmidt <[email protected]>, linuxppc-dev <[email protected]>, Michal Marek <[email protected]>
Cc: Ian Munsie <[email protected]>, linux-kbuild <[email protected]>
Date: Wed, 17 Aug 2011 16:25:47 +1000
Subject: [PATCH] tags, powerpc: Update tags.sh to support _GLOBAL symbols

From: Ian Munsie <[email protected]>

On PowerPC we use _GLOBAL throughout the assembly to define symbols, but currently these symbols are missing from the tags generated with ARCH=powerpc make tags. This patch modifies the tags.sh script to recognise _GLOBAL(.*) so that these symbols will be in the tags.

This is almost (but not quite) PowerPC specific and this change should not affect anyone else:

$ git grep -E '^_GLOBAL\(([^)]*)\).*' |sed 's/^\([^/]*\/[^/]*\)\/.*$/\1/'|uniq -c
    627 arch/powerpc
      2 arch/um
---
 scripts/tags.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
scripts/tags.sh +2 -2
index 75c5d24f1..38f6617 100755
@@ -129,7 +129,7 @@ exuberant()
     -I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL                      \
     -I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
     --extra=+f --c-kinds=+px                                \
-    --regex-asm='/^ENTRY\(([^)]*)\).*/\1/'                  \
+    --regex-asm='/^(ENTRY|_GLOBAL)\(([^)]*)\).*/\2/'        \
     --regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/' \
     --regex-c++='/^TRACE_EVENT\(([^,)]*).*/trace_\1/'        \
     --regex-c++='/^DEFINE_EVENT\([^,)]*, *([^,)]*).*/trace_\1/'
@@ -151,7 +151,7 @@ exuberant()
 emacs()
 {
     all_sources | xargs $1 -a                               \
-    --regex='/^ENTRY(\([^)]*\)).*/\1/'                      \
+    --regex='/^(ENTRY|_GLOBAL)(\([^)]*\)).*/\2/'            \
     --regex='/^SYSCALL_DEFINE[0-9]?(\([^,)]*\).*/sys_\1/'   \
     --regex='/^TRACE_EVENT(\([^,)]*\).*/trace_\1/'        \
     --regex='/^DEFINE_EVENT([^,)]*, *\([^,)]*\).*/trace_\1/'

--- End forwarded message ---