Skip to contentSkip to conversation

ntpclient compile fail

DISCUSSION Ni Qingliang 2 participants 8 messages Sep 27, 2011 – Sep 28, 2011

lore
Share & tools
lore
#0 lore raw

Hello:
I'm adding ntpclient into my distro.

but build fail, reason is the CFLAGS/LDFLAGS in it's Makefile didn't take effect.

What can I do?

the original makefile is:
CFLAGS += -fno-strict-aliasing
CFLAGS += -std=c89
CFLAGS += -W -Wall
CFLAGS += -O2
CFLAGS += -DENABLE_DEBUG
CFLAGS += -DENABLE_REPLAY

LDFLAGS += -lrt

all: ntpclient

test: ntpclient
./ntpclient -d -r <test.dat

ntpclient: ntpclient.o phaselock.o

ntpclient.o phaselock.o: ntpclient.h

adjtimex: adjtimex.o

clean:
rm -f ntpclient adjtimex *.o

Signature · 3 lines
Yi Qingliang
[email protected]
http://niqingliang2003.wordpress.com
#1 lore raw

I have added "override" in the head of every CFLAGS/LDFLAGS line, but error still there.

the link order is a common problem.
-Wl,-lrt ntpclient.o phaselock.o -o ntpclient
should be
ntpclient.o phaselock.o -Wl,-lrt ntpclient

Does poky have some option or some solution for that? (I build it success on host.)

Quoted 42 lines · Ni Qingliang

Hello:
I'm adding ntpclient into my distro.

but build fail, reason is the CFLAGS/LDFLAGS in it's Makefile didn't take effect.

What can I do?

the original makefile is:
CFLAGS += -fno-strict-aliasing
CFLAGS += -std=c89
CFLAGS += -W -Wall
CFLAGS += -O2
CFLAGS += -DENABLE_DEBUG
CFLAGS += -DENABLE_REPLAY

LDFLAGS += -lrt

all: ntpclient

test: ntpclient
./ntpclient -d -r <test.dat

ntpclient: ntpclient.o phaselock.o

ntpclient.o phaselock.o: ntpclient.h

adjtimex: adjtimex.o

clean:
rm -f ntpclient adjtimex *.o

--
Yi Qingliang
[email protected]
http://niqingliang2003.wordpress.com

_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

Signature · 3 lines
Yi Qingliang
[email protected]
http://niqingliang2003.wordpress.com
#2 lore raw
In reply to Ni Qingliang
Quoted 5 lines · Ni Qingliang

Hello:
I'm adding ntpclient into my distro.

but build fail, reason is the CFLAGS/LDFLAGS in it's Makefile didn't take effect.

If the CFLAGS are not taking effect from the Makefile are you over ridding the value in the recipe? Can you point us at a copy of the recipe you are using?

-M

#3 lore raw

Thanks!

the attachement is the bb file and Makefile(modified),

after 'override' CFLAGS/LDFLAGS in Makefile, I have added override LDFLAGS += -Wl,--no-as-needed
in the Makefile to neutralize the '-Wl,--as-needed' in the original LDFLAGS.

and then the world clear.

Quoted 13 lines · On Tue, 2011-09-27 at 23:46 +0800, McClintock Matthew-B29882 wrote:
Quoted 5 lines · Ni Qingliang

Hello:
I'm adding ntpclient into my distro.

but build fail, reason is the CFLAGS/LDFLAGS in it's Makefile didn't take effect.

If the CFLAGS are not taking effect from the Makefile are you over ridding the value in the recipe? Can you point us at a copy of the recipe you are using?

-M

Signature · 3 lines
Yi Qingliang
[email protected]
http://niqingliang2003.wordpress.com

DESCRIPTION = "ntpclient"
SECTION = "iotproduct"
LICENSE = "Google"
LIC_FILES_CHKSUM = "file://README;md5=098a6a289094e42f974b11e2151f5644" PR = "r0"
PV = "2010_365"

SRC_URI = "http://doolittle.icarus.com/ntpclient/ntpclient_${PV}.tar.gz \
file://Makefile"

S = "${WORKDIR}/${PN}-2010"

do_patch () {
	cp -f ${WORKDIR}/Makefile ${S}/
}

do_compile () {
oe_runmake
}

do_install () {
	install -d ${D}/bin/
	install -m 0755 ${S}/ntpclient ${D}/bin/
}

# A long time ago, far, far away, under Solaris, you needed to
# CFLAGS += -xO2 -Xc
# LDLIBS += -lnsl -lsocket
# To cross-compile
# CC = arm-linux-gcc
# To check for lint
# CFLAGS += -Wpointer-arith -Wcast-align -Wcast-qual -Wshadow -Wundef \
# -Waggregate-return -Wnested-externs -Winline -Wwrite-strings -Wstrict-prototypes

# This is old-school networking code, making the traditional cast between

# struct sockaddr* and struct sockaddr_in*.  Thus a modern gcc needs:
override CFLAGS += -fno-strict-aliasing

override CFLAGS += -std=c89
override CFLAGS += -W -Wall
override CFLAGS += -O2
# CFLAGS += -DPRECISION_SIOCGSTAMP
override CFLAGS += -DENABLE_DEBUG
override CFLAGS += -DENABLE_REPLAY
# CFLAGS += -DUSE_OBSOLETE_GETTIMEOFDAY

override LDFLAGS += -Wl,--no-as-needed
override LDFLAGS += -Wl,-lrt

all: ntpclient

test: ntpclient
./ntpclient -d -r <test.dat

ntpclient: ntpclient.o phaselock.o

ntpclient.o phaselock.o: ntpclient.h

adjtimex: adjtimex.o

clean:
rm -f ntpclient adjtimex *.o

#4 lore raw
Quoted 1 line · Ni Qingliang

the attachement is the bb file and Makefile(modified),

It usually best to include these attachments inline when possible.

Quoted 6 lines

after 'override' CFLAGS/LDFLAGS in Makefile, I have added override LDFLAGS += -Wl,--no-as-needed
in the Makefile to neutralize the '-Wl,--as-needed' in the original LDFLAGS.

and then the world clear.

Are you editing the source files in this package or the recipe itself?

-M

#5 lore raw

1. sorry, I will.
2. Yes, I made a new Makefile (based on the original) as the patch of ntpclient (which will override the original Makefile).

Quoted 16 lines · On Wed, 2011-09-28 at 09:50 +0800, McClintock Matthew-B29882 wrote:
Quoted 1 line · Ni Qingliang

the attachement is the bb file and Makefile(modified),

It usually best to include these attachments inline when possible.

Quoted 6 lines

after 'override' CFLAGS/LDFLAGS in Makefile, I have added override LDFLAGS += -Wl,--no-as-needed
in the Makefile to neutralize the '-Wl,--as-needed' in the original LDFLAGS.

and then the world clear.

Are you editing the source files in this package or the recipe itself?

-M

Signature · 3 lines
Yi Qingliang
[email protected]
http://niqingliang2003.wordpress.com
#6 lore raw
Quoted 3 lines · Ni Qingliang

1. sorry, I will.
2. Yes, I made a new Makefile (based on the original) as the patch of ntpclient (which will override the original Makefile).

There are lots of ways to do this and avoid making a patch. You can use EXTRA_OECONF, EXTRA_OEMAKE, EXTRA_CFLAGS, etc in the recipe itself to fix up the build process. You can even go and modify the variables in the do_configure, do_compile, etc build steps as well.

-M

#7 lore raw

thanks.

If we want to use the original Makefile, we must get rid of the "-e" and "-Wl,as-needed" in original arguments, for latter, we can add "-Wl,--no-as-needed", but what about the "-e"?

Quoted 12 lines · On Wed, 2011-09-28 at 10:12 +0800, McClintock Matthew-B29882 wrote:
Quoted 3 lines · Ni Qingliang

1. sorry, I will.
2. Yes, I made a new Makefile (based on the original) as the patch of ntpclient (which will override the original Makefile).

There are lots of ways to do this and avoid making a patch. You can use EXTRA_OECONF, EXTRA_OEMAKE, EXTRA_CFLAGS, etc in the recipe itself to fix up the build process. You can even go and modify the variables in the do_configure, do_compile, etc build steps as well.

-M

Signature · 3 lines
Yi Qingliang
[email protected]
http://niqingliang2003.wordpress.com