Skip to contentSkip to conversation

ext4: add blk_finish_plug in error case of writepages.

PATCH In review Namjae Jeon 3 participants 4 messages Nov 5, 2011 – Nov 7, 2011 ext4 file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext4: add blk_finish_plug in error case of writepages.

blk_finish_plug is needed in error case of writepages.

---
 fs/ext4/inode.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/ext4/inode.c +1 -0
index cc5a6da..18b262b 100644
@@ -2270,6 +2270,7 @@ retry:
 			ext4_msg(inode->i_sb, KERN_CRIT, "%s: jbd2_start: "
 			       "%ld pages, ino %lu; err %d", __func__,
 				wbc->nr_to_write, inode->i_ino, ret);
+			blk_finish_plug(&plug);
 			goto out_writepages;
 		}
 
Signature · 1 line
1.7.4.4
#1 lore raw

It's already fixed after finding the bug by original author.

Thank you,
Kyungmin Park

Quoted 28 lines · Namjae Jeon

blk_finish_plug is needed in error case of writepages.

---
 fs/ext4/inode.c |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
fs/ext4/inode.c +0 -0
index cc5a6da..18b262b 100644
@@ -2270,6 +2270,7 @@ retry:

                       ext4_msg(inode->i_sb, KERN_CRIT, "%s: jbd2_start: " "%ld pages, ino %lu; err %d", __func__, wbc->nr_to_write, inode->i_ino, ret);
+                       blk_finish_plug(&plug);
                       goto out_writepages;
               }

--
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

#2 lore raw

2011/11/5 Kyungmin Park <[email protected]>:

Quoted 4 lines

It's already fixed after finding the bug by original author.

Thank you,
Kyungmin Park

Hi. Park.
This bug is not fixed yet on the latest git of ted, Do I know to be wrong ?
Thanks.

Quoted 31 lines · Namjae Jeon
Quoted 28 lines

blk_finish_plug is needed in error case of writepages.

---
 fs/ext4/inode.c |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
fs/ext4/inode.c +0 -0
index cc5a6da..18b262b 100644
@@ -2270,6 +2270,7 @@ retry:

                       ext4_msg(inode->i_sb, KERN_CRIT, "%s: jbd2_start: " "%ld pages, ino %lu; err %d", __func__, wbc->nr_to_write, inode->i_ino, ret);
+                       blk_finish_plug(&plug);
                       goto out_writepages;
               }

--
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

maintainer
#3 lore raw
In reply to Kyungmin Park
Quoted 1 line · Kyungmin Park

It's already fixed after finding the bug by original author.

Hmm, if so I must have checked in the wrong version. My apologies.

I've applied Namjae Jeon patch as it the blk_finish_plug() does seem to be missing in the error path.

- Ted