ext4: add blk_finish_plug in error case of writepages.
PATCH 1/1 ext4: add blk_finish_plug in error case of writepages.
blk_finish_plug is needed in error case of writepages.
--- fs/ext4/inode.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
fs/ext4/inode.c +1 -0
@@ -2270,6 +2270,7 @@ retry:ext4_msg (inode->i_sb,KERN_CRIT ,"%s: jbd2_start: " "%ld pages, ino %lu; err %d" , __func__, wbc->nr_to_write, inode->i_ino, ret); +blk_finish_plug (&plug); goto out_writepages; }
Signature · 1 line
1.7.4.4
It's already fixed after finding the bug by original author.
Thank you,
Kyungmin Park
Quoted 28 lines · Namjae Jeon
blk_finish_plugis needed in error case of writepages.Signed-off-by Namjae Jeon <[email protected]>---
fs/ext4/inode.c | 1 +1 files changed, 1 insertions(+), 0 deletions(-)fs/ext4/inode.c +0
-0@@ -2270,6 +2270,7 @@ retry:ext4_msg(inode->i_sb,
KERN_CRIT, "%s:jbd2_start: " "%ld pages, ino %lu; err %d",__func__,wbc->nr_to_write,inode->i_ino, ret);
+blk_finish_plug(&plug);
gotoout_writepages;
}--
1.7.4.4--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
2011/11/5 Kyungmin Park <[email protected]>:
Quoted 4 lines
It's already fixed after finding the bug by original author.
Thank you,
Kyungmin Park
Hi. Park.
This bug is not fixed yet on the latest git of ted, Do I know to be wrong ?
Thanks.
Quoted 31 lines · Namjae Jeon
Quoted 28 lines
blk_finish_plugis needed in error case of writepages.Signed-off-by Namjae Jeon <[email protected]>---
fs/ext4/inode.c | 1 +1 files changed, 1 insertions(+), 0 deletions(-)fs/ext4/inode.c +0
-0@@ -2270,6 +2270,7 @@ retry:ext4_msg(inode->i_sb,
KERN_CRIT, "%s:jbd2_start: " "%ld pages, ino %lu; err %d",__func__,wbc->nr_to_write,inode->i_ino, ret);
+blk_finish_plug(&plug);
gotoout_writepages;
}--
1.7.4.4--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Ted Ts'o
maintainerQuoted 1 line · Kyungmin Park
It's already fixed after finding the bug by original author.
Hmm, if so I must have checked in the wrong version. My apologies.
I've applied Namjae Jeon patch as it the blk_finish_plug() does seem to be missing in the error path.
- Ted