REGRESSION: "perf: Add PM notifiers ..." breaks resume
Resume stopped working on my Acer Aspire 1830T post 3.1. The screen just stays black after wakeup.
I bisected it down to
commit 144060fee07e9c22e179d00819c83c86fbcbf82c
Author: Peter Zijlstra <[email protected]> Date: Mon Aug 1 12:49:14 2011 +0200
perf: Add PM notifiers to fix CPU hotplug races
Reverting this patch fixes the problem for me.
-Andi
Signature · 1 line
[email protected] -- Speaking for myself only.
Peter, Ingo, ping?
Quite frankly, I'm inclined to revert that patch just for being horribly ugly and apparently broken regardless of the fact that it also causes a regression.
*Notifiers* for doing something like this? smp_call_function? That's just utter sh*t, guys.
If it is CPU state, then it should damn well be suspended and resumed as part of CPU suspend and resume. No IPI cross-calls to ask other CPU's to do random work, no crap like that.
Comments? Should I just revert the thing (silence is obviously "yes" in cases like this where we are talking about regressions anyway)?
Linus
Quoted 19 lines · Andi Kleen
Resume stopped working on my Acer Aspire 1830T post 3.1. The screen just stays black after wakeup.
I bisected it down to
commit
144060fee07e9c22e179d00819c83c86fbcbf82c
Author: Peter Zijlstra <[email protected]>
Date: Mon Aug 1 12:49:14 2011 +0200perf: Add PM notifiers to fix CPU hotplug races
Reverting this patch fixes the problem for me.
-Andi
--
[email protected] -- Speaking for myself only.
Quoted 6 lines · Linus Torvalds
Peter, Ingo, ping?
Quite frankly, I'm inclined to revert that patch just for being horribly ugly and apparently broken regardless of the fact that it also causes a regression.
Quoted 6 lines
*Notifiers* for doing something like this?
smp_call_function? That's just utter sh*t, guys.If it is CPU state, then it should damn well be suspended and resumed as part of CPU suspend and resume. No IPI cross-calls to ask other CPU's to do random work, no crap like that.
Agreed, that's quite crappy.
Quoted 3 lines
Comments? Should I just revert the thing (silence is obviously "yes" in cases like this where we are talking about regressions anyway)?
Yep, please revert it until we do the right fix. (I can queue up the revert too)
Thanks,
Ingo
Quoted 3 lines · Ingo Molnar
Yep, please revert it until we do the right fix. (I can queue up the revert too)
Reverted,
Linus
Quoted 6 lines · Linus Torvalds
Quoted 3 lines · Ingo Molnar
Yep, please revert it until we do the right fix. (I can queue up the revert too)
Reverted,
Thanks!
Ingo
Quoted 3 lines · Linus Torvalds
Peter, Ingo, ping?
Shoot it.. I'll poke at it later and try and solve the thing differently.