Skip to contentSkip to conversation

REGRESSION: "perf: Add PM notifiers ..." breaks resume

DISCUSSION Andi Kleen 4 participants 6 messages Nov 2, 2011 – Nov 6, 2011

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

Resume stopped working on my Acer Aspire 1830T post 3.1. The screen just stays black after wakeup.

I bisected it down to

commit 144060fee07e9c22e179d00819c83c86fbcbf82c

Author: Peter Zijlstra <[email protected]>
Date:   Mon Aug 1 12:49:14 2011 +0200

perf: Add PM notifiers to fix CPU hotplug races

Reverting this patch fixes the problem for me.

-Andi

Signature · 1 line
[email protected] -- Speaking for myself only.
#1 lore raw

Peter, Ingo, ping?

Quite frankly, I'm inclined to revert that patch just for being horribly ugly and apparently broken regardless of the fact that it also causes a regression.

*Notifiers* for doing something like this? smp_call_function? That's just utter sh*t, guys.

If it is CPU state, then it should damn well be suspended and resumed as part of CPU suspend and resume. No IPI cross-calls to ask other CPU's to do random work, no crap like that.

Comments? Should I just revert the thing (silence is obviously "yes" in cases like this where we are talking about regressions anyway)?

Linus

Quoted 19 lines · Andi Kleen

Resume stopped working on my Acer Aspire 1830T post 3.1. The screen just stays black after wakeup.

I bisected it down to

commit 144060fee07e9c22e179d00819c83c86fbcbf82c
Author: Peter Zijlstra <[email protected]>
Date:   Mon Aug 1 12:49:14 2011 +0200

   perf: Add PM notifiers to fix CPU hotplug races

Reverting this patch fixes the problem for me.

-Andi

--
[email protected] -- Speaking for myself only.

#2 lore raw
Quoted 6 lines · Linus Torvalds

Peter, Ingo, ping?

Quite frankly, I'm inclined to revert that patch just for being horribly ugly and apparently broken regardless of the fact that it also causes a regression.

Quoted 6 lines

*Notifiers* for doing something like this? smp_call_function? That's just utter sh*t, guys.

If it is CPU state, then it should damn well be suspended and resumed as part of CPU suspend and resume. No IPI cross-calls to ask other CPU's to do random work, no crap like that.

Agreed, that's quite crappy.

Quoted 3 lines

Comments? Should I just revert the thing (silence is obviously "yes" in cases like this where we are talking about regressions anyway)?

Yep, please revert it until we do the right fix. (I can queue up the revert too)

Thanks,

Ingo

#3 lore raw
Quoted 3 lines · Ingo Molnar

Yep, please revert it until we do the right fix. (I can queue up the revert too)

Reverted,

Linus

#4 lore raw
Quoted 6 lines · Linus Torvalds
Quoted 3 lines · Ingo Molnar

Yep, please revert it until we do the right fix. (I can queue up the revert too)

Reverted,

Thanks!

Ingo